Hash :
7c8567a3
Author :
Date :
2018-02-20T15:44:07
Always add most extension symbols to symbol table An error will be generated either way if the extension symbols are used incorrectly since each use of an extension function or variable checks whether the extension is enabled. We now also track extension in unmangled built-in names, so that redefining built-ins of extensions that are not enabled can be supported. This includes refactoring the shader extension tests to share a common helper class ShaderExtensionTest. BUG=angleproject:2267 TEST=angle_unittests Change-Id: I9cc5e9bd62fa07796e69256a6a9a493531a62446 Reviewed-on: https://chromium-review.googlesource.com/926526 Commit-Queue: Olli Etuaho <oetuaho@nvidia.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90
//
// Copyright (c) 2018 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// OES_standard_derivatives_test.cpp:
// Test for OES_standard_derivatives
//
#include "tests/test_utils/ShaderExtensionTest.h"
using OESStandardDerivativesTest = sh::ShaderExtensionTest;
namespace
{
const char OESPragma[] = "#extension GL_OES_standard_derivatives : require\n";
// Shader calling dFdx()
const char ESSL100_DfdxShader[] =
R"(
precision mediump float;
varying float x;
void main()
{
gl_FragColor = vec4(dFdx(x));
})";
// Shader calling dFdy()
const char ESSL100_DfdyShader[] =
R"(
precision mediump float;
varying float x;
void main()
{
gl_FragColor = vec4(dFdy(x));
})";
// Shader calling fwidth()
const char ESSL100_FwidthShader[] =
R"(
precision mediump float;
varying float x;
void main()
{
gl_FragColor = vec4(fwidth(x));
})";
// Extension flag is required to compile properly. Expect failure when it is
// not present.
TEST_P(OESStandardDerivativesTest, CompileFailsWithoutExtension)
{
mResources.OES_standard_derivatives = 0;
InitializeCompiler();
EXPECT_FALSE(TestShaderCompile(OESPragma));
}
// Extension directive is required to compile properly. Expect failure when
// it is not present.
TEST_P(OESStandardDerivativesTest, CompileFailsWithExtensionWithoutPragma)
{
mResources.OES_standard_derivatives = 1;
InitializeCompiler();
EXPECT_FALSE(TestShaderCompile(""));
}
// With extension flag and extension directive, compiling succeeds.
// Also test that the extension directive state is reset correctly.
TEST_P(OESStandardDerivativesTest, CompileSucceedsWithExtensionAndPragma)
{
mResources.OES_standard_derivatives = 1;
InitializeCompiler();
EXPECT_TRUE(TestShaderCompile(OESPragma));
// Test reset functionality.
EXPECT_FALSE(TestShaderCompile(""));
EXPECT_TRUE(TestShaderCompile(OESPragma));
}
// The SL #version 100 shaders that are correct work similarly
// in both GL2 and GL3, with and without the version string.
INSTANTIATE_TEST_CASE_P(
CorrectESSL100Shaders,
OESStandardDerivativesTest,
Combine(Values(SH_GLES2_SPEC),
Values(sh::ESSLVersion100),
Values(ESSL100_DfdxShader, ESSL100_DfdyShader, ESSL100_FwidthShader)));
} // anonymous namespace