• Show log

    Commit

  • Hash : 90403672
    Author : Nico Weber
    Date : 2021-10-08T09:50:47

    Fix Wbitwise-instead-of-logical warnings
    
    `a && b` only evaluates b if a is true. `a & b` always evaluates
    both a and b. If a and b are of type bool, `&&` is usually what you
    want, so clang now warns on `&` where both arguments are of type bool.
    From what I can tell, in ANGLE it wasn't important if we evaluate both
    branches or not in the places where this fired, so I went with `&&`
    everywhere.
    
    Bug: chromium:1255745
    Change-Id: I7ac6a12c37f28a872de1fe9b9b96abf43e39b21c
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3212889
    Commit-Queue: Nico Weber <thakis@chromium.org>
    Commit-Queue: Jamie Madill <jmadill@chromium.org>
    Reviewed-by: Jamie Madill <jmadill@chromium.org>
    

  • Properties

  • Git HTTP https://git.kmx.io/kc3-lang/angle.git
    Git SSH git@git.kmx.io:kc3-lang/angle.git
    Public access ? public
    Description

    A conformant OpenGL ES implementation for Windows, Mac, Linux, iOS and Android.

    Homepage

    Github

    Users
    kc3_lang_org www_kmx_io thodg_w thodg_l thodg thodg_m
    Tags