kc3-lang/angle/src/libANGLE/renderer/vulkan/android/DisplayVkAndroid.cpp

• Show log

  Commit

• Hash : 5d8a89e4
  Author :
  Date : 2021-11-02T19:57:04
  

  Vulkan: Always override surface format GL_RGB8 to GL_RGBA8
  
  If an app requests to create a surface with GL_RGB8, override it to be
  GL_RGBA8 for Android.
  
  This is to workaround an issue with the Android Vulkan loader which
  limits which formats can be used with swapchains.
  
  This CL also adds GL_RGB8 back to DisplayVkAndroid::generateConfigs(),
  effectively reverting the following CL:
  https://chromium-review.googlesource.com/c/angle/angle/+/3235466
  This is being done with this CL (rather than reverting) since these
  changes are required to handle surfaces created with GL_RGB8.
  
  Bug: angleproject:6277
  Bug: angleproject:6651
  Change-Id: Iad78ea0d7bdf12e1e309ed6a7181f08fac38b9de
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3258143
  Reviewed-by: Tim Van Patten <timvp@google.com>
  Reviewed-by: Ian Elliott <ianelliott@google.com>
  Reviewed-by: Jamie Madill <jmadill@chromium.org>
  Commit-Queue: Tim Van Patten <timvp@google.com>
  

Download

• src/libANGLE/renderer/vulkan/android/DisplayVkAndroid.cpp

• //
  // Copyright 2018 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  // DisplayVkAndroid.cpp:
  //    Implements the class methods for DisplayVkAndroid.
  //
  
  #include "libANGLE/renderer/vulkan/android/DisplayVkAndroid.h"
  
  #include <android/log.h>
  #include <android/native_window.h>
  #include <vulkan/vulkan.h>
  
  #include "common/angle_version_info.h"
  #include "libANGLE/renderer/driver_utils.h"
  #include "libANGLE/renderer/vulkan/RendererVk.h"
  #include "libANGLE/renderer/vulkan/android/HardwareBufferImageSiblingVkAndroid.h"
  #include "libANGLE/renderer/vulkan/android/WindowSurfaceVkAndroid.h"
  #include "libANGLE/renderer/vulkan/vk_caps_utils.h"
  
  namespace rx
  {
  
  DisplayVkAndroid::DisplayVkAndroid(const egl::DisplayState &state) : DisplayVk(state) {}
  
  egl::Error DisplayVkAndroid::initialize(egl::Display *display)
  {
      ANGLE_TRY(DisplayVk::initialize(display));
  
      std::stringstream strstr;
      strstr << "Version (" << angle::GetANGLEVersionString() << "), ";
      strstr << "Renderer (" << mRenderer->getRendererDescription() << ")";
      __android_log_print(ANDROID_LOG_INFO, "ANGLE", "%s", strstr.str().c_str());
  
      return egl::NoError();
  }
  
  bool DisplayVkAndroid::isValidNativeWindow(EGLNativeWindowType window) const
  {
      return (ANativeWindow_getFormat(window) >= 0);
  }
  
  SurfaceImpl *DisplayVkAndroid::createWindowSurfaceVk(const egl::SurfaceState &state,
                                                       EGLNativeWindowType window)
  {
      return new WindowSurfaceVkAndroid(state, window);
  }
  
  egl::ConfigSet DisplayVkAndroid::generateConfigs()
  {
      // The list of supported swapchain formats is available at:
      // https://cs.android.com/android/platform/superproject/+/master:frameworks/native/vulkan/libvulkan/swapchain.cpp;l=465-486?q=GetNativePixelFormat
      // TODO (Issue 4062): Add conditional support for GL_RGB10_A2 and GL_RGBA16F when the
      // Android Vulkan loader adds conditional support for them.
      const std::array<GLenum, 3> kColorFormats = {GL_RGBA8, GL_RGB8, GL_RGB565};
  
      std::vector<GLenum> depthStencilFormats(
          egl_vk::kConfigDepthStencilFormats,
          egl_vk::kConfigDepthStencilFormats + ArraySize(egl_vk::kConfigDepthStencilFormats));
  
      if (getCaps().stencil8)
      {
          depthStencilFormats.push_back(GL_STENCIL_INDEX8);
      }
      return egl_vk::GenerateConfigs(kColorFormats.data(), kColorFormats.size(),
                                     depthStencilFormats.data(), depthStencilFormats.size(), this);
  }
  
  void DisplayVkAndroid::enableRecordableIfSupported(egl::Config *config)
  {
      // TODO(b/181163023): Determine how to properly query for support. This is a hack to unblock
      // launching SwANGLE on Cuttlefish.
      // anglebug.com/6612: This is also required for app compatiblity.
      config->recordable = true;
  }
  
  void DisplayVkAndroid::checkConfigSupport(egl::Config *config)
  {
      // TODO(geofflang): Test for native support and modify the config accordingly.
      // anglebug.com/2692
  
      enableRecordableIfSupported(config);
  }
  
  egl::Error DisplayVkAndroid::validateImageClientBuffer(const gl::Context *context,
                                                         EGLenum target,
                                                         EGLClientBuffer clientBuffer,
                                                         const egl::AttributeMap &attribs) const
  {
      switch (target)
      {
          case EGL_NATIVE_BUFFER_ANDROID:
              return HardwareBufferImageSiblingVkAndroid::ValidateHardwareBuffer(
                  mRenderer, clientBuffer, attribs);
  
          default:
              return DisplayVk::validateImageClientBuffer(context, target, clientBuffer, attribs);
      }
  }
  
  ExternalImageSiblingImpl *DisplayVkAndroid::createExternalImageSibling(
      const gl::Context *context,
      EGLenum target,
      EGLClientBuffer buffer,
      const egl::AttributeMap &attribs)
  {
      switch (target)
      {
          case EGL_NATIVE_BUFFER_ANDROID:
              return new HardwareBufferImageSiblingVkAndroid(buffer);
  
          default:
              return DisplayVk::createExternalImageSibling(context, target, buffer, attribs);
      }
  }
  
  const char *DisplayVkAndroid::getWSIExtension() const
  {
      return VK_KHR_ANDROID_SURFACE_EXTENSION_NAME;
  }
  
  bool IsVulkanAndroidDisplayAvailable()
  {
      return true;
  }
  
  DisplayImpl *CreateVulkanAndroidDisplay(const egl::DisplayState &state)
  {
      return new DisplayVkAndroid(state);
  }
  }  // namespace rx
  

Download