kc3-lang/angle/src/libANGLE/validationES2.h

• Show log

  Commit

• Hash : 2aa5286d
  Author :
  Date : 2021-10-12T17:05:48
  

  Add Entry Point name to validation errors
  
  Add gl/gles entry point names to validation error messages
  
  some special cases:
  1. Debug::insertPerfWarning() is invoked from multiple places,
  such as TextureVK, ContextVK,
  adding an extra entryPoint function parameter
  in these files will need
  extra investigations.
  I am passing the entryPoint name GLInvalid as a
  temp workaround.
  
  2.ErrorSet::hangleError() is invoked from multiple
  Context*.cpp files,
  adding an extra entryPoint function parameter
  in these files will need
  extra investigations.
  I am passing the entryPoint name GLInvalid as a
  temp workaround.
  
  3. Debug::insertMessage(), Debug::popGroup(), Debug::pushGroup()
  can be invoked from more than one GL entry points,
  e.g. Debug::pushGroup() can be invoked from
  either GL_APIENTRY GL_PushDebugGroup() or
  GL_APIENTRY GL_PushDebugGroupKHR()
  through context->pushDebugGroup() call.
  Right now the same entry point name glPushDebugGroup will
  be printed out in the error message for both cases.
  However, we should be able to tell the actual entry point
  by checking which version: KHR version or core version the
  application uses, and this helps avoid the confusion.
  For now we will let the same entry point name
  getting printed for both cases.
  
  Bug: angleproject:6523
  Change-Id: I64a5463d9168d8444d376d1f428c3b3d894f2ea9
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3215063
  Reviewed-by: Jamie Madill <jmadill@chromium.org>
  Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
  Commit-Queue: Yuxin Hu <yuxinhu@google.com>
  

Download

• src/libANGLE/validationES2.h

• //
  // Copyright 2018 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  // validationES2.h:
  //  Inlined validation functions for OpenGL ES 2.0 entry points.
  
  #ifndef LIBANGLE_VALIDATION_ES2_H_
  #define LIBANGLE_VALIDATION_ES2_H_
  
  #include "libANGLE/ErrorStrings.h"
  #include "libANGLE/validationES.h"
  #include "libANGLE/validationES2_autogen.h"
  
  namespace gl
  {
  ANGLE_INLINE bool ValidateDrawArrays(const Context *context,
                                       angle::EntryPoint entryPoint,
                                       PrimitiveMode mode,
                                       GLint first,
                                       GLsizei count)
  {
      return ValidateDrawArraysCommon(context, entryPoint, mode, first, count, 1);
  }
  
  ANGLE_INLINE bool ValidateUniform2f(const Context *context,
                                      angle::EntryPoint entryPoint,
                                      UniformLocation location,
                                      GLfloat x,
                                      GLfloat y)
  {
      return ValidateUniform(context, entryPoint, GL_FLOAT_VEC2, location, 1);
  }
  
  ANGLE_INLINE bool ValidateBindBuffer(const Context *context,
                                       angle::EntryPoint entryPoint,
                                       BufferBinding target,
                                       BufferID buffer)
  {
      if (!context->isValidBufferBinding(target))
      {
          context->validationError(entryPoint, GL_INVALID_ENUM, err::kInvalidBufferTypes);
          return false;
      }
  
      if (!context->getState().isBindGeneratesResourceEnabled() &&
          !context->isBufferGenerated(buffer))
      {
          context->validationError(entryPoint, GL_INVALID_OPERATION, err::kObjectNotGenerated);
          return false;
      }
  
      return true;
  }
  
  ANGLE_INLINE bool ValidateDrawElements(const Context *context,
                                         angle::EntryPoint entryPoint,
                                         PrimitiveMode mode,
                                         GLsizei count,
                                         DrawElementsType type,
                                         const void *indices)
  {
      return ValidateDrawElementsCommon(context, entryPoint, mode, count, type, indices, 1);
  }
  
  ANGLE_INLINE bool ValidateVertexAttribPointer(const Context *context,
                                                angle::EntryPoint entryPoint,
                                                GLuint index,
                                                GLint size,
                                                VertexAttribType type,
                                                GLboolean normalized,
                                                GLsizei stride,
                                                const void *ptr)
  {
      if (!ValidateFloatVertexFormat(context, entryPoint, index, size, type))
      {
          return false;
      }
  
      if (stride < 0)
      {
          context->validationError(entryPoint, GL_INVALID_VALUE, err::kNegativeStride);
          return false;
      }
  
      if (context->getClientVersion() >= ES_3_1)
      {
          const Caps &caps = context->getCaps();
          if (stride > caps.maxVertexAttribStride)
          {
              context->validationError(entryPoint, GL_INVALID_VALUE,
                                       err::kExceedsMaxVertexAttribStride);
              return false;
          }
  
          if (index >= static_cast<GLuint>(caps.maxVertexAttribBindings))
          {
              context->validationError(entryPoint, GL_INVALID_VALUE,
                                       err::kExceedsMaxVertexAttribBindings);
              return false;
          }
      }
  
      // [OpenGL ES 3.0.2] Section 2.8 page 24:
      // An INVALID_OPERATION error is generated when a non-zero vertex array object
      // is bound, zero is bound to the ARRAY_BUFFER buffer object binding point,
      // and the pointer argument is not NULL.
      bool nullBufferAllowed = context->getState().areClientArraysEnabled() &&
                               context->getState().getVertexArray()->id().value == 0;
      if (!nullBufferAllowed && context->getState().getTargetBuffer(BufferBinding::Array) == 0 &&
          ptr != nullptr)
      {
          context->validationError(entryPoint, GL_INVALID_OPERATION, err::kClientDataInVertexArray);
          return false;
      }
  
      if (context->isWebGL())
      {
          // WebGL 1.0 [Section 6.14] Fixed point support
          // The WebGL API does not support the GL_FIXED data type.
          if (type == VertexAttribType::Fixed)
          {
              context->validationError(entryPoint, GL_INVALID_ENUM, err::kFixedNotInWebGL);
              return false;
          }
  
          if (!ValidateWebGLVertexAttribPointer(context, entryPoint, type, normalized, stride, ptr,
                                                false))
          {
              return false;
          }
      }
  
      return true;
  }
  
  void RecordBindTextureTypeError(const Context *context,
                                  angle::EntryPoint entryPoint,
                                  TextureType target);
  
  ANGLE_INLINE bool ValidateBindTexture(const Context *context,
                                        angle::EntryPoint entryPoint,
                                        TextureType target,
                                        TextureID texture)
  {
      if (!context->getStateCache().isValidBindTextureType(target))
      {
          RecordBindTextureTypeError(context, entryPoint, target);
          return false;
      }
  
      if (texture.value == 0)
      {
          return true;
      }
  
      Texture *textureObject = context->getTexture(texture);
      if (textureObject && textureObject->getType() != target)
      {
          context->validationError(entryPoint, GL_INVALID_OPERATION, err::kTextureTargetMismatch);
          return false;
      }
  
      if (!context->getState().isBindGeneratesResourceEnabled() &&
          !context->isTextureGenerated(texture))
      {
          context->validationError(entryPoint, GL_INVALID_OPERATION, err::kObjectNotGenerated);
          return false;
      }
  
      return true;
  }
  
  // Validation of all Tex[Sub]Image2D parameters except TextureTarget.
  bool ValidateES2TexImageParametersBase(const Context *context,
                                         angle::EntryPoint entryPoint,
                                         TextureTarget target,
                                         GLint level,
                                         GLenum internalformat,
                                         bool isCompressed,
                                         bool isSubImage,
                                         GLint xoffset,
                                         GLint yoffset,
                                         GLsizei width,
                                         GLsizei height,
                                         GLint border,
                                         GLenum format,
                                         GLenum type,
                                         GLsizei imageSize,
                                         const void *pixels);
  
  // Validation of TexStorage*2DEXT
  bool ValidateES2TexStorageParametersBase(const Context *context,
                                           angle::EntryPoint entryPoint,
                                           TextureType target,
                                           GLsizei levels,
                                           GLenum internalformat,
                                           GLsizei width,
                                           GLsizei height);
  
  }  // namespace gl
  
  #endif  // LIBANGLE_VALIDATION_ES2_H_
  

Download