kc3-lang/angle/src/libANGLE/validationES3.h

• Show log

  Commit

• Hash : 2aa5286d
  Author :
  Date : 2021-10-12T17:05:48
  

  Add Entry Point name to validation errors
  
  Add gl/gles entry point names to validation error messages
  
  some special cases:
  1. Debug::insertPerfWarning() is invoked from multiple places,
  such as TextureVK, ContextVK,
  adding an extra entryPoint function parameter
  in these files will need
  extra investigations.
  I am passing the entryPoint name GLInvalid as a
  temp workaround.
  
  2.ErrorSet::hangleError() is invoked from multiple
  Context*.cpp files,
  adding an extra entryPoint function parameter
  in these files will need
  extra investigations.
  I am passing the entryPoint name GLInvalid as a
  temp workaround.
  
  3. Debug::insertMessage(), Debug::popGroup(), Debug::pushGroup()
  can be invoked from more than one GL entry points,
  e.g. Debug::pushGroup() can be invoked from
  either GL_APIENTRY GL_PushDebugGroup() or
  GL_APIENTRY GL_PushDebugGroupKHR()
  through context->pushDebugGroup() call.
  Right now the same entry point name glPushDebugGroup will
  be printed out in the error message for both cases.
  However, we should be able to tell the actual entry point
  by checking which version: KHR version or core version the
  application uses, and this helps avoid the confusion.
  For now we will let the same entry point name
  getting printed for both cases.
  
  Bug: angleproject:6523
  Change-Id: I64a5463d9168d8444d376d1f428c3b3d894f2ea9
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3215063
  Reviewed-by: Jamie Madill <jmadill@chromium.org>
  Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
  Commit-Queue: Yuxin Hu <yuxinhu@google.com>
  

Download

• src/libANGLE/validationES3.h

• //
  // Copyright 2018 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  // validationES3.h:
  //  Inlined validation functions for OpenGL ES 3.0 entry points.
  
  #ifndef LIBANGLE_VALIDATION_ES3_H_
  #define LIBANGLE_VALIDATION_ES3_H_
  
  #include "libANGLE/ErrorStrings.h"
  #include "libANGLE/validationES3_autogen.h"
  
  namespace gl
  {
  bool ValidateES3TexImageParametersBase(const Context *context,
                                         angle::EntryPoint entryPoint,
                                         TextureTarget target,
                                         GLint level,
                                         GLenum internalformat,
                                         bool isCompressed,
                                         bool isSubImage,
                                         GLint xoffset,
                                         GLint yoffset,
                                         GLint zoffset,
                                         GLsizei width,
                                         GLsizei height,
                                         GLsizei depth,
                                         GLint border,
                                         GLenum format,
                                         GLenum type,
                                         GLsizei imageSize,
                                         const void *pixels);
  
  bool ValidateProgramParameteriBase(const Context *context,
                                     angle::EntryPoint entryPoint,
                                     ShaderProgramID program,
                                     GLenum pname,
                                     GLint value);
  }  // namespace gl
  
  #endif  // LIBANGLE_VALIDATION_ES3_H_
  

Download