Hash :
f4140c76
Author :
Date :
2024-05-10T16:56:13
Remove share group lock from glBindBuffer This is a very hot function. Removing the share group lock from this function improves the driver_overhead_2 execution time by ~1ms on Pixel 6. Bug: angleproject:8667 Change-Id: I9ea04f48aa1d2d0efec21407374393e88a1316e3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5533081 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360
//
// Copyright 2002 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// RefCountObject.h: Defines the gl::RefCountObject base class that provides
// lifecycle support for GL objects using the traditional BindObject scheme, but
// that need to be reference counted for correct cross-context deletion.
// (Concretely, textures, buffers and renderbuffers.)
#ifndef LIBANGLE_REFCOUNTOBJECT_H_
#define LIBANGLE_REFCOUNTOBJECT_H_
#include "angle_gl.h"
#include "common/PackedEnums.h"
#include "common/debug.h"
#include "libANGLE/Error.h"
#include "libANGLE/Observer.h"
#include "libANGLE/renderer/serial_utils.h"
#include <cstddef>
namespace angle
{
template <typename ContextT, typename ErrorT>
class RefCountObject : angle::NonCopyable
{
public:
using ContextType = ContextT;
using ErrorType = ErrorT;
RefCountObject() : mRefCount(0) {}
virtual void onDestroy(const ContextType *context) {}
void addRef() const { ++mRefCount; }
ANGLE_INLINE void release(const ContextType *context)
{
ASSERT(mRefCount > 0);
if (--mRefCount == 0)
{
onDestroy(context);
delete this;
}
}
size_t getRefCount() const { return mRefCount; }
protected:
virtual ~RefCountObject() { ASSERT(mRefCount == 0); }
mutable size_t mRefCount;
};
// Alternative base class to RefCountObject using atomics to track the reference count.
// Interchangable with RefCountObject for usage with BindingPointer and other wrappers.
template <typename ContextT, typename ErrorT>
class ThreadSafeRefCountObject : angle::NonCopyable
{
public:
using ContextType = ContextT;
using ErrorType = ErrorT;
ThreadSafeRefCountObject() : mRefCount(0) {}
virtual void onDestroy(const ContextType *context) {}
void addRef() const { mRefCount.fetch_add(1, std::memory_order_relaxed); }
ANGLE_INLINE void release(const ContextType *context)
{
ASSERT(mRefCount > 0);
if (mRefCount.fetch_sub(1, std::memory_order_acq_rel) == 1)
{
onDestroy(context);
delete this;
}
}
size_t getRefCount() const { return mRefCount; }
protected:
virtual ~ThreadSafeRefCountObject() { ASSERT(mRefCount == 0); }
mutable std::atomic<size_t> mRefCount;
};
template <class ObjectType, typename ContextT, typename ErrorT = angle::Result>
class RefCountObjectReleaser : angle::NonCopyable
{
public:
using ContextType = ContextT;
using ErrorType = ErrorT;
RefCountObjectReleaser() {}
RefCountObjectReleaser(const ContextType *context, ObjectType *object)
: mContext(context), mObject(object)
{}
RefCountObjectReleaser(RefCountObjectReleaser &&other)
: mContext(other.mContext), mObject(other.mObject)
{
other.mContext = nullptr;
other.mObject = nullptr;
}
RefCountObjectReleaser &operator=(RefCountObjectReleaser &&other)
{
std::swap(mContext, other.mContext);
std::swap(mObject, other.mObject);
return *this;
}
~RefCountObjectReleaser()
{
if (mObject)
{
mObject->release(mContext);
mObject = nullptr;
}
}
private:
const ContextType *mContext = nullptr;
ObjectType *mObject = nullptr;
};
template <class ObjectType, typename ContextT, typename ErrorT = angle::Result>
class BindingPointer
{
public:
using ContextType = ContextT;
using ErrorType = ErrorT;
BindingPointer() : mObject(nullptr) {}
BindingPointer(ObjectType *object) : mObject(object)
{
if (mObject)
{
mObject->addRef();
}
}
BindingPointer(const BindingPointer &other) : mObject(other.mObject)
{
if (mObject)
{
mObject->addRef();
}
}
BindingPointer &operator=(BindingPointer &&other)
{
std::swap(mObject, other.mObject);
return *this;
}
virtual ~BindingPointer()
{
// Objects have to be released before the resource manager is destroyed, so they must be
// explicitly cleaned up.
ASSERT(mObject == nullptr);
}
RefCountObjectReleaser<ObjectType, ContextType, ErrorT> set(const ContextType *context,
ObjectType *newObject)
{
// addRef first in case newObject == mObject and this is the last reference to it.
if (newObject != nullptr)
{
newObject->addRef();
}
// Store the old pointer in a temporary so we can set the pointer before calling release.
// Otherwise the object could still be referenced when its destructor is called.
ObjectType *oldObject = mObject;
mObject = newObject;
return RefCountObjectReleaser<ObjectType, ContextType, ErrorT>(context, oldObject);
}
void assign(ObjectType *object) { mObject = object; }
ObjectType *get() const { return mObject; }
ObjectType *operator->() const { return mObject; }
bool operator==(const BindingPointer &other) const { return mObject == other.mObject; }
bool operator!=(const BindingPointer &other) const { return !(*this == other); }
protected:
ANGLE_INLINE void setImpl(ObjectType *obj) { mObject = obj; }
private:
ObjectType *mObject;
};
} // namespace angle
namespace gl
{
class Context;
template <class ObjectType>
class BindingPointer;
using RefCountObjectNoID = angle::RefCountObject<Context, angle::Result>;
using ThreadSafeRefCountObjectNoID = angle::ThreadSafeRefCountObject<Context, angle::Result>;
template <typename IDType, typename RC = RefCountObjectNoID>
class RefCountObject : public RC
{
public:
explicit RefCountObject(rx::UniqueSerial serial, IDType id) : mSerial(serial), mId(id) {}
rx::UniqueSerial serial() const { return mSerial; }
IDType id() const { return mId; }
protected:
~RefCountObject() override {}
private:
// Unique serials are used to identify resources for frame capture.
rx::UniqueSerial mSerial;
IDType mId;
};
template <typename IDType>
using ThreadSafeRefCountObject = RefCountObject<IDType, ThreadSafeRefCountObjectNoID>;
template <class ObjectType>
class BindingPointer : public angle::BindingPointer<ObjectType, Context>
{
public:
using ContextType = typename angle::BindingPointer<ObjectType, Context>::ContextType;
using ErrorType = typename angle::BindingPointer<ObjectType, Context>::ErrorType;
BindingPointer() {}
BindingPointer(ObjectType *object) : angle::BindingPointer<ObjectType, Context>(object) {}
typename ResourceTypeToID<ObjectType>::IDType id() const
{
ObjectType *obj = this->get();
if (obj)
return obj->id();
return {0};
}
};
template <class ObjectType>
class OffsetBindingPointer : public BindingPointer<ObjectType>
{
public:
using ContextType = typename BindingPointer<ObjectType>::ContextType;
using ErrorType = typename BindingPointer<ObjectType>::ErrorType;
OffsetBindingPointer() : mOffset(0), mSize(0) {}
void set(const ContextType *context, ObjectType *newObject, GLintptr offset, GLsizeiptr size)
{
set(context, newObject);
updateOffsetAndSize(newObject, offset, size);
}
GLintptr getOffset() const { return mOffset; }
GLsizeiptr getSize() const { return mSize; }
bool operator==(const OffsetBindingPointer<ObjectType> &other) const
{
return this->get() == other.get() && mOffset == other.mOffset && mSize == other.mSize;
}
bool operator!=(const OffsetBindingPointer<ObjectType> &other) const
{
return !(*this == other);
}
void assign(ObjectType *newObject, GLintptr offset, GLsizeiptr size)
{
assign(newObject);
updateOffsetAndSize(newObject, offset, size);
}
private:
ANGLE_INLINE void updateOffsetAndSize(ObjectType *newObject, GLintptr offset, GLsizeiptr size)
{
if (newObject)
{
mOffset = offset;
mSize = size;
}
else
{
mOffset = 0;
mSize = 0;
}
}
// Delete the unparameterized functions. This forces an explicit offset and size.
using BindingPointer<ObjectType>::set;
using BindingPointer<ObjectType>::assign;
GLintptr mOffset;
GLsizeiptr mSize;
};
template <typename SubjectT>
class SubjectBindingPointer : protected BindingPointer<SubjectT>, public angle::ObserverBindingBase
{
public:
SubjectBindingPointer(angle::ObserverInterface *observer, angle::SubjectIndex index)
: ObserverBindingBase(observer, index)
{}
~SubjectBindingPointer() override {}
SubjectBindingPointer(const SubjectBindingPointer &other) = default;
SubjectBindingPointer &operator=(const SubjectBindingPointer &other) = default;
void bind(const Context *context, SubjectT *subject)
{
// AddRef first in case subject == get()
if (subject)
{
subject->addObserver(this);
subject->addRef();
}
if (get())
{
get()->removeObserver(this);
get()->release(context);
}
this->setImpl(subject);
}
using BindingPointer<SubjectT>::get;
using BindingPointer<SubjectT>::operator->;
friend class State;
};
} // namespace gl
namespace egl
{
class Display;
using RefCountObject = angle::RefCountObject<Display, Error>;
using ThreadSafeRefCountObject = angle::ThreadSafeRefCountObject<Display, Error>;
template <class ObjectType>
using RefCountObjectReleaser = angle::RefCountObjectReleaser<ObjectType, Display, Error>;
template <class ObjectType>
using BindingPointer = angle::BindingPointer<ObjectType, Display, Error>;
} // namespace egl
#endif // LIBANGLE_REFCOUNTOBJECT_H_