kc3-lang/angle/src/libANGLE/TransformFeedback.h

• Show log

  Commit

• Hash : e8a93c6e
  Author :
  Date : 2018-01-04T18:02:24
  

  New transform feedback buffer binding rules
  
  Detects undefined behavior when a buffer is bound to a transform feedback
  binding point and a non transform feedback binding point at the same time.
  
  Also moves the transform feedback buffer generic binding point out of the
  transform feedback object and into the context's global state, to match
  driver behavior. This way binding a new transform feedback object does not
  affect GL_TRANSFORM_FEEDBACK_BUFFER_BINDING which is similar to how VAOs
  work with GL_ARRAY_BUFFER_BINDING.
  
  Bug: 696345
  Change-Id: If3b9306cde7cd2197a8ce35e10c3af9ee58da0b8
  Reviewed-on: https://chromium-review.googlesource.com/853130
  Commit-Queue: James Darpinian <jdarpinian@chromium.org>
  Reviewed-by: Jamie Madill <jmadill@chromium.org>
  Reviewed-by: Geoff Lang <geofflang@chromium.org>
  

Download

• src/libANGLE/TransformFeedback.h

• //
  // Copyright (c) 2014 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  
  #ifndef LIBANGLE_TRANSFORM_FEEDBACK_H_
  #define LIBANGLE_TRANSFORM_FEEDBACK_H_
  
  #include "libANGLE/RefCountObject.h"
  
  #include "common/angleutils.h"
  #include "libANGLE/Debug.h"
  
  #include "angle_gl.h"
  
  namespace rx
  {
  class GLImplFactory;
  class TransformFeedbackImpl;
  }
  
  namespace gl
  {
  class Buffer;
  struct Caps;
  class Context;
  class Program;
  
  class TransformFeedbackState final : angle::NonCopyable
  {
    public:
      TransformFeedbackState(size_t maxIndexedBuffers);
      ~TransformFeedbackState();
  
      const OffsetBindingPointer<Buffer> &getIndexedBuffer(size_t idx) const;
      const std::vector<OffsetBindingPointer<Buffer>> &getIndexedBuffers() const;
  
    private:
      friend class TransformFeedback;
  
      std::string mLabel;
  
      bool mActive;
      GLenum mPrimitiveMode;
      bool mPaused;
  
      Program *mProgram;
  
      std::vector<OffsetBindingPointer<Buffer>> mIndexedBuffers;
  };
  
  class TransformFeedback final : public RefCountObject, public LabeledObject
  {
    public:
      TransformFeedback(rx::GLImplFactory *implFactory, GLuint id, const Caps &caps);
      ~TransformFeedback() override;
      Error onDestroy(const Context *context) override;
  
      void setLabel(const std::string &label) override;
      const std::string &getLabel() const override;
  
      void begin(const Context *context, GLenum primitiveMode, Program *program);
      void end(const Context *context);
      void pause();
      void resume();
  
      bool isActive() const;
      bool isPaused() const;
      GLenum getPrimitiveMode() const;
  
      bool hasBoundProgram(GLuint program) const;
  
      void bindIndexedBuffer(const Context *context,
                             size_t index,
                             Buffer *buffer,
                             size_t offset,
                             size_t size);
      const OffsetBindingPointer<Buffer> &getIndexedBuffer(size_t index) const;
      size_t getIndexedBufferCount() const;
  
      // Returns true if any buffer bound to this object is also bound to another target.
      bool buffersBoundForOtherUse() const;
  
      void detachBuffer(const Context *context, GLuint bufferName);
  
      rx::TransformFeedbackImpl *getImplementation();
      const rx::TransformFeedbackImpl *getImplementation() const;
  
      void onBindingChanged(bool bound);
  
    private:
      void bindProgram(const Context *context, Program *program);
  
      TransformFeedbackState mState;
      rx::TransformFeedbackImpl* mImplementation;
  };
  
  }
  
  #endif // LIBANGLE_TRANSFORM_FEEDBACK_H_
  

Download