kc3-lang/angle/src/libANGLE/CLImage.cpp

• Show log

  Commit

• Hash : 25390156
  Author :
  Date : 2025-08-21T00:13:19
  

  Suppress unsafe buffers on a file-by-file basis in src/ [1 of N]
  
  In this CL, we suppress many files but stop short of actually
  enabling the warning by not removing the line from the
  unsafe_buffers_paths.txt file. That will happen in a follow-on
  CL, along with resolving any stragglers missed here.
  
  This is mostly a manual change so as to familiarize myself with
  the kinds of issues faced by the Angle codebase when applying buffer
  safety warnings.
  
  -- Re-generate affected hashes.
  -- Clang-format applied to all changed files.
  -- Add a few missing .reserve() calls to vectors as noticed.
  -- Fix some mismatches between file names and header comments.
  -- Be more consistent with header comment format (blank lines and
     trailing //-only lines when a filename comment adjoins license
     boilerplate).
  
  Bug: b/436880895
  Change-Id: I3bde5cc2059acbe8345057289214f1a26f1c34aa
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6869022
  Reviewed-by: Geoff Lang <geofflang@chromium.org>
  Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
  Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
  

Download

• src/libANGLE/CLImage.cpp

• //
  // Copyright 2021 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  // CLImage.cpp: Implements the cl::Image class.
  //
  
  #ifdef UNSAFE_BUFFERS_BUILD
  #    pragma allow_unsafe_buffers
  #endif
  
  #include "libANGLE/CLImage.h"
  #include "libANGLE/CLContext.h"
  #include "libANGLE/cl_utils.h"
  
  #include <cstring>
  
  namespace cl
  {
  
  bool Image::IsTypeValid(MemObjectType imageType)
  {
      switch (imageType)
      {
          case MemObjectType::Image1D:
          case MemObjectType::Image2D:
          case MemObjectType::Image3D:
          case MemObjectType::Image1D_Array:
          case MemObjectType::Image2D_Array:
          case MemObjectType::Image1D_Buffer:
              break;
          default:
              return false;
      }
      return true;
  }
  
  angle::Result Image::getInfo(ImageInfo name,
                               size_t valueSize,
                               void *value,
                               size_t *valueSizeRet) const
  {
      size_t valSizeT       = 0u;
      void *valPointer      = nullptr;
      const void *copyValue = nullptr;
      size_t copySize       = 0u;
  
      switch (name)
      {
          case ImageInfo::Format:
              copyValue = &mFormat;
              copySize  = sizeof(mFormat);
              break;
          case ImageInfo::ElementSize:
              valSizeT  = GetElementSize(mFormat);
              copyValue = &valSizeT;
              copySize  = sizeof(valSizeT);
              break;
          case ImageInfo::RowPitch:
              copyValue = &mDesc.rowPitch;
              copySize  = sizeof(mDesc.rowPitch);
              break;
          case ImageInfo::SlicePitch:
              copyValue = &mDesc.slicePitch;
              copySize  = sizeof(mDesc.slicePitch);
              break;
          case ImageInfo::Width:
              copyValue = &mDesc.width;
              copySize  = sizeof(mDesc.width);
              break;
          case ImageInfo::Height:
              copyValue = Is1DImage(mDesc.type) ? &valSizeT : &mDesc.height;
              copySize  = sizeof(mDesc.height);
              break;
          case ImageInfo::Depth:
              copyValue = Is3DImage(mDesc.type) ? &mDesc.depth : &valSizeT;
              copySize  = sizeof(mDesc.depth);
              break;
          case ImageInfo::ArraySize:
              copyValue = IsArrayType(mDesc.type) ? &mDesc.arraySize : &valSizeT;
              copySize  = sizeof(mDesc.arraySize);
              break;
          case ImageInfo::Buffer:
              valPointer = Memory::CastNative(mParent.get());
              copyValue  = &valPointer;
              copySize   = sizeof(valPointer);
              break;
          case ImageInfo::NumMipLevels:
              copyValue = &mDesc.numMipLevels;
              copySize  = sizeof(mDesc.numMipLevels);
              break;
          case ImageInfo::NumSamples:
              copyValue = &mDesc.numSamples;
              copySize  = sizeof(mDesc.numSamples);
              break;
          default:
              ANGLE_CL_RETURN_ERROR(CL_INVALID_VALUE);
      }
  
      if (value != nullptr)
      {
          // CL_INVALID_VALUE if size in bytes specified by param_value_size is < size of return type
          // as described in the Image Object Queries table and param_value is not NULL.
          if (valueSize < copySize)
          {
              ANGLE_CL_RETURN_ERROR(CL_INVALID_VALUE);
          }
          if (copyValue != nullptr)
          {
              std::memcpy(value, copyValue, copySize);
          }
      }
      if (valueSizeRet != nullptr)
      {
          *valueSizeRet = copySize;
      }
      return angle::Result::Continue;
  }
  
  Image::~Image() = default;
  
  bool Image::isRegionValid(const cl::MemOffsets &origin, const cl::Coordinate &region) const
  {
      switch (getType())
      {
          case MemObjectType::Image1D:
          case MemObjectType::Image1D_Buffer:
              return origin.x + region.x <= mDesc.width;
          case MemObjectType::Image2D:
              return origin.x + region.x <= mDesc.width && origin.y + region.y <= mDesc.height;
          case MemObjectType::Image3D:
              return origin.x + region.x <= mDesc.width && origin.y + region.y <= mDesc.height &&
                     origin.z + region.z <= mDesc.depth;
          case MemObjectType::Image1D_Array:
              return origin.x + region.x <= mDesc.width && origin.y + region.y <= mDesc.arraySize;
          case MemObjectType::Image2D_Array:
              return origin.x + region.x <= mDesc.width && origin.y + region.y <= mDesc.height &&
                     origin.z + region.z <= mDesc.arraySize;
          default:
              ASSERT(false);
              break;
      }
      return false;
  }
  
  Image::Image(Context &context,
               PropArray &&properties,
               MemFlags flags,
               const cl_image_format &format,
               const ImageDescriptor &desc,
               Memory *parent,
               void *hostPtr)
      : Memory(context, std::move(properties), flags, parent, hostPtr), mFormat(format), mDesc(desc)
  {
      mSize = getSliceSize() * getDepth() * getArraySize();
      ANGLE_CL_IMPL_TRY(context.getImpl().createImage(*this, hostPtr, &mImpl));
  }
  
  }  // namespace cl
  

Download