kc3-lang/angle/src/gpu_info_util

Diff

• Show log

  Commit

• Hash : d5ab1331
  Author :
  Date : 2025-04-09T20:26:47
  

  Reland^2 "Enable VVL on vulkan instance created in GetSystemInfoVulkanWithICD"
  
  This is a reland of 16c852917d0e384fdba780ee6239ab40c3652a7a
  
  vkGetPhysicalDeviceProperties2 can be null on devices where
  VkPhysicalDeviceProperties.apiVersion < VK_API_VERSION_1_1.
  Even the vkEnumerateInstanceVersion returns VK_API_VERSION_1_1,
  it doesn't mean the actual device supports VK_API_VERSION_1_1.
  It only means the loader can handle vulkan instance creaion
  requests up to VK_API_VERSION_1_1, so we shouldn't assume the
  device also supports VK_API_VERSION_1_1 and fail vulkan
  instance creation if vkGetPhysicalDeviceProperties2 is null.
  Instead, we should proceed with instance creation, and only check
  vkGetPhysicalDeviceProperties2 is not null when the actual device
  supports VK_API_VERSION_1_1.
  
  Original change's description
  > On Fuchsia, it is possible that there is no vulkan driver and
  > vkCreateInstance() triggered VVLDebugUtilsMessenger.
  > "vkCreateInstance: Found no drivers" is a
  > VK_DEBUG_UTILS_MESSAGE_TYPE_GENERAL_BIT_EXT message. We should only
  > care about VK_DEBUG_UTILS_MESSAGE_TYPE_VALIDATION_BIT_EXT message
  > type. Remove VK_DEBUG_UTILS_MESSAGE_TYPE_GENERAL_BIT_EXT and
  > VK_DEBUG_UTILS_MESSAGE_TYPE_PERFORMANCE_BIT_EXT from the
  > VkDebugUtilsMessengerCreateInfoEXT.
  
  > Add code to print the VVL message in the log so we know what's wrong.
  
  > Add a condition to only assert when the VVL message severity is
  > VK_DEBUG_UTILS_MESSAGE_SEVERITY_ERROR_BIT_EXT.
  
  > Bug: angleproject:407116232
  > Change-Id: I1ffc4041368782641fc605366ff7cf03e43eb53f
  > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6435033
  > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
  > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
  
  Bug: angleproject:407116232
  Change-Id: I138933a235c4e638fac73559903cf77ecef9159a
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6444660
  Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
  Commit-Queue: Yuxin Hu <yuxinhu@google.com>
  Auto-Submit: Yuxin Hu <yuxinhu@google.com>
  

• Files

• SystemInfo.cpp
• SystemInfo.h
• SystemInfo_android.cpp
• SystemInfo_apple.mm
• SystemInfo_fuchsia.cpp
• SystemInfo_internal.h
• SystemInfo_ios.cpp
• SystemInfo_libpci.cpp
• SystemInfo_linux.cpp
• SystemInfo_macos.mm
• SystemInfo_unittest.cpp
• SystemInfo_vulkan.cpp
• SystemInfo_vulkan.h
• SystemInfo_win.cpp
• SystemInfo_x11.cpp

• Properties

• Git HTTP	https://git.kmx.io/kc3-lang/angle.git
  Git SSH	git@git.kmx.io:kc3-lang/angle.git
  Public access ?	public
  Description	A conformant OpenGL ES implementation for Windows, Mac, Linux, iOS and Android. Homepage Github
  Users
  Tags