kc3-lang/angle/src/libANGLE/renderer/SurfaceImpl.cpp

• Show log

  Commit

• Hash : 5fd368aa
  Author :
  Date : 2025-07-30T14:45:55
  

  Replace Surface::getWidth/Height() with getSize()
  
  Most places in the code use both `getWidth/Height()` methods at the same
  time. On some back-ends it is more optimal to have single method.
  For example, `WindowSurfaceWGL` first uses `GetClientRect()` Win32 API
  inside each method to then calculate width and hight in each method,
  causing repeated `GetClientRect()` call.
  
  The only place where only one of the methods may be used is from
  `SurfaceImpl::getUserSize()` when one of the parameters is `nullptr`,
  which is only possible from `QuerySurfaceAttrib()` function. This
  method is rewritten to use new `getSize()` method and then use whatever
  dimensions is requested by the caller. This may cause
  `QuerySurfaceAttrib()` inefficiency on some back-ends that get width and
  height of the surface differently (`SurfaceEGL` for example). In such
  cases `getUserSize()` is overridden to avoid returning a dimension
  which is not required.
  
  After this change all places in the code that previously used both
  `getWidth/Height()` methods (like `Surface::getAttachmentSize()`) will
  be more efficient. The `QuerySurfaceAttrib()`, on the other hand, will
  have slightly more overhead on back-ends where base
  `SurfaceImpl::getUserSize()` method is used, which only happens on
  back-ends with trivial `getSize()` implementation.
  
  Bug: angleproject:397848903
  Change-Id: I4a22701a1e62ee4e7d07e77cac5b388050d98e4d
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6802440
  Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
  Commit-Queue: Igor Nazarov <i.nazarov@samsung.com>
  

Download

• src/libANGLE/renderer/SurfaceImpl.cpp

• //
  // Copyright 2002 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  
  // SurfaceImpl.cpp: Implementation of Surface stub method class
  
  #include "libANGLE/renderer/SurfaceImpl.h"
  
  namespace rx
  {
  
  SurfaceImpl::SurfaceImpl(const egl::SurfaceState &state) : mState(state) {}
  
  SurfaceImpl::~SurfaceImpl() {}
  
  egl::Error SurfaceImpl::makeCurrent(const gl::Context *context)
  {
      return egl::NoError();
  }
  
  egl::Error SurfaceImpl::unMakeCurrent(const gl::Context *context)
  {
      return egl::NoError();
  }
  
  egl::Error SurfaceImpl::prepareSwap(const gl::Context *)
  {
      return angle::ResultToEGL(angle::Result::Continue);
  }
  
  egl::Error SurfaceImpl::swapWithDamage(const gl::Context *context,
                                         const EGLint *rects,
                                         EGLint n_rects,
                                         SurfaceSwapFeedback *feedback)
  {
      UNREACHABLE();
      return egl::Error(EGL_BAD_SURFACE, "swapWithDamage implementation missing.");
  }
  
  egl::Error SurfaceImpl::postSubBuffer(const gl::Context *context,
                                        EGLint x,
                                        EGLint y,
                                        EGLint width,
                                        EGLint height)
  {
      UNREACHABLE();
      return egl::Error(EGL_BAD_SURFACE, "getMscRate implementation missing.");
  }
  
  egl::Error SurfaceImpl::setPresentationTime(EGLnsecsANDROID time)
  {
      UNREACHABLE();
      return egl::Error(EGL_BAD_SURFACE, "setPresentationTime implementation missing.");
  }
  
  egl::Error SurfaceImpl::querySurfacePointerANGLE(EGLint attribute, void **value)
  {
      UNREACHABLE();
      return egl::Error(EGL_BAD_SURFACE, "querySurfacePointerANGLE implementation missing.");
  }
  
  egl::Error SurfaceImpl::getSyncValues(EGLuint64KHR *ust, EGLuint64KHR *msc, EGLuint64KHR *sbc)
  {
      UNREACHABLE();
      return egl::Error(EGL_BAD_SURFACE, "getSyncValues implementation missing.");
  }
  
  egl::Error SurfaceImpl::getMscRate(EGLint *numerator, EGLint *denominator)
  {
      UNREACHABLE();
      return egl::Error(EGL_BAD_SURFACE, "getMscRate implementation missing.");
  }
  
  void SurfaceImpl::setFixedWidth(EGLint width)
  {
      UNREACHABLE();
  }
  
  void SurfaceImpl::setFixedHeight(EGLint height)
  {
      UNREACHABLE();
  }
  
  void SurfaceImpl::setTimestampsEnabled(bool enabled)
  {
      UNREACHABLE();
  }
  
  const angle::Format *SurfaceImpl::getClientBufferTextureColorFormat() const
  {
      UNREACHABLE();
      return nullptr;
  }
  
  egl::SupportedCompositorTimings SurfaceImpl::getSupportedCompositorTimings() const
  {
      UNREACHABLE();
      return egl::SupportedCompositorTimings();
  }
  
  egl::Error SurfaceImpl::getCompositorTiming(EGLint numTimestamps,
                                              const EGLint *names,
                                              EGLnsecsANDROID *values) const
  {
      UNREACHABLE();
      return egl::Error(EGL_BAD_DISPLAY);
  }
  
  egl::Error SurfaceImpl::getNextFrameId(EGLuint64KHR *frameId) const
  {
      UNREACHABLE();
      return egl::Error(EGL_BAD_DISPLAY);
  }
  
  egl::SupportedTimestamps SurfaceImpl::getSupportedTimestamps() const
  {
      UNREACHABLE();
      return egl::SupportedTimestamps();
  }
  
  egl::Error SurfaceImpl::getFrameTimestamps(EGLuint64KHR frameId,
                                             EGLint numTimestamps,
                                             const EGLint *timestamps,
                                             EGLnsecsANDROID *values) const
  {
      UNREACHABLE();
      return egl::Error(EGL_BAD_DISPLAY);
  }
  
  angle::Result SurfaceImpl::ensureSizeResolved(const gl::Context *context)
  {
      return angle::Result::Continue;
  }
  
  egl::Error SurfaceImpl::getUserSize(const egl::Display *display,
                                      EGLint *width,
                                      EGLint *height) const
  {
      // Override getUserSize() if it is not the same as getSize() or if its usage is suboptimal.
      // In case of override use "final" for both methods when possible to prevent accidental bugs.
      const gl::Extents size = getSize();
      ASSERT(size.depth == 1);
      if (width != nullptr)
      {
          *width = size.width;
      }
      if (height != nullptr)
      {
          *height = size.height;
      }
      return egl::NoError();
  }
  
  EGLint SurfaceImpl::isPostSubBufferSupported() const
  {
      UNREACHABLE();
      return EGL_FALSE;
  }
  
  egl::Error SurfaceImpl::getBufferAge(const gl::Context *context, EGLint *age)
  {
      *age = 0;
      return egl::NoError();
  }
  
  egl::Error SurfaceImpl::setAutoRefreshEnabled(bool enabled)
  {
      return egl::Error(EGL_BAD_MATCH);
  }
  
  egl::Error SurfaceImpl::lockSurface(const egl::Display *display,
                                      EGLint usageHint,
                                      bool preservePixels,
                                      uint8_t **bufferPtrOut,
                                      EGLint *bufferPitchOut)
  {
      UNREACHABLE();
      return egl::Error(EGL_BAD_MATCH);
  }
  
  egl::Error SurfaceImpl::unlockSurface(const egl::Display *display, bool preservePixels)
  {
      UNREACHABLE();
      return egl::Error(EGL_BAD_MATCH);
  }
  
  EGLint SurfaceImpl::origin() const
  {
      return EGL_LOWER_LEFT_KHR;
  }
  
  egl::Error SurfaceImpl::setRenderBuffer(EGLint renderBuffer)
  {
      return egl::NoError();
  }
  
  egl::Error SurfaceImpl::getCompressionRate(const egl::Display *display,
                                             const gl::Context *context,
                                             EGLint *rate)
  {
      *rate = EGL_SURFACE_COMPRESSION_FIXED_RATE_NONE_EXT;
      return egl::NoError();
  }
  
  bool SurfaceImpl::supportsSingleRenderBuffer() const
  {
      return false;
  }
  
  }  // namespace rx
  

Download