kc3-lang/angle/src/libANGLE/renderer/null/BufferNULL.cpp

• Show log

  Commit

• Hash : 25390156
  Author :
  Date : 2025-08-21T00:13:19
  

  Suppress unsafe buffers on a file-by-file basis in src/ [1 of N]
  
  In this CL, we suppress many files but stop short of actually
  enabling the warning by not removing the line from the
  unsafe_buffers_paths.txt file. That will happen in a follow-on
  CL, along with resolving any stragglers missed here.
  
  This is mostly a manual change so as to familiarize myself with
  the kinds of issues faced by the Angle codebase when applying buffer
  safety warnings.
  
  -- Re-generate affected hashes.
  -- Clang-format applied to all changed files.
  -- Add a few missing .reserve() calls to vectors as noticed.
  -- Fix some mismatches between file names and header comments.
  -- Be more consistent with header comment format (blank lines and
     trailing //-only lines when a filename comment adjoins license
     boilerplate).
  
  Bug: b/436880895
  Change-Id: I3bde5cc2059acbe8345057289214f1a26f1c34aa
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6869022
  Reviewed-by: Geoff Lang <geofflang@chromium.org>
  Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
  Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
  

Download

• src/libANGLE/renderer/null/BufferNULL.cpp

• //
  // Copyright 2016 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  // BufferNULL.cpp:
  //    Implements the class methods for BufferNULL.
  //
  
  #ifdef UNSAFE_BUFFERS_BUILD
  #    pragma allow_unsafe_buffers
  #endif
  
  #include "libANGLE/renderer/null/BufferNULL.h"
  
  #include "common/debug.h"
  #include "common/utilities.h"
  #include "libANGLE/Context.h"
  #include "libANGLE/angletypes.h"
  #include "libANGLE/renderer/null/ContextNULL.h"
  
  namespace rx
  {
  
  BufferNULL::BufferNULL(const gl::BufferState &state, AllocationTrackerNULL *allocationTracker)
      : BufferImpl(state), mAllocationTracker(allocationTracker)
  {
      ASSERT(mAllocationTracker != nullptr);
  }
  
  BufferNULL::~BufferNULL()
  {
      bool memoryReleaseResult = mAllocationTracker->updateMemoryAllocation(mData.size(), 0);
      ASSERT(memoryReleaseResult);
  }
  
  angle::Result BufferNULL::setDataWithUsageFlags(const gl::Context *context,
                                                  gl::BufferBinding target,
                                                  GLeglClientBufferEXT clientBuffer,
                                                  const void *data,
                                                  size_t size,
                                                  gl::BufferUsage usage,
                                                  GLbitfield flags,
                                                  gl::BufferStorage bufferStorage,
                                                  BufferFeedback *feedback)
  {
      ANGLE_CHECK_GL_ALLOC(GetImplAs<ContextNULL>(context),
                           mAllocationTracker->updateMemoryAllocation(mData.size(), size));
  
      mData.resize(size, 0);
      if (size > 0 && data != nullptr)
      {
          memcpy(mData.data(), data, size);
      }
      return angle::Result::Continue;
  }
  
  angle::Result BufferNULL::setData(const gl::Context *context,
                                    gl::BufferBinding target,
                                    const void *data,
                                    size_t size,
                                    gl::BufferUsage usage,
                                    BufferFeedback *feedback)
  {
      ANGLE_CHECK_GL_ALLOC(GetImplAs<ContextNULL>(context),
                           mAllocationTracker->updateMemoryAllocation(mData.size(), size));
  
      mData.resize(size, 0);
      if (size > 0 && data != nullptr)
      {
          memcpy(mData.data(), data, size);
      }
      return angle::Result::Continue;
  }
  
  angle::Result BufferNULL::setSubData(const gl::Context *context,
                                       gl::BufferBinding target,
                                       const void *data,
                                       size_t size,
                                       size_t offset,
                                       BufferFeedback *feedback)
  {
      if (size > 0)
      {
          memcpy(mData.data() + offset, data, size);
      }
      return angle::Result::Continue;
  }
  
  angle::Result BufferNULL::copySubData(const gl::Context *context,
                                        BufferImpl *source,
                                        GLintptr sourceOffset,
                                        GLintptr destOffset,
                                        GLsizeiptr size,
                                        BufferFeedback *feedback)
  {
      BufferNULL *sourceNULL = GetAs<BufferNULL>(source);
      if (size > 0)
      {
          memcpy(mData.data() + destOffset, sourceNULL->mData.data() + sourceOffset, size);
      }
      return angle::Result::Continue;
  }
  
  angle::Result BufferNULL::map(const gl::Context *context,
                                GLenum access,
                                void **mapPtr,
                                BufferFeedback *feedback)
  {
      *mapPtr = mData.data();
      return angle::Result::Continue;
  }
  
  angle::Result BufferNULL::mapRange(const gl::Context *context,
                                     size_t offset,
                                     size_t length,
                                     GLbitfield access,
                                     void **mapPtr,
                                     BufferFeedback *feedback)
  {
      *mapPtr = mData.data() + offset;
      return angle::Result::Continue;
  }
  
  angle::Result BufferNULL::unmap(const gl::Context *context,
                                  GLboolean *result,
                                  BufferFeedback *feedback)
  {
      *result = GL_TRUE;
      return angle::Result::Continue;
  }
  
  angle::Result BufferNULL::getIndexRange(const gl::Context *context,
                                          gl::DrawElementsType type,
                                          size_t offset,
                                          size_t count,
                                          bool primitiveRestartEnabled,
                                          gl::IndexRange *outRange)
  {
      *outRange = gl::ComputeIndexRange(type, mData.data() + offset, count, primitiveRestartEnabled);
      return angle::Result::Continue;
  }
  
  uint8_t *BufferNULL::getDataPtr()
  {
      return mData.data();
  }
  
  const uint8_t *BufferNULL::getDataPtr() const
  {
      return mData.data();
  }
  
  }  // namespace rx
  

Download