kc3-lang/angle/src/libANGLE/renderer/null/FramebufferNULL.cpp

• Show log

  Commit

• Hash : 25390156
  Author :
  Date : 2025-08-21T00:13:19
  

  Suppress unsafe buffers on a file-by-file basis in src/ [1 of N]
  
  In this CL, we suppress many files but stop short of actually
  enabling the warning by not removing the line from the
  unsafe_buffers_paths.txt file. That will happen in a follow-on
  CL, along with resolving any stragglers missed here.
  
  This is mostly a manual change so as to familiarize myself with
  the kinds of issues faced by the Angle codebase when applying buffer
  safety warnings.
  
  -- Re-generate affected hashes.
  -- Clang-format applied to all changed files.
  -- Add a few missing .reserve() calls to vectors as noticed.
  -- Fix some mismatches between file names and header comments.
  -- Be more consistent with header comment format (blank lines and
     trailing //-only lines when a filename comment adjoins license
     boilerplate).
  
  Bug: b/436880895
  Change-Id: I3bde5cc2059acbe8345057289214f1a26f1c34aa
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6869022
  Reviewed-by: Geoff Lang <geofflang@chromium.org>
  Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
  Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
  

Download

• src/libANGLE/renderer/null/FramebufferNULL.cpp

• //
  // Copyright 2016 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  // FramebufferNULL.cpp:
  //    Implements the class methods for FramebufferNULL.
  //
  
  #ifdef UNSAFE_BUFFERS_BUILD
  #    pragma allow_unsafe_buffers
  #endif
  
  #include "libANGLE/renderer/null/FramebufferNULL.h"
  
  #include "common/debug.h"
  #include "libANGLE/Context.h"
  #include "libANGLE/formatutils.h"
  #include "libANGLE/renderer/null/BufferNULL.h"
  #include "libANGLE/renderer/null/ContextNULL.h"
  
  namespace rx
  {
  
  FramebufferNULL::FramebufferNULL(const gl::FramebufferState &state) : FramebufferImpl(state) {}
  
  FramebufferNULL::~FramebufferNULL() {}
  
  angle::Result FramebufferNULL::discard(const gl::Context *context,
                                         size_t count,
                                         const GLenum *attachments)
  {
      return angle::Result::Continue;
  }
  
  angle::Result FramebufferNULL::invalidate(const gl::Context *context,
                                            size_t count,
                                            const GLenum *attachments)
  {
      return angle::Result::Continue;
  }
  
  angle::Result FramebufferNULL::invalidateSub(const gl::Context *context,
                                               size_t count,
                                               const GLenum *attachments,
                                               const gl::Rectangle &area)
  {
      return angle::Result::Continue;
  }
  
  angle::Result FramebufferNULL::clear(const gl::Context *context, GLbitfield mask)
  {
      return angle::Result::Continue;
  }
  
  angle::Result FramebufferNULL::clearBufferfv(const gl::Context *context,
                                               GLenum buffer,
                                               GLint drawbuffer,
                                               const GLfloat *values)
  {
      return angle::Result::Continue;
  }
  
  angle::Result FramebufferNULL::clearBufferuiv(const gl::Context *context,
                                                GLenum buffer,
                                                GLint drawbuffer,
                                                const GLuint *values)
  {
      return angle::Result::Continue;
  }
  
  angle::Result FramebufferNULL::clearBufferiv(const gl::Context *context,
                                               GLenum buffer,
                                               GLint drawbuffer,
                                               const GLint *values)
  {
      return angle::Result::Continue;
  }
  
  angle::Result FramebufferNULL::clearBufferfi(const gl::Context *context,
                                               GLenum buffer,
                                               GLint drawbuffer,
                                               GLfloat depth,
                                               GLint stencil)
  {
      return angle::Result::Continue;
  }
  
  angle::Result FramebufferNULL::readPixels(const gl::Context *context,
                                            const gl::Rectangle &origArea,
                                            GLenum format,
                                            GLenum type,
                                            const gl::PixelPackState &pack,
                                            gl::Buffer *packBuffer,
                                            void *ptrOrOffset)
  {
      // Get the pointer to write to from the argument or the pack buffer
      GLubyte *pixels = nullptr;
      if (packBuffer != nullptr)
      {
          BufferNULL *packBufferGL = GetImplAs<BufferNULL>(packBuffer);
          pixels                   = reinterpret_cast<GLubyte *>(packBufferGL->getDataPtr());
          pixels += reinterpret_cast<intptr_t>(ptrOrOffset);
      }
      else
      {
          pixels = reinterpret_cast<GLubyte *>(ptrOrOffset);
      }
  
      // Clip read area to framebuffer.
      const gl::Extents fbSize = getState().getReadPixelsAttachment(format)->getSize();
      const gl::Rectangle fbRect(0, 0, fbSize.width, fbSize.height);
      gl::Rectangle area;
      if (!ClipRectangle(origArea, fbRect, &area))
      {
          // nothing to read
          return angle::Result::Continue;
      }
  
      // Compute size of unclipped rows and initial skip
      const gl::InternalFormat &glFormat = gl::GetInternalFormatInfo(format, type);
  
      ContextNULL *contextNull = GetImplAs<ContextNULL>(context);
  
      GLuint rowBytes = 0;
      ANGLE_CHECK_GL_MATH(contextNull, glFormat.computeRowPitch(type, origArea.width, pack.alignment,
                                                                pack.rowLength, &rowBytes));
  
      GLuint skipBytes = 0;
      ANGLE_CHECK_GL_MATH(contextNull,
                          glFormat.computeSkipBytes(type, rowBytes, 0, pack, false, &skipBytes));
      pixels += skipBytes;
  
      // Skip OOB region up to first in bounds pixel
      int leftClip = area.x - origArea.x;
      int topClip  = area.y - origArea.y;
      pixels += leftClip * glFormat.pixelBytes + topClip * rowBytes;
  
      // Write the in-bounds readpixels data with non-zero values
      for (GLint y = area.y; y < area.y + area.height; ++y)
      {
          memset(pixels, 42, glFormat.pixelBytes * area.width);
          pixels += rowBytes;
      }
  
      return angle::Result::Continue;
  }
  
  angle::Result FramebufferNULL::blit(const gl::Context *context,
                                      const gl::Rectangle &sourceArea,
                                      const gl::Rectangle &destArea,
                                      GLbitfield mask,
                                      GLenum filter)
  {
      return angle::Result::Continue;
  }
  
  gl::FramebufferStatus FramebufferNULL::checkStatus(const gl::Context *context) const
  {
      return gl::FramebufferStatus::Complete();
  }
  
  angle::Result FramebufferNULL::syncState(const gl::Context *context,
                                           GLenum binding,
                                           const gl::Framebuffer::DirtyBits &dirtyBits,
                                           gl::Command command)
  {
      return angle::Result::Continue;
  }
  
  angle::Result FramebufferNULL::getSamplePosition(const gl::Context *context,
                                                   size_t index,
                                                   GLfloat *xy) const
  {
      return angle::Result::Continue;
  }
  
  }  // namespace rx
  

Download