kc3-lang/angle/src/libANGLE/renderer/null/SurfaceNULL.cpp

• Show log

  Commit

• Hash : 5fd368aa
  Author :
  Date : 2025-07-30T14:45:55
  

  Replace Surface::getWidth/Height() with getSize()
  
  Most places in the code use both `getWidth/Height()` methods at the same
  time. On some back-ends it is more optimal to have single method.
  For example, `WindowSurfaceWGL` first uses `GetClientRect()` Win32 API
  inside each method to then calculate width and hight in each method,
  causing repeated `GetClientRect()` call.
  
  The only place where only one of the methods may be used is from
  `SurfaceImpl::getUserSize()` when one of the parameters is `nullptr`,
  which is only possible from `QuerySurfaceAttrib()` function. This
  method is rewritten to use new `getSize()` method and then use whatever
  dimensions is requested by the caller. This may cause
  `QuerySurfaceAttrib()` inefficiency on some back-ends that get width and
  height of the surface differently (`SurfaceEGL` for example). In such
  cases `getUserSize()` is overridden to avoid returning a dimension
  which is not required.
  
  After this change all places in the code that previously used both
  `getWidth/Height()` methods (like `Surface::getAttachmentSize()`) will
  be more efficient. The `QuerySurfaceAttrib()`, on the other hand, will
  have slightly more overhead on back-ends where base
  `SurfaceImpl::getUserSize()` method is used, which only happens on
  back-ends with trivial `getSize()` implementation.
  
  Bug: angleproject:397848903
  Change-Id: I4a22701a1e62ee4e7d07e77cac5b388050d98e4d
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6802440
  Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
  Commit-Queue: Igor Nazarov <i.nazarov@samsung.com>
  

Download

• src/libANGLE/renderer/null/SurfaceNULL.cpp

• //
  // Copyright 2016 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  // SurfaceNULL.cpp:
  //    Implements the class methods for SurfaceNULL.
  //
  
  #include "libANGLE/renderer/null/SurfaceNULL.h"
  
  #include "common/debug.h"
  
  #include "libANGLE/renderer/null/FramebufferNULL.h"
  
  namespace rx
  {
  
  SurfaceNULL::SurfaceNULL(const egl::SurfaceState &surfaceState) : SurfaceImpl(surfaceState) {}
  
  SurfaceNULL::~SurfaceNULL() {}
  
  egl::Error SurfaceNULL::initialize(const egl::Display *display)
  {
      return egl::NoError();
  }
  
  egl::Error SurfaceNULL::swap(const gl::Context *context, SurfaceSwapFeedback *feedback)
  {
      return egl::NoError();
  }
  
  egl::Error SurfaceNULL::postSubBuffer(const gl::Context *context,
                                        EGLint x,
                                        EGLint y,
                                        EGLint width,
                                        EGLint height)
  {
      return egl::NoError();
  }
  
  egl::Error SurfaceNULL::querySurfacePointerANGLE(EGLint attribute, void **value)
  {
      UNREACHABLE();
      return egl::NoError();
  }
  
  egl::Error SurfaceNULL::bindTexImage(const gl::Context *context,
                                       gl::Texture *texture,
                                       EGLint buffer)
  {
      return egl::NoError();
  }
  
  egl::Error SurfaceNULL::releaseTexImage(const gl::Context *context, EGLint buffer)
  {
      return egl::NoError();
  }
  
  egl::Error SurfaceNULL::getSyncValues(EGLuint64KHR *ust, EGLuint64KHR *msc, EGLuint64KHR *sbc)
  {
      UNIMPLEMENTED();
      return egl::Error(EGL_BAD_ACCESS);
  }
  
  egl::Error SurfaceNULL::getMscRate(EGLint *numerator, EGLint *denominator)
  {
      UNIMPLEMENTED();
      return egl::Error(EGL_BAD_ACCESS);
  }
  
  void SurfaceNULL::setSwapInterval(const egl::Display *display, EGLint interval) {}
  
  gl::Extents SurfaceNULL::getSize() const
  {
      // TODO(geofflang): Read from an actual window?
      return gl::Extents(100, 100, 1);
  }
  
  EGLint SurfaceNULL::isPostSubBufferSupported() const
  {
      return EGL_TRUE;
  }
  
  EGLint SurfaceNULL::getSwapBehavior() const
  {
      return EGL_BUFFER_PRESERVED;
  }
  
  angle::Result SurfaceNULL::initializeContents(const gl::Context *context,
                                                GLenum binding,
                                                const gl::ImageIndex &imageIndex)
  {
      return angle::Result::Continue;
  }
  
  egl::Error SurfaceNULL::attachToFramebuffer(const gl::Context *context,
                                              gl::Framebuffer *framebuffer)
  {
      return egl::NoError();
  }
  
  egl::Error SurfaceNULL::detachFromFramebuffer(const gl::Context *context,
                                                gl::Framebuffer *framebuffer)
  {
      return egl::NoError();
  }
  
  }  // namespace rx
  

Download