kc3-lang/angle/src/libANGLE/renderer/null/SurfaceNULL.h

• Show log

  Commit

• Hash : 5fd368aa
  Author :
  Date : 2025-07-30T14:45:55
  

  Replace Surface::getWidth/Height() with getSize()
  
  Most places in the code use both `getWidth/Height()` methods at the same
  time. On some back-ends it is more optimal to have single method.
  For example, `WindowSurfaceWGL` first uses `GetClientRect()` Win32 API
  inside each method to then calculate width and hight in each method,
  causing repeated `GetClientRect()` call.
  
  The only place where only one of the methods may be used is from
  `SurfaceImpl::getUserSize()` when one of the parameters is `nullptr`,
  which is only possible from `QuerySurfaceAttrib()` function. This
  method is rewritten to use new `getSize()` method and then use whatever
  dimensions is requested by the caller. This may cause
  `QuerySurfaceAttrib()` inefficiency on some back-ends that get width and
  height of the surface differently (`SurfaceEGL` for example). In such
  cases `getUserSize()` is overridden to avoid returning a dimension
  which is not required.
  
  After this change all places in the code that previously used both
  `getWidth/Height()` methods (like `Surface::getAttachmentSize()`) will
  be more efficient. The `QuerySurfaceAttrib()`, on the other hand, will
  have slightly more overhead on back-ends where base
  `SurfaceImpl::getUserSize()` method is used, which only happens on
  back-ends with trivial `getSize()` implementation.
  
  Bug: angleproject:397848903
  Change-Id: I4a22701a1e62ee4e7d07e77cac5b388050d98e4d
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6802440
  Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
  Commit-Queue: Igor Nazarov <i.nazarov@samsung.com>
  

Download

• src/libANGLE/renderer/null/SurfaceNULL.h

• //
  // Copyright 2016 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  // SurfaceNULL.h:
  //    Defines the class interface for SurfaceNULL, implementing SurfaceImpl.
  //
  
  #ifndef LIBANGLE_RENDERER_NULL_SURFACENULL_H_
  #define LIBANGLE_RENDERER_NULL_SURFACENULL_H_
  
  #include "libANGLE/renderer/SurfaceImpl.h"
  
  namespace rx
  {
  
  class SurfaceNULL : public SurfaceImpl
  {
    public:
      SurfaceNULL(const egl::SurfaceState &surfaceState);
      ~SurfaceNULL() override;
  
      egl::Error initialize(const egl::Display *display) override;
      egl::Error swap(const gl::Context *context, SurfaceSwapFeedback *feedback) override;
      egl::Error postSubBuffer(const gl::Context *context,
                               EGLint x,
                               EGLint y,
                               EGLint width,
                               EGLint height) override;
      egl::Error querySurfacePointerANGLE(EGLint attribute, void **value) override;
      egl::Error bindTexImage(const gl::Context *context,
                              gl::Texture *texture,
                              EGLint buffer) override;
      egl::Error releaseTexImage(const gl::Context *context, EGLint buffer) override;
      egl::Error getSyncValues(EGLuint64KHR *ust, EGLuint64KHR *msc, EGLuint64KHR *sbc) override;
      egl::Error getMscRate(EGLint *numerator, EGLint *denominator) override;
      void setSwapInterval(const egl::Display *display, EGLint interval) override;
  
      // size can change with client window resizing
      gl::Extents getSize() const override;
  
      EGLint isPostSubBufferSupported() const override;
      EGLint getSwapBehavior() const override;
  
      angle::Result initializeContents(const gl::Context *context,
                                       GLenum binding,
                                       const gl::ImageIndex &imageIndex) override;
  
      egl::Error attachToFramebuffer(const gl::Context *context,
                                     gl::Framebuffer *framebuffer) override;
      egl::Error detachFromFramebuffer(const gl::Context *context,
                                       gl::Framebuffer *framebuffer) override;
  };
  
  }  // namespace rx
  
  #endif  // LIBANGLE_RENDERER_NULL_SURFACENULL_H_
  

Download