Hash :
5fd368aa
Author :
Date :
2025-07-30T14:45:55
Replace Surface::getWidth/Height() with getSize() Most places in the code use both `getWidth/Height()` methods at the same time. On some back-ends it is more optimal to have single method. For example, `WindowSurfaceWGL` first uses `GetClientRect()` Win32 API inside each method to then calculate width and hight in each method, causing repeated `GetClientRect()` call. The only place where only one of the methods may be used is from `SurfaceImpl::getUserSize()` when one of the parameters is `nullptr`, which is only possible from `QuerySurfaceAttrib()` function. This method is rewritten to use new `getSize()` method and then use whatever dimensions is requested by the caller. This may cause `QuerySurfaceAttrib()` inefficiency on some back-ends that get width and height of the surface differently (`SurfaceEGL` for example). In such cases `getUserSize()` is overridden to avoid returning a dimension which is not required. After this change all places in the code that previously used both `getWidth/Height()` methods (like `Surface::getAttachmentSize()`) will be more efficient. The `QuerySurfaceAttrib()`, on the other hand, will have slightly more overhead on back-ends where base `SurfaceImpl::getUserSize()` method is used, which only happens on back-ends with trivial `getSize()` implementation. Bug: angleproject:397848903 Change-Id: I4a22701a1e62ee4e7d07e77cac5b388050d98e4d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6802440 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Igor Nazarov <i.nazarov@samsung.com>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163
//
// Copyright 2024 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// SurfaceWgpu.h:
// Defines the class interface for SurfaceWgpu, implementing SurfaceImpl.
//
#ifndef LIBANGLE_RENDERER_WGPU_SURFACEWGPU_H_
#define LIBANGLE_RENDERER_WGPU_SURFACEWGPU_H_
#include "libANGLE/renderer/SurfaceImpl.h"
#include "libANGLE/renderer/wgpu/RenderTargetWgpu.h"
#include "libANGLE/renderer/wgpu/wgpu_helpers.h"
#include <webgpu/webgpu.h>
namespace rx
{
class SurfaceWgpu : public SurfaceImpl
{
public:
SurfaceWgpu(const egl::SurfaceState &surfaceState);
~SurfaceWgpu() override;
protected:
struct AttachmentImage
{
webgpu::ImageHelper texture;
RenderTargetWgpu renderTarget;
};
angle::Result createDepthStencilAttachment(const egl::Display *display,
uint32_t width,
uint32_t height,
const webgpu::Format &webgpuFormat,
webgpu::DeviceHandle device,
AttachmentImage *outDepthStencilAttachment);
};
class OffscreenSurfaceWgpu : public SurfaceWgpu
{
public:
OffscreenSurfaceWgpu(const egl::SurfaceState &surfaceState,
EGLenum clientBufferType,
EGLClientBuffer clientBuffer);
~OffscreenSurfaceWgpu() override;
egl::Error initialize(const egl::Display *display) override;
egl::Error swap(const gl::Context *context, SurfaceSwapFeedback *feedback) override;
egl::Error bindTexImage(const gl::Context *context,
gl::Texture *texture,
EGLint buffer) override;
egl::Error releaseTexImage(const gl::Context *context, EGLint buffer) override;
void setSwapInterval(const egl::Display *display, EGLint interval) override;
// size can change with client window resizing
gl::Extents getSize() const override;
EGLint getSwapBehavior() const override;
angle::Result initializeContents(const gl::Context *context,
GLenum binding,
const gl::ImageIndex &imageIndex) override;
egl::Error attachToFramebuffer(const gl::Context *context,
gl::Framebuffer *framebuffer) override;
egl::Error detachFromFramebuffer(const gl::Context *context,
gl::Framebuffer *framebuffer) override;
angle::Result getAttachmentRenderTarget(const gl::Context *context,
GLenum binding,
const gl::ImageIndex &imageIndex,
GLsizei samples,
FramebufferAttachmentRenderTarget **rtOut) override;
private:
angle::Result initializeImpl(const egl::Display *display);
EGLint mWidth;
EGLint mHeight;
EGLenum mClientBufferType = EGL_NONE;
EGLClientBuffer mClientBuffer = nullptr;
AttachmentImage mColorAttachment;
AttachmentImage mDepthStencilAttachment;
};
class WindowSurfaceWgpu : public SurfaceWgpu
{
public:
WindowSurfaceWgpu(const egl::SurfaceState &surfaceState, EGLNativeWindowType window);
~WindowSurfaceWgpu() override;
egl::Error initialize(const egl::Display *display) override;
void destroy(const egl::Display *display) override;
egl::Error swap(const gl::Context *context, SurfaceSwapFeedback *feedback) override;
egl::Error bindTexImage(const gl::Context *context,
gl::Texture *texture,
EGLint buffer) override;
egl::Error releaseTexImage(const gl::Context *context, EGLint buffer) override;
void setSwapInterval(const egl::Display *display, EGLint interval) override;
// size can change with client window resizing
gl::Extents getSize() const override;
EGLint getSwapBehavior() const override;
angle::Result initializeContents(const gl::Context *context,
GLenum binding,
const gl::ImageIndex &imageIndex) override;
egl::Error attachToFramebuffer(const gl::Context *context,
gl::Framebuffer *framebuffer) override;
egl::Error detachFromFramebuffer(const gl::Context *context,
gl::Framebuffer *framebuffer) override;
angle::Result getAttachmentRenderTarget(const gl::Context *context,
GLenum binding,
const gl::ImageIndex &imageIndex,
GLsizei samples,
FramebufferAttachmentRenderTarget **rtOut) override;
protected:
EGLNativeWindowType getNativeWindow() const { return mNativeWindow; }
private:
angle::Result initializeImpl(const egl::Display *display);
angle::Result swapImpl(const gl::Context *context);
angle::Result configureSurface(const egl::Display *display, const gl::Extents &size);
angle::Result updateCurrentTexture(const egl::Display *display);
virtual angle::Result createWgpuSurface(const egl::Display *display,
webgpu::SurfaceHandle *outSurface) = 0;
virtual angle::Result getCurrentWindowSize(const egl::Display *display,
gl::Extents *outSize) = 0;
EGLNativeWindowType mNativeWindow;
webgpu::SurfaceHandle mSurface;
const webgpu::Format *mSurfaceTextureFormat = nullptr;
WGPUTextureUsage mSurfaceTextureUsage;
WGPUPresentMode mPresentMode;
const webgpu::Format *mDepthStencilFormat = nullptr;
gl::Extents mCurrentSurfaceSize;
AttachmentImage mColorAttachment;
AttachmentImage mDepthStencilAttachment;
};
WindowSurfaceWgpu *CreateWgpuWindowSurface(const egl::SurfaceState &surfaceState,
EGLNativeWindowType window);
} // namespace rx
#endif // LIBANGLE_RENDERER_WGPU_SURFACEWGPU_H_