kc3-lang/angle/src/libANGLE/renderer/vulkan/ImageVk.h

• Show log

  Commit

• Hash : a0d048a4
  Author :
  Date : 2020-08-27T12:03:02
  

  Vulkan: Fool-proof usage of GL and VK level indices
  
  Using boxed types, this change allows the compiler to catch errors when
  a level index in one space (e.g. GL) is mistakenly used in another space
  (e.g. VK).
  
  This change uncovered a number of bugs due to such mistakes which are
  fixed.
  
  Mistakes are still possible when the index is explicitly extracted, for
  example to be given to a Vulkan command, or when it's created, for
  example when retrieved from gl::ImageIndex::getLevelIndex.  Future work
  can include using gl::LevelIndex in gl::ImageIndex directly to alleviate
  the latter at least.
  
  Bug: angleproject:4880
  Change-Id: I6427c68c3bc096f771402f51c8554d8171758aa9
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2380232
  Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
  Reviewed-by: Tim Van Patten <timvp@google.com>
  Reviewed-by: Jamie Madill <jmadill@chromium.org>
  Reviewed-by: Charlie Lao <cclao@google.com>
  

Download

• src/libANGLE/renderer/vulkan/ImageVk.h

• //
  // Copyright 2016 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  // ImageVk.h:
  //    Defines the class interface for ImageVk, implementing ImageImpl.
  //
  
  #ifndef LIBANGLE_RENDERER_VULKAN_IMAGEVK_H_
  #define LIBANGLE_RENDERER_VULKAN_IMAGEVK_H_
  
  #include "libANGLE/renderer/ImageImpl.h"
  #include "libANGLE/renderer/vulkan/vk_helpers.h"
  
  namespace rx
  {
  
  class ExternalImageSiblingVk : public ExternalImageSiblingImpl
  {
    public:
      ExternalImageSiblingVk() {}
      ~ExternalImageSiblingVk() override {}
  
      virtual vk::ImageHelper *getImage() const = 0;
  
      virtual void release(RendererVk *renderer) = 0;
  };
  
  class ImageVk : public ImageImpl
  {
    public:
      ImageVk(const egl::ImageState &state, const gl::Context *context);
      ~ImageVk() override;
      void onDestroy(const egl::Display *display) override;
  
      egl::Error initialize(const egl::Display *display) override;
  
      angle::Result orphan(const gl::Context *context, egl::ImageSibling *sibling) override;
  
      vk::ImageHelper *getImage() const { return mImage; }
      gl::TextureType getImageTextureType() const { return mImageTextureType; }
      gl::LevelIndex getImageLevel() const { return mImageLevel; }
      uint32_t getImageLayer() const { return mImageLayer; }
  
    private:
      gl::TextureType mImageTextureType;
      gl::LevelIndex mImageLevel;
      uint32_t mImageLayer;
  
      bool mOwnsImage;
      vk::ImageHelper *mImage;
  
      std::vector<vk::Shared<vk::Fence>> mImageLastUseFences;
  
      const gl::Context *mContext;
  };
  
  }  // namespace rx
  
  #endif  // LIBANGLE_RENDERER_VULKAN_IMAGEVK_H_
  

Download