kc3-lang/angle/src/tests/gl_tests/SRGBFramebufferTest.cpp

• Show log

  Commit

• Hash : f28d63e9
  Author :
  Date : 2021-03-24T11:14:24
  

  Vulkan: Enable glBlitFramebuffer for EXT_sRGB_write_control
  
  Implements support for the glBlitFramebuffer edge case in the
  EXT_sRGB_write_control spec, and fully exposes this extension.
  
  Bug: angleproject:5075
  Test: SRGBFramebufferTest*.*Vulkan*
  Change-Id: I05f044abbc5cb272825d1fc4b9028217f18e63c2
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2785641
  Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
  Reviewed-by: Jamie Madill <jmadill@chromium.org>
  Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
  

Download

• src/tests/gl_tests/SRGBFramebufferTest.cpp

• //
  // Copyright 2016 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  
  // SRGBFramebufferTest.cpp: Tests of sRGB framebuffer functionality.
  
  #include "test_utils/ANGLETest.h"
  #include "test_utils/gl_raii.h"
  
  namespace
  {
  constexpr angle::GLColor linearColor(64, 127, 191, 255);
  constexpr angle::GLColor srgbColor(13, 54, 133, 255);
  }  // namespace
  
  namespace angle
  {
  
  class SRGBFramebufferTest : public ANGLETest
  {
    protected:
      SRGBFramebufferTest()
      {
          setWindowWidth(128);
          setWindowHeight(128);
          setConfigRedBits(8);
          setConfigGreenBits(8);
          setConfigBlueBits(8);
          setConfigAlphaBits(8);
      }
  
      void testSetUp() override
      {
          mProgram = CompileProgram(essl1_shaders::vs::Simple(), essl1_shaders::fs::UniformColor());
          ASSERT_NE(0u, mProgram);
  
          mColorLocation = glGetUniformLocation(mProgram, essl1_shaders::ColorUniform());
          ASSERT_NE(-1, mColorLocation);
      }
  
      void testTearDown() override { glDeleteProgram(mProgram); }
  
      GLuint mProgram      = 0;
      GLint mColorLocation = -1;
  };
  
  class SRGBFramebufferTestES3 : public SRGBFramebufferTest
  {};
  
  // Test basic validation of GL_EXT_sRGB_write_control
  TEST_P(SRGBFramebufferTest, Validation)
  {
      GLenum expectedError =
          IsGLExtensionEnabled("GL_EXT_sRGB_write_control") ? GL_NO_ERROR : GL_INVALID_ENUM;
  
      GLboolean value = GL_FALSE;
      glEnable(GL_FRAMEBUFFER_SRGB_EXT);
      EXPECT_GL_ERROR(expectedError);
  
      glGetBooleanv(GL_FRAMEBUFFER_SRGB_EXT, &value);
      EXPECT_GL_ERROR(expectedError);
      if (expectedError == GL_NO_ERROR)
      {
          EXPECT_GL_TRUE(value);
      }
  
      glDisable(GL_FRAMEBUFFER_SRGB_EXT);
      EXPECT_GL_ERROR(expectedError);
  
      glGetBooleanv(GL_FRAMEBUFFER_SRGB_EXT, &value);
      EXPECT_GL_ERROR(expectedError);
      if (expectedError == GL_NO_ERROR)
      {
          EXPECT_GL_FALSE(value);
      }
  }
  
  // Test basic functionality of GL_EXT_sRGB_write_control
  TEST_P(SRGBFramebufferTest, BasicUsage)
  {
      if (!IsGLExtensionEnabled("GL_EXT_sRGB_write_control") ||
          (!IsGLExtensionEnabled("GL_EXT_sRGB") && getClientMajorVersion() < 3))
      {
          std::cout
              << "Test skipped because GL_EXT_sRGB_write_control and GL_EXT_sRGB are not available."
              << std::endl;
          return;
      }
  
      GLTexture texture;
      glBindTexture(GL_TEXTURE_2D, texture.get());
      glTexImage2D(GL_TEXTURE_2D, 0, GL_SRGB_ALPHA_EXT, 1, 1, 0, GL_SRGB_ALPHA_EXT, GL_UNSIGNED_BYTE,
                   nullptr);
  
      GLFramebuffer framebuffer;
      glBindFramebuffer(GL_FRAMEBUFFER, framebuffer.get());
      glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, texture.get(), 0);
  
      glUseProgram(mProgram);
      glUniform4fv(mColorLocation, 1, srgbColor.toNormalizedVector().data());
  
      glEnable(GL_FRAMEBUFFER_SRGB_EXT);
      drawQuad(mProgram, essl1_shaders::PositionAttrib(), 0.5f);
      EXPECT_PIXEL_COLOR_NEAR(0, 0, linearColor, 1.0);
  
      glDisable(GL_FRAMEBUFFER_SRGB_EXT);
      drawQuad(mProgram, essl1_shaders::PositionAttrib(), 0.5f);
      EXPECT_PIXEL_COLOR_NEAR(0, 0, srgbColor, 1.0);
  }
  
  // Test that GL_EXT_sRGB_write_control state applies to all framebuffers if multiple are used
  // 1. disable srgb
  // 2. draw to both framebuffers
  // 3. enable srgb
  // 4. draw to both framebuffers
  TEST_P(SRGBFramebufferTest, MultipleFramebuffers)
  {
      if (!IsGLExtensionEnabled("GL_EXT_sRGB_write_control") ||
          (!IsGLExtensionEnabled("GL_EXT_sRGB") && getClientMajorVersion() < 3))
      {
          std::cout
              << "Test skipped because GL_EXT_sRGB_write_control and GL_EXT_sRGB are not available."
              << std::endl;
          return;
      }
  
      // NVIDIA failures on older drivers
      // http://anglebug.com/5641
      ANGLE_SKIP_TEST_IF(IsNVIDIA() && IsOpenGLES());
  
      GLTexture texture;
      glBindTexture(GL_TEXTURE_2D, texture.get());
      glTexImage2D(GL_TEXTURE_2D, 0, GL_SRGB_ALPHA_EXT, 1, 1, 0, GL_SRGB_ALPHA_EXT, GL_UNSIGNED_BYTE,
                   nullptr);
  
      GLFramebuffer framebuffer1;
      glBindFramebuffer(GL_FRAMEBUFFER, framebuffer1.get());
      glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, texture.get(), 0);
  
      glUseProgram(mProgram);
      glUniform4fv(mColorLocation, 1, srgbColor.toNormalizedVector().data());
  
      glDisable(GL_FRAMEBUFFER_SRGB_EXT);
      drawQuad(mProgram, essl1_shaders::PositionAttrib(), 0.5f);
      EXPECT_PIXEL_COLOR_NEAR(0, 0, srgbColor, 1.0);
  
      GLFramebuffer framebuffer2;
      glBindFramebuffer(GL_FRAMEBUFFER, framebuffer2.get());
      glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, texture.get(), 0);
      drawQuad(mProgram, essl1_shaders::PositionAttrib(), 0.5f);
      EXPECT_PIXEL_COLOR_NEAR(0, 0, srgbColor, 1.0);
  
      glEnable(GL_FRAMEBUFFER_SRGB_EXT);
      glBindFramebuffer(GL_FRAMEBUFFER, framebuffer1.get());
      drawQuad(mProgram, essl1_shaders::PositionAttrib(), 0.5f);
      EXPECT_PIXEL_COLOR_NEAR(0, 0, linearColor, 1.0);
  
      glBindFramebuffer(GL_FRAMEBUFFER, framebuffer2.get());
      drawQuad(mProgram, essl1_shaders::PositionAttrib(), 0.5f);
      EXPECT_PIXEL_COLOR_NEAR(0, 0, linearColor, 1.0);
  }
  
  // Test that we behave correctly when we toggle FRAMEBUFFER_SRGB_EXT on a framebuffer that has an
  // attachment in linear colorspace
  TEST_P(SRGBFramebufferTest, NegativeAlreadyLinear)
  {
      if (!IsGLExtensionEnabled("GL_EXT_sRGB_write_control") ||
          (!IsGLExtensionEnabled("GL_EXT_sRGB") && getClientMajorVersion() < 3))
      {
          std::cout
              << "Test skipped because GL_EXT_sRGB_write_control and GL_EXT_sRGB are not available."
              << std::endl;
          return;
      }
  
      GLTexture texture;
      glBindTexture(GL_TEXTURE_2D, texture.get());
      glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA, 1, 1, 0, GL_RGBA, GL_UNSIGNED_BYTE, nullptr);
  
      GLFramebuffer framebuffer;
      glBindFramebuffer(GL_FRAMEBUFFER, framebuffer.get());
      glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, texture.get(), 0);
  
      glUseProgram(mProgram);
      glUniform4fv(mColorLocation, 1, linearColor.toNormalizedVector().data());
  
      glEnable(GL_FRAMEBUFFER_SRGB_EXT);
      drawQuad(mProgram, essl1_shaders::PositionAttrib(), 0.5f);
      EXPECT_PIXEL_COLOR_NEAR(0, 0, linearColor, 1.0);
  
      glDisable(GL_FRAMEBUFFER_SRGB_EXT);
      drawQuad(mProgram, essl1_shaders::PositionAttrib(), 0.5f);
      EXPECT_PIXEL_COLOR_NEAR(0, 0, linearColor, 1.0);
  }
  
  // Test that lifetimes of internal resources are tracked correctly by deleting a texture and then
  // attempting to use it. This is expected to produce a non-fatal error.
  TEST_P(SRGBFramebufferTest, NegativeLifetimeTracking)
  {
      if (!IsGLExtensionEnabled("GL_EXT_sRGB_write_control") ||
          (!IsGLExtensionEnabled("GL_EXT_sRGB") && getClientMajorVersion() < 3))
      {
          std::cout
              << "Test skipped because GL_EXT_sRGB_write_control and GL_EXT_sRGB are not available."
              << std::endl;
          return;
      }
  
      // NVIDIA failures
      // http://anglebug.com/5641
      ANGLE_SKIP_TEST_IF(IsNVIDIA() && IsOpenGLES());
  
      GLTexture texture;
      glBindTexture(GL_TEXTURE_2D, texture.get());
      glTexImage2D(GL_TEXTURE_2D, 0, GL_SRGB_ALPHA_EXT, 1, 1, 0, GL_SRGB_ALPHA_EXT, GL_UNSIGNED_BYTE,
                   nullptr);
  
      GLFramebuffer framebuffer;
      glBindFramebuffer(GL_FRAMEBUFFER, framebuffer.get());
      glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, texture.get(), 0);
  
      glUseProgram(mProgram);
      glUniform4fv(mColorLocation, 1, srgbColor.toNormalizedVector().data());
  
      glDisable(GL_FRAMEBUFFER_SRGB_EXT);
      drawQuad(mProgram, essl1_shaders::PositionAttrib(), 0.5f);
      EXPECT_PIXEL_COLOR_NEAR(0, 0, srgbColor, 1.0);
  
      // Delete the texture
      glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, 0, 0);
      texture.reset();
  
      drawQuad(mProgram, essl1_shaders::PositionAttrib(), 0.5f);
      EXPECT_GL_ERROR(GL_INVALID_FRAMEBUFFER_OPERATION);
  
      GLColor throwaway_color;
      glReadPixels(0, 0, 1, 1, GL_RGBA, GL_UNSIGNED_BYTE, &throwaway_color);
      EXPECT_GL_ERROR(GL_INVALID_FRAMEBUFFER_OPERATION);
  }
  
  // Test that glBlitFramebuffer correctly converts colorspaces
  TEST_P(SRGBFramebufferTestES3, BlitFramebuffer)
  {
      // http://anglebug.com/5790
      ANGLE_SKIP_TEST_IF(!IsVulkan());
  
      if (!IsGLExtensionEnabled("GL_EXT_sRGB_write_control") ||
          (!IsGLExtensionEnabled("GL_EXT_sRGB") && getClientMajorVersion() < 3))
      {
          std::cout
              << "Test skipped because GL_EXT_sRGB_write_control and GL_EXT_sRGB are not available."
              << std::endl;
          return;
      }
  
      GLTexture dstTexture;
      glBindTexture(GL_TEXTURE_2D, dstTexture.get());
      glTexImage2D(GL_TEXTURE_2D, 0, GL_SRGB_ALPHA_EXT, 1, 1, 0, GL_SRGB_ALPHA_EXT, GL_UNSIGNED_BYTE,
                   nullptr);
      GLFramebuffer dstFramebuffer;
      glBindFramebuffer(GL_FRAMEBUFFER, dstFramebuffer.get());
      glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, dstTexture.get(),
                             0);
  
      GLTexture srcTexture;
      glBindTexture(GL_TEXTURE_2D, srcTexture.get());
      glTexImage2D(GL_TEXTURE_2D, 0, GL_SRGB_ALPHA_EXT, 1, 1, 0, GL_SRGB_ALPHA_EXT, GL_UNSIGNED_BYTE,
                   nullptr);
  
      GLFramebuffer srcFramebuffer;
      glBindFramebuffer(GL_FRAMEBUFFER, srcFramebuffer.get());
      glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, srcTexture.get(),
                             0);
  
      glUseProgram(mProgram);
      glUniform4fv(mColorLocation, 1, srgbColor.toNormalizedVector().data());
  
      // Draw onto the framebuffer normally
      glEnable(GL_FRAMEBUFFER_SRGB_EXT);
      drawQuad(mProgram, essl1_shaders::PositionAttrib(), 0.5f);
      EXPECT_PIXEL_COLOR_NEAR(0, 0, linearColor, 1.0);
  
      // Blit the framebuffer normally
      glEnable(GL_FRAMEBUFFER_SRGB_EXT);
      glBindFramebuffer(GL_DRAW_FRAMEBUFFER, dstFramebuffer);
      glBindFramebuffer(GL_READ_FRAMEBUFFER, srcFramebuffer);
      glBlitFramebuffer(0, 0, 1, 1, 0, 0, 1, 1, GL_COLOR_BUFFER_BIT, GL_NEAREST);
  
      glBindFramebuffer(GL_FRAMEBUFFER, dstFramebuffer);
      EXPECT_PIXEL_COLOR_NEAR(0, 0, linearColor, 1.0);
  
      // Blit the framebuffer with forced linear colorspace
      glDisable(GL_FRAMEBUFFER_SRGB_EXT);
      glBindFramebuffer(GL_DRAW_FRAMEBUFFER, dstFramebuffer);
      glBindFramebuffer(GL_READ_FRAMEBUFFER, srcFramebuffer);
      glBlitFramebuffer(0, 0, 1, 1, 0, 0, 1, 1, GL_COLOR_BUFFER_BIT, GL_NEAREST);
  
      glBindFramebuffer(GL_FRAMEBUFFER, dstFramebuffer);
      EXPECT_PIXEL_COLOR_NEAR(0, 0, srgbColor, 1.0);
  }
  
  // Use this to select which configurations (e.g. which renderer, which GLES major version) these
  // tests should be run against.
  ANGLE_INSTANTIATE_TEST_ES2_AND_ES3(SRGBFramebufferTest);
  ANGLE_INSTANTIATE_TEST_ES3(SRGBFramebufferTestES3);
  
  }  // namespace angle
  

Download