kc3-lang/angle/src/libANGLE/HandleAllocator.h

• Show log

  Commit

• Hash : 5bf9ff4a
  Author :
  Date : 2016-02-01T11:13:03
  

  Fix leak with binding Framebuffers directly.
  
  Using BindFramebuffer(1) then GenFramebuffers would return 1.
  This leads to a memory leak and was something that was obscuring
  debugging a bug in my ReadPixels fix for ES3.
  
  This also fixes a bug where running the texture tests along produces
  some random failures.
  
  BUG=angleproject:1290
  BUG=angleproject:1299
  
  Change-Id: If11e8c743d2ddde725b12749ac012f670cd290e1
  Reviewed-on: https://chromium-review.googlesource.com/324820
  Reviewed-by: Geoff Lang <geofflang@chromium.org>
  Commit-Queue: Jamie Madill <jmadill@chromium.org>
  Tested-by: Jamie Madill <jmadill@chromium.org>
  

Download

• src/libANGLE/HandleAllocator.h

• //
  // Copyright (c) 2002-2011 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  
  // HandleAllocator.h: Defines the gl::HandleAllocator class, which is used to
  // allocate GL handles.
  
  #ifndef LIBANGLE_HANDLEALLOCATOR_H_
  #define LIBANGLE_HANDLEALLOCATOR_H_
  
  #include "common/angleutils.h"
  
  #include "angle_gl.h"
  
  #include <stack>
  
  namespace gl
  {
  
  class HandleAllocator final : angle::NonCopyable
  {
    public:
      // Maximum handle = MAX_UINT-1
      HandleAllocator();
      // Specify maximum handle value
      HandleAllocator(GLuint maximumHandleValue);
  
      ~HandleAllocator();
  
      void setBaseHandle(GLuint value);
  
      GLuint allocate();
      void release(GLuint handle);
      void reserve(GLuint handle);
  
    private:
      GLuint mBaseValue;
      GLuint mNextValue;
      typedef std::vector<GLuint> HandleList;
      HandleList mFreeValues;
  
      struct HandleRange
      {
          HandleRange(GLuint beginIn, GLuint endIn) : begin(beginIn), end(endIn) {}
  
          GLuint begin;
          GLuint end;
      };
  
      struct HandleRangeComparator;
  
      // The freelist consists of never-allocated handles, stored
      // as ranges, and handles that were previously allocated and
      // released, stored in a stack.
      std::vector<HandleRange> mUnallocatedList;
      std::vector<GLuint> mReleasedList;
  };
  
  }  // namespace gl
  
  #endif   // LIBANGLE_HANDLEALLOCATOR_H_
  

Download