kc3-lang/angle/src/libANGLE/ResourceManager_unittest.cpp

• Show log

  Commit

• Hash : 901b379f
  Author :
  Date : 2016-05-26T09:20:40
  

  Fix use-after-free when deleting share contexts.
  
  The pattern of gen context, share context, free context, then allocate
  a shared GL object in the second context would cause a use-after-free
  of the ContextImpl as a GLFactory. Fix this by passing the factory
  as a parameter to the resource manager allocation methods instead of
  storing the factory pointer. This allows the same ResourceManager to
  work with separate Context implementations, which will work with
  non-virtual contexts.
  
  BUG=612931
  
  Change-Id: Ifceeb893bebd072f318963d935ff9d17181f5305
  Reviewed-on: https://chromium-review.googlesource.com/347463
  Reviewed-by: Geoff Lang <geofflang@chromium.org>
  Commit-Queue: Jamie Madill <jmadill@chromium.org>
  Reviewed-by: Corentin Wallez <cwallez@chromium.org>
  

Download

• src/libANGLE/ResourceManager_unittest.cpp

• //
  // Copyright 2015 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  // Unit tests for ResourceManager.
  //
  
  #include <gmock/gmock.h>
  #include <gtest/gtest.h>
  
  #include "libANGLE/ResourceManager.h"
  #include "tests/angle_unittests_utils.h"
  
  using namespace rx;
  using namespace gl;
  
  using ::testing::_;
  
  namespace
  {
  
  class ResourceManagerTest : public testing::Test
  {
    protected:
      void SetUp() override
      {
          mResourceManager = new ResourceManager();
      }
  
      void TearDown() override
      {
          SafeDelete(mResourceManager);
      }
  
      MockGLFactory mMockFactory;
      ResourceManager *mResourceManager;
  };
  
  TEST_F(ResourceManagerTest, ReallocateBoundTexture)
  {
      EXPECT_CALL(mMockFactory, createTexture(_)).Times(1).RetiresOnSaturation();
  
      mResourceManager->checkTextureAllocation(&mMockFactory, 1, GL_TEXTURE_2D);
      GLuint newTexture = mResourceManager->createTexture();
      EXPECT_NE(1u, newTexture);
  }
  
  TEST_F(ResourceManagerTest, ReallocateBoundBuffer)
  {
      EXPECT_CALL(mMockFactory, createBuffer()).Times(1).RetiresOnSaturation();
  
      mResourceManager->checkBufferAllocation(&mMockFactory, 1);
      GLuint newBuffer = mResourceManager->createBuffer();
      EXPECT_NE(1u, newBuffer);
  }
  
  TEST_F(ResourceManagerTest, ReallocateBoundRenderbuffer)
  {
      EXPECT_CALL(mMockFactory, createRenderbuffer()).Times(1).RetiresOnSaturation();
  
      mResourceManager->checkRenderbufferAllocation(&mMockFactory, 1);
      GLuint newRenderbuffer = mResourceManager->createRenderbuffer();
      EXPECT_NE(1u, newRenderbuffer);
  }
  
  }  // anonymous namespace
  

Download