kc3-lang/angle/src/libANGLE/renderer/BufferImpl.cpp

• Show log

  Commit

• Hash : 31c13df5
  Author :
  Date : 2022-05-30T15:06:26
  

  Revert "Initialize buffer contents separately from BufferImpl::setData"
  
  This reverts commit 34cff1a14b635c76a9063b8710e948d04ef98a79.
  
  Reason for revert: Speculative revert for Mac M1 WebGL failures.
  
  Bug: chromium:1330314
  
  Original change's description:
  > Initialize buffer contents separately from BufferImpl::setData
  >
  > Some backends can initialize buffer data faster than allocating a
  > zero-filled scratch buffer (GL can map and memset for example).
  > Allow those backends the opportunity to make these optimizations.
  >
  > Verified that GL, D3D and VK backends do not regress by using a
  > separate set data call.
  >
  > Bug: chromium:983167
  > Change-Id: Ibcbe6016059434dc36ab3c754df6a24f0a6e5e72
  > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3039778
  > Reviewed-by: Jamie Madill <jmadill@chromium.org>
  > Reviewed-by: Peng Huang <penghuang@chromium.org>
  > Commit-Queue: Geoff Lang <geofflang@chromium.org>
  
  Bug: chromium:983167
  Change-Id: Id1bfa76b832c35fd0b3ade04da16735aa089fdd2
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3677335
  Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
  Commit-Queue: Peng Huang <penghuang@chromium.org>
  

Download

• src/libANGLE/renderer/BufferImpl.cpp

• //
  // Copyright 2020 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  
  // BufferImpl.cpp: Implementation methods rx::BufferImpl class.
  
  #include "libANGLE/renderer/BufferImpl.h"
  
  namespace rx
  {
  
  angle::Result BufferImpl::getSubData(const gl::Context *context,
                                       GLintptr offset,
                                       GLsizeiptr size,
                                       void *outData)
  {
      UNREACHABLE();
      return angle::Result::Stop;
  }
  
  angle::Result BufferImpl::setDataWithUsageFlags(const gl::Context *context,
                                                  gl::BufferBinding target,
                                                  GLeglClientBufferEXT clientBuffer,
                                                  const void *data,
                                                  size_t size,
                                                  gl::BufferUsage usage,
                                                  GLbitfield flags)
  {
      return setData(context, target, data, size, usage);
  }
  
  }  // namespace rx
  

Download