kc3-lang/angle/src/libANGLE/renderer/BufferImpl.h

• Show log

  Commit

• Hash : 31c13df5
  Author :
  Date : 2022-05-30T15:06:26
  

  Revert "Initialize buffer contents separately from BufferImpl::setData"
  
  This reverts commit 34cff1a14b635c76a9063b8710e948d04ef98a79.
  
  Reason for revert: Speculative revert for Mac M1 WebGL failures.
  
  Bug: chromium:1330314
  
  Original change's description:
  > Initialize buffer contents separately from BufferImpl::setData
  >
  > Some backends can initialize buffer data faster than allocating a
  > zero-filled scratch buffer (GL can map and memset for example).
  > Allow those backends the opportunity to make these optimizations.
  >
  > Verified that GL, D3D and VK backends do not regress by using a
  > separate set data call.
  >
  > Bug: chromium:983167
  > Change-Id: Ibcbe6016059434dc36ab3c754df6a24f0a6e5e72
  > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3039778
  > Reviewed-by: Jamie Madill <jmadill@chromium.org>
  > Reviewed-by: Peng Huang <penghuang@chromium.org>
  > Commit-Queue: Geoff Lang <geofflang@chromium.org>
  
  Bug: chromium:983167
  Change-Id: Id1bfa76b832c35fd0b3ade04da16735aa089fdd2
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3677335
  Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
  Commit-Queue: Peng Huang <penghuang@chromium.org>
  

Download

• src/libANGLE/renderer/BufferImpl.h

• //
  // Copyright 2014 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  
  // BufferImpl.h: Defines the abstract rx::BufferImpl class.
  
  #ifndef LIBANGLE_RENDERER_BUFFERIMPL_H_
  #define LIBANGLE_RENDERER_BUFFERIMPL_H_
  
  #include "common/PackedEnums.h"
  #include "common/angleutils.h"
  #include "common/mathutil.h"
  #include "libANGLE/Error.h"
  #include "libANGLE/Observer.h"
  
  #include <stdint.h>
  
  namespace gl
  {
  class BufferState;
  class Context;
  }  // namespace gl
  
  namespace rx
  {
  // We use two set of Subject messages. The CONTENTS_CHANGED message is signaled whenever data
  // changes, to trigger re-translation or other events. Some buffers only need to be updated when the
  // underlying driver object changes - this is notified via the STORAGE_CHANGED message.
  class BufferImpl : public angle::Subject
  {
    public:
      BufferImpl(const gl::BufferState &state) : mState(state) {}
      ~BufferImpl() override {}
      virtual void destroy(const gl::Context *context) {}
  
      virtual angle::Result setDataWithUsageFlags(const gl::Context *context,
                                                  gl::BufferBinding target,
                                                  GLeglClientBufferEXT clientBuffer,
                                                  const void *data,
                                                  size_t size,
                                                  gl::BufferUsage usage,
                                                  GLbitfield flags);
      virtual angle::Result setData(const gl::Context *context,
                                    gl::BufferBinding target,
                                    const void *data,
                                    size_t size,
                                    gl::BufferUsage usage)                                = 0;
      virtual angle::Result setSubData(const gl::Context *context,
                                       gl::BufferBinding target,
                                       const void *data,
                                       size_t size,
                                       size_t offset)                                     = 0;
      virtual angle::Result copySubData(const gl::Context *context,
                                        BufferImpl *source,
                                        GLintptr sourceOffset,
                                        GLintptr destOffset,
                                        GLsizeiptr size)                                  = 0;
      virtual angle::Result map(const gl::Context *context, GLenum access, void **mapPtr) = 0;
      virtual angle::Result mapRange(const gl::Context *context,
                                     size_t offset,
                                     size_t length,
                                     GLbitfield access,
                                     void **mapPtr)                                       = 0;
      virtual angle::Result unmap(const gl::Context *context, GLboolean *result)          = 0;
  
      virtual angle::Result getIndexRange(const gl::Context *context,
                                          gl::DrawElementsType type,
                                          size_t offset,
                                          size_t count,
                                          bool primitiveRestartEnabled,
                                          gl::IndexRange *outRange) = 0;
  
      virtual angle::Result getSubData(const gl::Context *context,
                                       GLintptr offset,
                                       GLsizeiptr size,
                                       void *outData);
  
      // Override if accurate native memory size information is available
      virtual GLint64 getMemorySize() const;
  
      virtual void onDataChanged() {}
  
    protected:
      const gl::BufferState &mState;
  };
  
  inline GLint64 BufferImpl::getMemorySize() const
  {
      return 0;
  }
  
  }  // namespace rx
  
  #endif  // LIBANGLE_RENDERER_BUFFERIMPL_H_
  

Download