kc3-lang/angle/src/libANGLE/Renderbuffer.h

• Show log

  Commit

• Hash : 2eb54074
  Author :
  Date : 2018-08-22T16:41:26
  

  Fix EGLImage pixel format validation
  
  This fixes the scenario when EGLImage source and target have different types.
  For example, a texture is created with unsigned format using glTexImage2D,
  it is used as a source of EGLImage with eglCreateImageKHR,
  and then the EGLImage is used to create a renderbuffer target with
  glEGLImageTargetRenderbufferStorageOES.
  
  OES_EGL_image doesn't specify what should happen in this case,
  but GL implementations (Nexus 5X) seem to allow using this renderbuffer in
  glFramebufferRenderbuffer and the resulting framebuffer is complete.
  Thus, in this case, instead of checking whether the renderbuffer format
  can be used in glFramebufferRenderbuffer, we need to check whether the
  original texture can be used in glFramebufferTexture2D.
  Similarly in reverse direction.
  
  Also, for the case of source renderbuffer and target texture,
  presume that glEGLImageTargetTexture2DOES will succeed regardless of
  renderbuffer format.
  
  1. Add isRenderable and isTexturable checks to egl::Image class,
     and perform different checks depending on source type.
  2. Add isRenderable check to FramebufferAttachment and delegate EGLImage
     attachments check to egl::Image.
  3. Use these checks in validation of EGLImageTargetTexture2D,
     EGLImageTargetRenderbufferStorage and when checking attachment completeness
  
  Bug: angleproject:2567
  
  Change-Id: I8e9f4a2930a4075a4d8464f62582c6825270187e
  Reviewed-on: https://chromium-review.googlesource.com/1192585
  Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
  Reviewed-by: Geoff Lang <geofflang@chromium.org>
  

Download

• src/libANGLE/Renderbuffer.h

• //
  // Copyright (c) 2002-2010 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  
  // Renderbuffer.h: Defines the renderer-agnostic container class gl::Renderbuffer.
  // Implements GL renderbuffer objects and related functionality.
  // [OpenGL ES 2.0.24] section 4.4.3 page 108.
  
  #ifndef LIBANGLE_RENDERBUFFER_H_
  #define LIBANGLE_RENDERBUFFER_H_
  
  #include "angle_gl.h"
  #include "common/angleutils.h"
  #include "libANGLE/Debug.h"
  #include "libANGLE/Error.h"
  #include "libANGLE/FramebufferAttachment.h"
  #include "libANGLE/Image.h"
  #include "libANGLE/formatutils.h"
  #include "libANGLE/renderer/RenderbufferImpl.h"
  
  namespace rx
  {
  class GLImplFactory;
  }  // namespace rx
  
  namespace gl
  {
  // A GL renderbuffer object is usually used as a depth or stencil buffer attachment
  // for a framebuffer object. The renderbuffer itself is a distinct GL object, see
  // FramebufferAttachment and Framebuffer for how they are applied to an FBO via an
  // attachment point.
  
  class RenderbufferState final : angle::NonCopyable
  {
    public:
      RenderbufferState();
      ~RenderbufferState();
  
      GLsizei getWidth() const;
      GLsizei getHeight() const;
      const Format &getFormat() const;
      GLsizei getSamples() const;
  
    private:
      friend class Renderbuffer;
  
      void update(GLsizei width,
                  GLsizei height,
                  const Format &format,
                  GLsizei samples,
                  InitState initState);
  
      GLsizei mWidth;
      GLsizei mHeight;
      Format mFormat;
      GLsizei mSamples;
  
      // For robust resource init.
      InitState mInitState;
  };
  
  class Renderbuffer final : public RefCountObject, public egl::ImageSibling, public LabeledObject
  {
    public:
      Renderbuffer(rx::GLImplFactory *implFactory, GLuint id);
      ~Renderbuffer() override;
  
      Error onDestroy(const Context *context) override;
  
      void setLabel(const std::string &label) override;
      const std::string &getLabel() const override;
  
      Error setStorage(const Context *context, GLenum internalformat, size_t width, size_t height);
      Error setStorageMultisample(const Context *context,
                                  size_t samples,
                                  GLenum internalformat,
                                  size_t width,
                                  size_t height);
      Error setStorageEGLImageTarget(const Context *context, egl::Image *imageTarget);
  
      rx::RenderbufferImpl *getImplementation() const;
  
      GLsizei getWidth() const;
      GLsizei getHeight() const;
      const Format &getFormat() const;
      GLsizei getSamples() const;
      GLuint getRedSize() const;
      GLuint getGreenSize() const;
      GLuint getBlueSize() const;
      GLuint getAlphaSize() const;
      GLuint getDepthSize() const;
      GLuint getStencilSize() const;
  
      // FramebufferAttachmentObject Impl
      Extents getAttachmentSize(const ImageIndex &imageIndex) const override;
      Format getAttachmentFormat(GLenum binding, const ImageIndex &imageIndex) const override;
      GLsizei getAttachmentSamples(const ImageIndex &imageIndex) const override;
      bool isRenderable(const Context *context,
                        GLenum binding,
                        const ImageIndex &imageIndex) const override;
  
      void onAttach(const Context *context) override;
      void onDetach(const Context *context) override;
      GLuint getId() const override;
  
      InitState initState(const ImageIndex &imageIndex) const override;
      void setInitState(const ImageIndex &imageIndex, InitState initState) override;
  
    private:
      rx::FramebufferAttachmentObjectImpl *getAttachmentImpl() const override;
  
      RenderbufferState mState;
      std::unique_ptr<rx::RenderbufferImpl> mImplementation;
  
      std::string mLabel;
  };
  
  }  // namespace gl
  
  #endif   // LIBANGLE_RENDERBUFFER_H_
  

Download