-
Show log
Commit
-
Hash : 1593390b
Author :
Date : 2025-04-07T11:22:21
Increase ANGLE_LIKELY/UNLIKELY probability to 99.99% I can't find the exact value for clang, but according to GCC docs __builtin_expect probability is assumed to be only 90%. When we actually bother to use ANGLE_LIKELY we mean "almost always", so this value can be much higher. Setting to 99.99% because lower values don't seem to trigger the optimization below (at least 99.9% doesn't) __builtin_expect already enables some optimizations such as moving unlikely branches (e.g. cold function calls) out of the primary flow. Increasing the probability enables more aggressive optimizations such as making those function calls store/load registers only in the rare cases when this call is made - which allows the rest of the caller to be made more efficient by not having to handle these register changes. Example: stur w4, [x29, #-0xc] stur x8, [x29, #-0x8] str x3, [sp, #0x8] stp w2, w1, [x29, #0x18] bl 0x356fdc <_ZNK2gl7Context25getActiveLinkedProgramPPOEv> ldp w2, w1, [x29, #0x18] ldr x3, [sp, #0x8] ldur w4, [x29, #-0xc] ldur x8, [x29, #-0x8] Bug: b/383305597 Change-Id: I077f4f2cb90cfb8282409d12adcb02c3302e7761 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6437572 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
-
Files
- BinaryStream.h
- BinaryStream_unittest.cpp
- CircularBuffer.h
- CircularBuffer_unittest.cpp
- Color.h
- Color.inc
- CompiledShaderState.cpp
- CompiledShaderState.h
- FastVector.h
- FastVector_unittest.cpp
- FixedQueue.h
- FixedQueue_unittest.cpp
- FixedVector.h
- FixedVector_unittest.cpp
- Float16ToFloat32.cpp
- Float16ToFloat32.py
- MemoryBuffer.cpp
- MemoryBuffer.h
- MemoryBuffer_unittest.cpp
- Optional.h
- Optional_unittest.cpp
- PackedCLEnums_autogen.cpp
- PackedCLEnums_autogen.h
- PackedEGLEnums_autogen.cpp
- PackedEGLEnums_autogen.h
- PackedEnums.cpp
- PackedEnums.h
- PackedGLEnums_autogen.cpp
- PackedGLEnums_autogen.h
- PoolAlloc.cpp
- PoolAlloc.h
- PoolAlloc_unittest.cpp
- RingBufferAllocator.cpp
- RingBufferAllocator.h
- SimpleMutex.cpp
- SimpleMutex.h
- SimpleMutex_unittest.cpp
- SynchronizedValue.h
- WorkerThread.cpp
- WorkerThread.h
- WorkerThread_unittest.cpp
- aligned_memory.cpp
- aligned_memory.h
- aligned_memory_unittest.cpp
- android_util.cpp
- android_util.h
- angle_version.h
- angle_version_info.cpp
- angle_version_info.h
- angleutils.cpp
- angleutils.h
- angleutils_unittest.cpp
- apple/
- apple_platform_utils.h
- apple_platform_utils.mm
- backtrace_utils.h
- backtrace_utils_android.cpp
- backtrace_utils_noop.cpp
- base/
- bitset_utils.h
- bitset_utils_unittest.cpp
- debug.cpp
- debug.h
- entry_points_enum_autogen.cpp
- entry_points_enum_autogen.h
- event_tracer.cpp
- event_tracer.h
- frame_capture_utils.cpp
- frame_capture_utils.h
- frame_capture_utils_autogen.cpp
- frame_capture_utils_autogen.h
- fuchsia_egl/
- gen_packed_gl_enums.py
- gen_uniform_type_table.py
- gl/
- gl_enum_utils.cpp
- gl_enum_utils.h
- gl_enum_utils_autogen.cpp
- gl_enum_utils_autogen.h
- hash_containers.h
- hash_utils.h
- hash_utils_unittest.cpp
- linux/
- log_utils.h
- mathutil.cpp
- mathutil.h
- mathutil_unittest.cpp
- matrix_utils.cpp
- matrix_utils.h
- matrix_utils_unittest.cpp
- packed_cl_enums.json
- packed_egl_enums.json
- packed_gl_enums.json
- platform.h
- platform_helpers.cpp
- platform_helpers.h
- serializer/
- span.h
- span_unittest.cpp
- spirv/
- string_utils.cpp
- string_utils.h
- string_utils_unittest.cpp
- system_utils.cpp
- system_utils.h
- system_utils_apple.cpp
- system_utils_ios.cpp
- system_utils_ios.mm
- system_utils_linux.cpp
- system_utils_mac.cpp
- system_utils_posix.cpp
- system_utils_unittest.cpp
- system_utils_win.cpp
- system_utils_win32.cpp
- system_utils_winuwp.cpp
- third_party/
- tls.cpp
- tls.h
- uniform_type_info_autogen.cpp
- uniform_type_info_autogen.h
- utilities.cpp
- utilities.h
- utilities_unittest.cpp
- vector_utils.h
- vector_utils_unittest.cpp
- vulkan/
