kc3-lang/angle/src/tests/preprocessor_tests/pragma_test.cpp

• Show log

  Commit

• Hash : d3c29f57
  Author :
  Date : 2015-04-28T11:23:02
  

  Add pragma errors for malformed pragmas.
  
  Instead of always warning on invalid pragmas, only warn when the pragma
  type is not recognized and error when the syntax is invalid.
  
  Fixes:
  dEQP-GLES2.functional.shaders.preprocessor.pragmas.invalid_pragma_invalid_debug_vertex
  dEQP-GLES2.functional.shaders.preprocessor.pragmas.invalid_pragma_invalid_debug_fragment
  dEQP-GLES2.functional.shaders.preprocessor.pragmas.invalid_pragma_invalid_token_vertex
  dEQP-GLES2.functional.shaders.preprocessor.pragmas.invalid_pragma_invalid_token_fragment
  
  BUG=angleproject:989
  
  Change-Id: Ibd584dc08a2436e163dfc52eeffdf2dac8a22cb8
  Reviewed-on: https://chromium-review.googlesource.com/267639
  Reviewed-by: Zhenyao Mo <zmo@chromium.org>
  Tested-by: Geoff Lang <geofflang@chromium.org>
  

Download

• src/tests/preprocessor_tests/pragma_test.cpp

• //
  // Copyright (c) 2012 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  
  #include "PreprocessorTest.h"
  #include "Token.h"
  
  class PragmaTest : public PreprocessorTest
  {
  };
  
  TEST_F(PragmaTest, EmptyName)
  {
      const char* str = "#pragma\n";
      const char* expected = "\n";
  
      using testing::_;
      // No handlePragma calls.
      EXPECT_CALL(mDirectiveHandler, handlePragma(_, _, _, false)).Times(0);
      // No error or warning.
      EXPECT_CALL(mDiagnostics, print(_, _, _)).Times(0);
  
      preprocess(str, expected);
  }
  
  TEST_F(PragmaTest, EmptyValue)
  {
      const char* str = "#pragma foo\n";
      const char* expected = "\n";
  
      using testing::_;
      EXPECT_CALL(mDirectiveHandler,
                  handlePragma(pp::SourceLocation(0, 1), "foo", "", false));
      // No error or warning.
      EXPECT_CALL(mDiagnostics, print(_, _, _)).Times(0);
  
      preprocess(str, expected);
  }
  
  TEST_F(PragmaTest, NameValue)
  {
      const char* str = "#pragma foo(bar)\n";
      const char* expected = "\n";
  
      using testing::_;
      EXPECT_CALL(mDirectiveHandler,
                  handlePragma(pp::SourceLocation(0, 1), "foo", "bar", false));
      // No error or warning.
      EXPECT_CALL(mDiagnostics, print(_, _, _)).Times(0);
  
      preprocess(str, expected);
  }
  
  TEST_F(PragmaTest, STDGL)
  {
      const char* str = "#pragma STDGL\n";
      const char* expected = "\n";
  
      using testing::_;
      EXPECT_CALL(mDirectiveHandler,
                  handlePragma(_, _, _, _)).Times(0);
      // No error or warning.
      EXPECT_CALL(mDiagnostics, print(_, _, _)).Times(0);
  
      preprocess(str, expected);
  }
  
  TEST_F(PragmaTest, STDGLInvariantAll)
  {
      const char* str = "#pragma STDGL invariant(all)\n";
      const char* expected = "\n";
  
      using testing::_;
      EXPECT_CALL(mDirectiveHandler,
                  handlePragma(pp::SourceLocation(0, 1), "invariant", "all", true));
      // No error or warning.
      EXPECT_CALL(mDiagnostics, print(_, _, _)).Times(0);
  
      preprocess(str, expected);
  }
  
  TEST_F(PragmaTest, Comments)
  {
      const char* str = "/*foo*/"
                        "#"
                        "/*foo*/"
                        "pragma"
                        "/*foo*/"
                        "foo"
                        "/*foo*/"
                        "("
                        "/*foo*/"
                        "bar"
                        "/*foo*/"
                        ")"
                        "/*foo*/"
                        "//foo"
                        "\n";
      const char* expected = "\n";
  
      using testing::_;
      EXPECT_CALL(mDirectiveHandler,
                  handlePragma(pp::SourceLocation(0, 1), "foo", "bar", false));
      // No error or warning.
      EXPECT_CALL(mDiagnostics, print(_, _, _)).Times(0);
  
      preprocess(str, expected);
  }
  
  TEST_F(PragmaTest, MissingNewline)
  {
      const char* str = "#pragma foo(bar)";
      const char* expected = "";
  
      using testing::_;
      // Pragma successfully parsed.
      EXPECT_CALL(mDirectiveHandler,
                  handlePragma(pp::SourceLocation(0, 1), "foo", "bar", false));
      // Error reported about EOF.
      EXPECT_CALL(mDiagnostics, print(pp::Diagnostics::PP_EOF_IN_DIRECTIVE, _, _));
  
      preprocess(str, expected);
  }
  
  class InvalidPragmaTest : public PragmaTest,
                            public testing::WithParamInterface<const char*>
  {
  };
  
  TEST_P(InvalidPragmaTest, Identified)
  {
      const char* str = GetParam();
      const char* expected = "\n";
  
      using testing::_;
      // No handlePragma calls.
      EXPECT_CALL(mDirectiveHandler, handlePragma(_, _, _, false)).Times(0);
      // Invalid pragma error.
      EXPECT_CALL(mDiagnostics,
                  print(pp::Diagnostics::PP_INVALID_PRAGMA,
                        pp::SourceLocation(0, 1), _));
  
      preprocess(str, expected);
  }
  
  INSTANTIATE_TEST_CASE_P(All, InvalidPragmaTest, testing::Values(
      "#pragma 1\n",               // Invalid name.
      "#pragma foo()\n",           // Missing value.
      "#pragma foo bar)\n",        // Missing left paren,
      "#pragma foo(bar\n",         // Missing right paren.
      "#pragma foo bar\n",         // Missing parens.
      "#pragma foo(bar) baz\n"));  // Extra tokens.
  

Download