-
Show log
Commit
-
Hash : a3d384ad
Author :
Date : 2017-10-06T16:12:50
Fix signed integer overflow in GLSL preprocessor left shift Signed integer overflow is undefined in C++, whereas unsigned integer overflow is not. Always cast left shift operand to unsigned to avoid UB. On common compilers, the behavior was already the same before this patch, so this patch is done mostly for the benefit of automated fuzz testing. BUG=chromium:743136 TEST=angle_unittests Change-Id: I7aab939036bb19a37f258cef4297b560da3cd9d5 Reviewed-on: https://chromium-review.googlesource.com/704659 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
-
Files
- 64bit-tokenizer-safety.patch
- DiagnosticsBase.cpp
- DiagnosticsBase.h
- DirectiveHandlerBase.cpp
- DirectiveHandlerBase.h
- DirectiveParser.cpp
- DirectiveParser.h
- ExpressionParser.cpp
- ExpressionParser.h
- ExpressionParser.y
- Input.cpp
- Input.h
- Lexer.cpp
- Lexer.h
- Macro.cpp
- Macro.h
- MacroExpander.cpp
- MacroExpander.h
- Preprocessor.cpp
- Preprocessor.h
- SourceLocation.h
- Token.cpp
- Token.h
- Tokenizer.cpp
- Tokenizer.h
- Tokenizer.l
- generate_parser.sh
- numeric_lex.h
