Hash :
3bbdee0f
Author :
Date :
2025-03-28T11:55:24
Vulkan: Remove Subject/Observer from BufferImpl Right now the gl::Buffer back end send message to the front end and then gl::Buffer propagate the message to the observers (vertex array, textures, transform feedback). We are seeing many of these kind of message passing (mainly to vertexArray), and each message is a virtual function call. The message call also lacks of context information that we can not do certain optimizations. This CL adopts the new API feedback argument approach for buffer APIs from the back end to the front end. The only difficulty I ran into is D3D backend where the message could be delivered from draw calls. For now the subject/observer code path is still kept in the gl::Buffer, but no back end will use it except D3D11. That will be removed in the later CL when D3D11 switch to use feedback mechanism. BYPASS_LARGE_CHANGE_WARNING Bug: angleproject:400711938 Change-Id: I5fb3b660fd4260b9ba691239ad777b575b31e2ab Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6408892 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75
//
// Copyright 2015 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// BufferImpl_mock.h: Defines a mock of the BufferImpl class.
#ifndef LIBANGLE_RENDERER_BUFFERIMPLMOCK_H_
#define LIBANGLE_RENDERER_BUFFERIMPLMOCK_H_
#include "gmock/gmock.h"
#include "libANGLE/Buffer.h"
#include "libANGLE/renderer/BufferImpl.h"
namespace rx
{
class MockBufferImpl : public BufferImpl
{
public:
MockBufferImpl() : BufferImpl(mMockState) {}
~MockBufferImpl() { destructor(); }
MOCK_METHOD6(setData,
angle::Result(const gl::Context *,
gl::BufferBinding,
const void *,
size_t,
gl::BufferUsage,
BufferFeedback *));
MOCK_METHOD6(setSubData,
angle::Result(const gl::Context *,
gl::BufferBinding,
const void *,
size_t,
size_t,
BufferFeedback *));
MOCK_METHOD6(copySubData,
angle::Result(const gl::Context *contextImpl,
BufferImpl *,
GLintptr,
GLintptr,
GLsizeiptr,
BufferFeedback *));
MOCK_METHOD4(map,
angle::Result(const gl::Context *contextImpl, GLenum, void **, BufferFeedback *));
MOCK_METHOD6(mapRange,
angle::Result(const gl::Context *contextImpl,
size_t,
size_t,
GLbitfield,
void **,
BufferFeedback *));
MOCK_METHOD3(unmap,
angle::Result(const gl::Context *contextImpl,
GLboolean *result,
BufferFeedback *));
MOCK_METHOD6(getIndexRange,
angle::Result(const gl::Context *,
gl::DrawElementsType,
size_t,
size_t,
bool,
gl::IndexRange *));
MOCK_METHOD0(destructor, void());
protected:
gl::BufferState mMockState;
};
} // namespace rx
#endif // LIBANGLE_RENDERER_BUFFERIMPLMOCK_H_