kc3-lang/angle/src/libANGLE/Error.h

• Show log

  Commit

• Hash : 3940a453
  Author :
  Date : 2015-01-14T17:26:32
  

  Only call std::string constructor in gl::Error when necessary
  
  std::string's constructor is very expensive in debug builds.
  In some applications we have seen it use 10% of the CPU.
  This change makes (e)gl::Error store a pointer to an std::string,
  and only create a string when necessary.
  
  Change-Id: I78bfbda86568944681517fe32df9d1556e4ebee7
  Reviewed-on: https://chromium-review.googlesource.com/240495
  Tested-by: Austin Kinross <aukinros@microsoft.com>
  Reviewed-by: Jamie Madill <jmadill@chromium.org>
  Reviewed-by: Geoff Lang <geofflang@chromium.org>
  

Download

• src/libANGLE/Error.h

• //
  // Copyright (c) 2014 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  
  // Error.h: Defines the egl::Error and gl::Error classes which encapsulate API errors
  // and optional error messages.
  
  #ifndef LIBANGLE_ERROR_H_
  #define LIBANGLE_ERROR_H_
  
  #include "angle_gl.h"
  #include <EGL/egl.h>
  
  #include <string>
  
  namespace gl
  {
  
  class Error
  {
    public:
      explicit Error(GLenum errorCode);
      Error(GLenum errorCode, const char *msg, ...);
      Error(const Error &other);
      ~Error();
      Error &operator=(const Error &other);
  
      GLenum getCode() const { return mCode; }
      bool isError() const { return (mCode != GL_NO_ERROR); }
  
      const std::string &getMessage() const;
  
    private:
      void createMessageString() const;
  
      GLenum mCode;
      mutable std::string *mMessage;
  };
  
  }
  
  namespace egl
  {
  
  class Error
  {
    public:
      explicit Error(EGLint errorCode);
      Error(EGLint errorCode, const char *msg, ...);
      Error(const Error &other);
      ~Error();
      Error &operator=(const Error &other);
  
      EGLint getCode() const { return mCode; }
      bool isError() const { return (mCode != EGL_SUCCESS); }
  
      const std::string &getMessage() const;
  
    private:
      void createMessageString() const;
  
      EGLint mCode;
      mutable std::string *mMessage;
  };
  
  }
  
  #endif // LIBANGLE_ERROR_H_
  

Download