kc3-lang/angle/src/tests/compiler_tests/ImmutableString_test.cpp

• Show log

  Commit

• Hash : 0197826b
  Author :
  Date : 2024-03-22T14:42:34
  

  Revert "Add conversion operator from ImmutableString to std::string"
  
  This reverts commit 8c0dae388bccb00f11cd94d641d719cc68325826.
  
  Reason for revert:
  Breaks Android rolls:
  
  external/angle/src/compiler/translator/ImmutableString.h:103:15: error: constexpr function's return type 'std::string' (aka 'basic_string<char, char_traits<char>, allocator<char>>') is not a literal type
    103 |     constexpr operator std::string() const { return std::string(data(), length()); }
        |               ^
  external/libcxx/include/string:4332:64: note: 'basic_string<char>' is not literal because it is not an aggregate and has no constexpr constructors other than copy or move constructors
   4332 | _LIBCPP_EXTERN_TEMPLATE(class _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS basic_string<char>)
  
  Original change's description:
  > Add conversion operator from ImmutableString to std::string
  >
  > Also use the operator in a couple of places. Sometimes saves a strlen.
  >
  > Bug: angleproject:8614
  > Change-Id: I429f3ac02af04b568ac7d1adf22ab65e5007fbda
  > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5372728
  > Reviewed-by: Geoff Lang <geofflang@chromium.org>
  > Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com>
  > Commit-Queue: Geoff Lang <geofflang@chromium.org>
  > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
  
  Bug: angleproject:8614
  Change-Id: I46963686f9506f7029e164250b1bf81f8ab2c519
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5388255
  Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
  Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
  Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
  Commit-Queue: Roman Lavrov <romanl@google.com>
  

Download

• src/tests/compiler_tests/ImmutableString_test.cpp

• // Copyright 2018 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  // ImmutableString_test.cpp:
  //   Tests for ImmutableString and ImmutableStringBuilder.
  
  #include "compiler/translator/ImmutableString.h"
  #include "compiler/translator/ImmutableStringBuilder.h"
  #include "compiler/translator/PoolAlloc.h"
  #include "gtest/gtest.h"
  
  using namespace sh;
  
  class ImmutableStringBuilderTest : public testing::Test
  {
    public:
      ImmutableStringBuilderTest() {}
  
    protected:
      void SetUp() override
      {
          allocator.push();
          SetGlobalPoolAllocator(&allocator);
      }
  
      void TearDown() override
      {
          SetGlobalPoolAllocator(nullptr);
          allocator.pop();
      }
  
      angle::PoolAllocator allocator;
  };
  
  // Test writing a 32-bit signed int as hexadecimal using ImmutableStringBuilder.
  TEST_F(ImmutableStringBuilderTest, AppendHexInt32)
  {
      int32_t i = -1;
      ImmutableStringBuilder strBuilder(2 * sizeof(int32_t));
      strBuilder.appendHex(i);
      ImmutableString str = strBuilder;
      EXPECT_EQ(std::string("ffffffff"), str.data());
  }
  
  // Test writing a 32-bit unsigned int as hexadecimal using ImmutableStringBuilder.
  TEST_F(ImmutableStringBuilderTest, AppendHexUint32)
  {
      uint32_t i = 0x1234beefu;
      ImmutableStringBuilder strBuilder(2 * sizeof(uint32_t));
      strBuilder.appendHex(i);
      ImmutableString str = strBuilder;
      EXPECT_EQ(std::string("1234beef"), str.data());
  }
  
  // Test writing a 64-bit signed int as hexadecimal using ImmutableStringBuilder.
  TEST_F(ImmutableStringBuilderTest, AppendHexInt64)
  {
      int64_t i = -1;
      ImmutableStringBuilder strBuilder(2 * sizeof(int64_t));
      strBuilder.appendHex(i);
      ImmutableString str = strBuilder;
      EXPECT_EQ(std::string("ffffffffffffffff"), str.data());
  }
  
  // Test writing a 64-bit unsigned int as hexadecimal using ImmutableStringBuilder.
  TEST_F(ImmutableStringBuilderTest, AppendHexUint64)
  {
      uint64_t i = 0xfeedcafe9876beefull;
      ImmutableStringBuilder strBuilder(2 * sizeof(uint64_t));
      strBuilder.appendHex(i);
      ImmutableString str = strBuilder;
      EXPECT_EQ(std::string("feedcafe9876beef"), str.data());
  }
  
  // Test writing a decimal using ImmutableStringBuilder of exact size.
  TEST_F(ImmutableStringBuilderTest, AppendDecimal)
  {
      ImmutableStringBuilder b1(1);
      b1.appendDecimal(1);
      ImmutableString s1 = b1;
      EXPECT_EQ(std::string("1"), s1.data());
  
      ImmutableStringBuilder b20(2);
      b20.appendDecimal(20);
      ImmutableString s20 = b20;
      EXPECT_EQ(std::string("20"), s20.data());
  
      ImmutableStringBuilder b30000(5);
      b30000.appendDecimal(30000);
      ImmutableString s30000 = b30000;
      EXPECT_EQ(std::string("30000"), s30000.data());
  }
  

Download