kc3-lang/angle/src/libANGLE/Error.cpp

• Show log

  Commit

• Hash : 7c985f5c
  Author :
  Date : 2018-11-29T18:16:17
  

  Make angle::Result an enum.
  
  This moves away from a class type to a value type. This should improve
  performance when using angle::Result as a return value. Previously the
  generated code would return a pointer instead of a value.
  
  Improves performance in the most targeted microbenchmark by 10%. In
  more realistic scanarios it will have a smaller improvement. Also
  simplifies the class implementation and usage.
  
  Includes some unrelated code generation changes.
  
  Bug: angleproject:2491
  Change-Id: Ifcf86870bf1c00a2f73c39ea6e4f05ca705050aa
  Reviewed-on: https://chromium-review.googlesource.com/c/1356139
  Commit-Queue: Jamie Madill <jmadill@chromium.org>
  Reviewed-by: Jamie Madill <jmadill@chromium.org>
  

Download

• src/libANGLE/Error.cpp

• //
  // Copyright (c) 2014 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  
  // Error.cpp: Implements the egl::Error and gl::Error classes which encapsulate API errors
  // and optional error messages.
  
  #include "libANGLE/Error.h"
  
  #include "common/angleutils.h"
  #include "common/debug.h"
  #include "common/utilities.h"
  
  #include <cstdarg>
  
  namespace
  {
  std::unique_ptr<std::string> EmplaceErrorString(std::string &&message)
  {
      return message.empty() ? std::unique_ptr<std::string>()
                             : std::unique_ptr<std::string>(new std::string(std::move(message)));
  }
  }  // anonymous namespace
  
  namespace egl
  {
  
  Error::Error(EGLint errorCode, std::string &&message)
      : mCode(errorCode), mID(errorCode), mMessage(EmplaceErrorString(std::move(message)))
  {}
  
  Error::Error(EGLint errorCode, EGLint id, std::string &&message)
      : mCode(errorCode), mID(id), mMessage(EmplaceErrorString(std::move(message)))
  {}
  
  void Error::createMessageString() const
  {
      if (!mMessage)
      {
          mMessage.reset(new std::string(GetGenericErrorMessage(mCode)));
      }
  }
  
  const std::string &Error::getMessage() const
  {
      createMessageString();
      return *mMessage;
  }
  
  std::ostream &operator<<(std::ostream &os, const Error &err)
  {
      return gl::FmtHex(os, err.getCode());
  }
  }  // namespace egl
  
  namespace angle
  {
  egl::Error ResultToEGL(Result result)
  {
      if (result == Result::Continue)
          return egl::NoError();
  
      return egl::Error(EGL_BAD_ACCESS);
  }
  }  // namespace angle
  

Download