Hash :
bb27c3a1
Author :
Date :
2017-11-15T16:32:25
Fix VectorizeVectorScalarArithmetic statement insertion The traverser must avoid inserting two statements to the same position on a single traversal, so it doesn't trigger an assert. BUG=chromium:784078 TEST=angle_unittests Change-Id: I855054e62cc1b1cf4e6bb02af527954151c7d0e7 Reviewed-on: https://chromium-review.googlesource.com/771611 Commit-Queue: Olli Etuaho <oetuaho@nvidia.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50
//
// Copyright (c) 2017 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// VectorizeVectorScalarArithmetic_test.cpp:
// Tests shader compilation with SH_REWRITE_VECTOR_SCALAR_ARITHMETIC workaround on.
#include "GLSLANG/ShaderLang.h"
#include "angle_gl.h"
#include "gtest/gtest.h"
#include "tests/test_utils/ShaderCompileTreeTest.h"
using namespace sh;
class VectorizeVectorScalarArithmeticTest : public ShaderCompileTreeTest
{
public:
VectorizeVectorScalarArithmeticTest() : ShaderCompileTreeTest()
{
mExtraCompileOptions = SH_REWRITE_VECTOR_SCALAR_ARITHMETIC;
}
protected:
::GLenum getShaderType() const override { return GL_FRAGMENT_SHADER; }
ShShaderSpec getShaderSpec() const override { return SH_GLES3_1_SPEC; }
};
// Test that two ops that generate statements in the parent block inside the same statement don't
// trigger an assert.
TEST_F(VectorizeVectorScalarArithmeticTest, TwoMutatedOpsWithSideEffectsInsideSameStatement)
{
const std::string &shaderString =
R"(#version 300 es
precision highp float;
out vec4 res;
uniform float uf;
void main()
{
res = vec4(0.0);
float f = uf;
res += f *= f, res += f *= f;
})";
if (!compile(shaderString))
{
FAIL() << "Shader compilation failed, expecting success:\n" << mInfoLog;
}
}