kc3-lang/angle/src/compiler/translator/SymbolUniqueId.cpp

• Show log

  Commit

• Hash : 2d88e9bc
  Author :
  Date : 2017-07-21T16:52:03
  

  Guarantee that symbol nodes get unique ids
  
  The code is refactored so that symbol nodes can only be initialized
  with an unique id object. This prevents accidentally forgetting to
  create an id for a symbol node.
  
  This opens up possibilities for future optimization: For example the
  names and types of symbols could be stored in a central location
  inside the SymbolTable, and TIntermSymbol nodes would only need to
  store the symbol id. The symbol id could be used to look up the name
  and type of the node.
  
  BUG=angleproject:1490
  TEST=angle_unittests
  
  Change-Id: Ib8c8675d31493037a5a28c7b36bb9d1113cc10f6
  Reviewed-on: https://chromium-review.googlesource.com/580955
  Reviewed-by: Corentin Wallez <cwallez@chromium.org>
  Reviewed-by: Jamie Madill <jmadill@chromium.org>
  Commit-Queue: Jamie Madill <jmadill@chromium.org>
  Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
  

Download

• src/compiler/translator/SymbolUniqueId.cpp

• //
  // Copyright (c) 2017 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  // SymbolUniqueId.cpp: Encapsulates a unique id for a symbol.
  
  #include "compiler/translator/SymbolUniqueId.h"
  
  #include "compiler/translator/SymbolTable.h"
  
  namespace sh
  {
  
  TSymbolUniqueId::TSymbolUniqueId(TSymbolTable *symbolTable) : mId(symbolTable->nextUniqueIdValue())
  {
  }
  
  TSymbolUniqueId::TSymbolUniqueId(const TSymbol &symbol) : mId(symbol.getUniqueId().get())
  {
  }
  
  int TSymbolUniqueId::get() const
  {
      return mId;
  }
  
  }  // namespace sh
  

Download