kc3-lang/angle/src/tests/compiler_tests/OES_sample_variables_test.cpp

• Show log

  Commit

• Hash : 02e7f967
  Author :
  Date : 2023-05-25T14:54:49
  

  Translator: Remove the "variables" option
  
  Variable collection is invariably enabled by the front-end as well as
  other major users of ANGLE such as Firefox.  All translator backends
  except GLSL force-enable variable collection either way.
  
  This change removes this compile option and enables variable collection
  unconditionally.
  
  The flag itself remains in ShCompileOptions until references to it are
  removed from Chromium.
  
  Bug: chromium:1447314
  Change-Id: I4d3b30c1bfbd345c5ad269abc62c0a6a59de2f56
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4568524
  Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
  Commit-Queue: Geoff Lang <geofflang@chromium.org>
  Reviewed-by: Geoff Lang <geofflang@chromium.org>
  

Download

• src/tests/compiler_tests/OES_sample_variables_test.cpp

• //
  // Copyright 2020 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  // OES_sample_variables_test.cpp:
  //   Test for OES_sample_variables
  //
  
  #include "tests/test_utils/ShaderExtensionTest.h"
  
  namespace
  {
  const char OESPragma[] = "#extension GL_OES_sample_variables : require\n";
  
  // Shader using gl_SampleMask with non-constant index
  // This shader is in the deqp test
  // (functional_shaders_sample_variables_sample_mask_discard_half_per_sample_default_framebuffer)
  const char ESSL310_GLSampleMaskShader[] =
      R"(
      layout(location = 0) out mediump vec4 fragColor;
      void main (void)
      {
          for (int i = 0; i < gl_SampleMask.length(); ++i)
                  gl_SampleMask[i] = int(0xAAAAAAAA);
  
          // force per-sample shading
          highp float blue = float(gl_SampleID);
  
          fragColor = vec4(0.0, 1.0, blue, 1.0);
      })";
  
  // Shader using gl_SampleMask with non-constant index
  // This shader is based on the deqp test on below
  // (functional_shaders_sample_variables_sample_mask_in_bit_count_per_sample_multisample_texture_2)
  const char ESSL310_GLSampleMaskInShader[] =
      R"(
      layout(location = 0) out mediump vec4 fragColor;
      void main (void)
      {
          mediump int maskBitCount = 0;
          for (int j = 0; j < gl_SampleMaskIn.length(); ++j)
          {
              for (int i = 0; i < 32; ++i)
              {
                  if (((gl_SampleMaskIn[j] >> i) & 0x01) == 0x01)
                  {
                      ++maskBitCount;
                  }
              }
          }
  
          // force per-sample shading
          highp float blue = float(gl_SampleID);
  
          if (maskBitCount != 1)
              fragColor = vec4(1.0, 0.0, blue, 1.0);
          else
              fragColor = vec4(0.0, 1.0, blue, 1.0);
      })";
  
  class OESSampleVariablesTest : public sh::ShaderExtensionTest
  {
    public:
      void InitializeCompiler() { InitializeCompiler(SH_GLSL_450_CORE_OUTPUT); }
      void InitializeCompiler(ShShaderOutput shaderOutputType)
      {
          DestroyCompiler();
  
          mCompiler = sh::ConstructCompiler(GL_FRAGMENT_SHADER, testing::get<0>(GetParam()),
                                            shaderOutputType, &mResources);
          ASSERT_TRUE(mCompiler != nullptr) << "Compiler could not be constructed.";
      }
  
      testing::AssertionResult TestShaderCompile(const char *pragma)
      {
          const char *shaderStrings[] = {testing::get<1>(GetParam()), pragma,
                                         testing::get<2>(GetParam())};
  
          ShCompileOptions compileOptions = {};
          compileOptions.objectCode       = true;
  
          bool success = sh::Compile(mCompiler, shaderStrings, 3, compileOptions);
          if (success)
          {
              return ::testing::AssertionSuccess() << "Compilation success";
          }
          return ::testing::AssertionFailure() << sh::GetInfoLog(mCompiler);
      }
  };
  
  // GLES3 needs OES_sample_variables extension
  class OESSampleVariablesTestES31 : public OESSampleVariablesTest
  {};
  
  // Extension flag is required to compile properly. Expect failure when it is
  // not present.
  TEST_P(OESSampleVariablesTestES31, CompileFailsWithoutExtension)
  {
      mResources.OES_sample_variables = 0;
      InitializeCompiler();
      EXPECT_FALSE(TestShaderCompile(OESPragma));
  }
  
  // Extension directive is required to compile properly. Expect failure when
  // it is not present.
  TEST_P(OESSampleVariablesTestES31, CompileFailsWithExtensionWithoutPragma)
  {
      mResources.OES_sample_variables = 1;
      InitializeCompiler();
      EXPECT_FALSE(TestShaderCompile(""));
  }
  
  // With extension flag and extension directive, compiling succeeds.
  // Also test that the extension directive state is reset correctly.
  #ifdef ANGLE_ENABLE_VULKAN
  TEST_P(OESSampleVariablesTestES31, CompileSucceedsWithExtensionAndPragmaOnVulkan)
  {
      mResources.OES_sample_variables = 1;
      InitializeCompiler(SH_SPIRV_VULKAN_OUTPUT);
      EXPECT_TRUE(TestShaderCompile(OESPragma));
      // Test reset functionality.
      EXPECT_FALSE(TestShaderCompile(""));
      EXPECT_TRUE(TestShaderCompile(OESPragma));
  }
  #endif
  
  INSTANTIATE_TEST_SUITE_P(CorrectESSL310Shaders,
                           OESSampleVariablesTestES31,
                           Combine(Values(SH_GLES3_1_SPEC),
                                   Values(sh::ESSLVersion310),
                                   Values(ESSL310_GLSampleMaskShader, ESSL310_GLSampleMaskInShader)));
  
  }  // anonymous namespace
  

Download