-
Show log
Commit
-
Hash : dc4b1acd
Author :
Date : 2023-11-30T15:42:32
Translator: Limit private variable size to 64KB This is indirectly fixing an issue where passing large arrays in SPIR-V such that an internal cast is needed (such as array inside interface block copied to local varaible) causes an overflow of the instruction length limit (in the absence of OpCopyLogical). By limiting the size of private variables to 32KB, this limitation is indirectly enforced. It was observed that all the test shaders added in this CL fail on the Nvidia OpenGL drivers, so such a limit seems to be reasonble. Bug: chromium:1505009 Change-Id: Ia36134b2bf8501a5b875814db3566be28b183e0f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5077408 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
-
Files
- API_test.cpp
- APPLE_clip_distance_test.cpp
- ARB_texture_rectangle_test.cpp
- AppendixALimitations_test.cpp
- AtomicCounter_test.cpp
- BufferVariables_test.cpp
- CollectVariables_test.cpp
- ConstantFoldingNaN_test.cpp
- ConstantFoldingOverflow_test.cpp
- ConstantFolding_test.cpp
- ConstructCompiler_test.cpp
- EXT_YUV_target_test.cpp
- EXT_blend_func_extended_test.cpp
- EXT_clip_cull_distance_test.cpp
- EXT_frag_depth_test.cpp
- EXT_shader_framebuffer_fetch_test.cpp
- EXT_shader_texture_lod_test.cpp
- EXT_shadow_samplers_test.cpp
- EmulateGLBaseVertexBaseInstance_test.cpp
- EmulateGLDrawID_test.cpp
- EmulateGLFragColorBroadcast_test.cpp
- ExpressionLimit_test.cpp
- ExtensionDirective_test.cpp
- FloatLex_test.cpp
- FragDepth_test.cpp
- GLSLCompatibilityOutput_test.cpp
- GeometryShader_test.cpp
- GlFragDataNotModified_test.cpp
- HLSLOutput_test.cpp
- ImmutableString_test.cpp
- ImmutableString_test_ESSL_autogen.cpp
- ImmutableString_test_autogen.cpp
- InitOutputVariables_test.cpp
- IntermNode_test.cpp
- KHR_blend_equation_advanced_test.cpp
- MSLOutput_test.cpp
- NV_draw_buffers_test.cpp
- OES_sample_variables_test.cpp
- OES_standard_derivatives_test.cpp
- OES_texture_cube_map_array_test.cpp
- OVR_multiview2_test.cpp
- OVR_multiview_test.cpp
- Pack_Unpack_test.cpp
- Precise_test.cpp
- PruneEmptyCases_test.cpp
- PruneEmptyDeclarations_test.cpp
- PrunePureLiteralStatements_test.cpp
- PruneUnusedFunctions_test.cpp
- QualificationOrderESSL31_test.cpp
- QualificationOrder_test.cpp
- RecordConstantPrecision_test.cpp
- RegenerateStructNames_test.cpp
- RemoveUnreferencedVariables_test.cpp
- RewriteDoWhile_test.cpp
- SamplerMultisample_test.cpp
- SamplerVideoWEBGL_test.cpp
- ShCompile_test.cpp
- ShaderImage_test.cpp
- ShaderValidation_test.cpp
- ShaderVariable_test.cpp
- TextureFunction_test.cpp
- TypeTracking_test.cpp
- Type_test.cpp
- UnfoldShortCircuitAST_test.cpp
- UnrollFlatten_test.cpp
- VariablePacker_test.cpp
- WorkGroupSize_test.cpp
