kc3-lang/angle/src/libANGLE/renderer/vulkan

• Show log

  Commit

• Hash : fc4fc174
  Author :
  Date : 2024-12-10T22:01:28
  

  Vulkan: Prevent crash with D/S FF without D/S attachment
  
  The spec says that the values for gl_LastFragDepth/StencilARM are
  undefined if there is no depth/stencil attachment.  This "just" works on
  tiling GPUs, because reading input attachments simply translates to
  reading _something_ from the tile memory.
  
  For ANGLE, the situation is a little more complicated.  ANGLE has to
  bind descriptors for input attachments (because non-tilers read from the
  input attachment descriptor instead of using the knowledge that input
  and color/depth/stencil attachments are one and the same thing in tile
  memory).  When a depth/stencil attachment is missing, there is no image
  to bind to the descriptor set.
  
  ANGLE cannot skip binding an image to the descriptor set, because
  OpImageRead (translated from subpassLoad()) attempts to access the
  input descriptor; skipping this causes an internal crash in SwiftShader
  for example.
  
  ANGLE cannot bind a bogus image as input attachment, as Vulkan requires
  that input attachments are also color/depth/stencil attachments.
  
  ANGLE _could_ bind a bogus image as input attachment and also as
  depth/stencil attachment.  This is rather risky, as it then also has to
  be careful to make sure that depth/stencil attachment is never actually
  used (i.e. it affects the depth/stencil state, load/store ops etc).
  
  In this change, the shader itself is modified to remove references to
  the depth/stencil input attachments if the attachment is missing.  This
  is rather inefficient, as it means the pipeline warmup will not produce
  a usable pipeline, but it's accepted as a workaround for something apps
  shouldn't really be doing.
  
  Bug: angleproject:376572258
  Change-Id: I0de68252b61615cb82cba7d1730699aadf41e92f
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6085368
  Reviewed-by: Charlie Lao <cclao@google.com>
  Reviewed-by: Yuxin Hu <yuxinhu@google.com>
  Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
  

• Files

• AllocatorHelperPool.cpp
• AllocatorHelperPool.h
• AllocatorHelperRing.cpp
• AllocatorHelperRing.h
• BUILD.gn
• BufferVk.cpp
• BufferVk.h
• CLCommandQueueVk.cpp
• CLCommandQueueVk.h
• CLContextVk.cpp
• CLContextVk.h
• CLDeviceVk.cpp
• CLDeviceVk.h
• CLEventVk.cpp
• CLEventVk.h
• CLKernelVk.cpp
• CLKernelVk.h
• CLMemoryVk.cpp
• CLMemoryVk.h
• CLPlatformVk.cpp
• CLPlatformVk.h
• CLProgramVk.cpp
• CLProgramVk.h
• CLSamplerVk.cpp
• CLSamplerVk.h
• CommandProcessor.cpp
• CommandProcessor.h
• CompilerVk.cpp
• CompilerVk.h
• ContextVk.cpp
• ContextVk.h
• DebugAnnotatorVk.cpp
• DebugAnnotatorVk.h
• DeviceVk.cpp
• DeviceVk.h
• DisplayVk.cpp
• DisplayVk.h
• DisplayVk_api.h
• FenceNVVk.cpp
• FenceNVVk.h
• FramebufferVk.cpp
• FramebufferVk.h
• ImageVk.cpp
• ImageVk.h
• MemoryObjectVk.cpp
• MemoryObjectVk.h
• MemoryTracking.cpp
• MemoryTracking.h
• OWNERS
• OverlayVk.cpp
• OverlayVk.h
• PersistentCommandPool.cpp
• PersistentCommandPool.h
• ProgramExecutableVk.cpp
• ProgramExecutableVk.h
• ProgramPipelineVk.cpp
• ProgramPipelineVk.h
• ProgramVk.cpp
• ProgramVk.h
• QueryVk.cpp
• QueryVk.h
• README.md
• RenderTargetVk.cpp
• RenderTargetVk.h
• RenderbufferVk.cpp
• RenderbufferVk.h
• SamplerVk.cpp
• SamplerVk.h
• SecondaryCommandBuffer.cpp
• SecondaryCommandBuffer.h
• SecondaryCommandPool.cpp
• SecondaryCommandPool.h
• SemaphoreVk.cpp
• SemaphoreVk.h
• ShaderInterfaceVariableInfoMap.cpp
• ShaderInterfaceVariableInfoMap.h
• ShaderVk.cpp
• ShaderVk.h
• ShareGroupVk.cpp
• ShareGroupVk.h
• Suballocation.cpp
• Suballocation.h
• SurfaceVk.cpp
• SurfaceVk.h
• SyncVk.cpp
• SyncVk.h
• TextureVk.cpp
• TextureVk.h
• TransformFeedbackVk.cpp
• TransformFeedbackVk.h
• UtilsVk.cpp
• UtilsVk.h
• VertexArrayVk.cpp
• VertexArrayVk.h
• VkImageImageSiblingVk.cpp
• VkImageImageSiblingVk.h
• VulkanSecondaryCommandBuffer.cpp
• VulkanSecondaryCommandBuffer.h
• android/
• cl_types.h
• clspv_utils.cpp
• clspv_utils.h
• doc/
• fuchsia/
• gen_vk_format_table.py
• gen_vk_internal_shaders.py
• gen_vk_mandatory_format_support_table.py
• ggp/
• linux/
• mac/
• null/
• shaders/
• spv_utils.cpp
• spv_utils.h
• vk_cache_utils.cpp
• vk_cache_utils.h
• vk_caps_utils.cpp
• vk_caps_utils.h
• vk_cl_utils.cpp
• vk_cl_utils.h
• vk_command_buffer_utils.h
• vk_format_map.json
• vk_format_table_autogen.cpp
• vk_format_utils.cpp
• vk_format_utils.h
• vk_helpers.cpp
• vk_helpers.h
• vk_internal_shaders_autogen.cpp
• vk_internal_shaders_autogen.gni
• vk_internal_shaders_autogen.h
• vk_mandatory_format_support_data.json
• vk_mandatory_format_support_table_autogen.cpp
• vk_mem_alloc_wrapper.cpp
• vk_mem_alloc_wrapper.h
• vk_ref_counted_event.cpp
• vk_ref_counted_event.h
• vk_renderer.cpp
• vk_renderer.h
• vk_resource.cpp
• vk_resource.h
• vk_utils.cpp
• vk_utils.h
• vk_wrapper.h
• vulkan_backend.gni
• win32/

• Properties

• Git HTTP	https://git.kmx.io/kc3-lang/angle.git
  Git SSH	git@git.kmx.io:kc3-lang/angle.git
  Public access ?	public
  Description	A conformant OpenGL ES implementation for Windows, Mac, Linux, iOS and Android. Homepage Github
  Users
  Tags