-
Show log
Commit
-
Hash : c8db5292
Author :
Date : 2024-05-31T19:35:32
Remove locks from most glUniform* calls Note: only the Vulkan backend claims to be thread safe. glUniform1i and glUniform1iv are kept locked as they might set samplers, which is more complicated. glUniformBlockBinding is a more complex state change with notifications. Other glUniform functions simply call setUniformImpl() or setUniformMatrixfv() in the vulkan backend, which as https://crrev.com/c/5588853 and https://crrev.com/c/5592968 show only update mDefaultUniformBlocks and mDefaultUniformBlocksDirty. This should be thread-safe as long as the application is not creating race conditions itself such as by changing the same object in parallel. This should yield a significant improvement in the driver_overhead_2 benchmark which is heavy on such calls. Bug: angleproject:8666 Bug: b/335295728 Change-Id: Iad1577b9ab2eb57b6a4599ec6d70fa90eb518e8d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5588385 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
-
Files
- cl_dispatch_table.cpp
- cl_dispatch_table.h
- cl_stubs.cpp
- cl_stubs_autogen.h
- egl_context_lock_autogen.h
- egl_context_lock_impl.h
- egl_ext_stubs.cpp
- egl_ext_stubs_autogen.h
- egl_get_labeled_object_data.json
- egl_stubs.cpp
- egl_stubs_autogen.h
- entry_points_cl_autogen.cpp
- entry_points_cl_autogen.h
- entry_points_cl_utils.cpp
- entry_points_cl_utils.h
- entry_points_egl_autogen.cpp
- entry_points_egl_autogen.h
- entry_points_egl_ext_autogen.cpp
- entry_points_egl_ext_autogen.h
- entry_points_gl_1_autogen.cpp
- entry_points_gl_1_autogen.h
- entry_points_gl_2_autogen.cpp
- entry_points_gl_2_autogen.h
- entry_points_gl_3_autogen.cpp
- entry_points_gl_3_autogen.h
- entry_points_gl_4_autogen.cpp
- entry_points_gl_4_autogen.h
- entry_points_gles_1_0_autogen.cpp
- entry_points_gles_1_0_autogen.h
- entry_points_gles_2_0_autogen.cpp
- entry_points_gles_2_0_autogen.h
- entry_points_gles_3_0_autogen.cpp
- entry_points_gles_3_0_autogen.h
- entry_points_gles_3_1_autogen.cpp
- entry_points_gles_3_1_autogen.h
- entry_points_gles_3_2_autogen.cpp
- entry_points_gles_3_2_autogen.h
- entry_points_gles_ext_autogen.cpp
- entry_points_gles_ext_autogen.h
- entry_points_glx.cpp
- entry_points_glx.h
- entry_points_wgl.cpp
- entry_points_wgl.h
- global_state.cpp
- global_state.h
- libGLESv2.rc
- libGLESv2_autogen.cpp
- libGLESv2_autogen.def
- libGLESv2_no_capture_autogen.def
- libGLESv2_vulkan_secondaries_autogen.def
- libGLESv2_with_capture_autogen.def
- opengl32_autogen.def
- opengl32_with_wgl_autogen.def
- proc_table_cl.h
- proc_table_cl_autogen.cpp
- proc_table_egl.h
- proc_table_egl_autogen.cpp
- proc_table_glx.h
- proc_table_glx_autogen.cpp
- proc_table_wgl.h
- proc_table_wgl_autogen.cpp
- resource.h
