-
Show log
Commit
-
Hash : bc447ca4
Author :
Date : 2022-09-20T22:38:16
GLES1: Move lighting to vertex shader In the spec, lighting is done as part of vertex processing, and results in a new vertex color. Texturing is applied later. ANGLE however did lighting in the fragment shader. With this change, lighting is moved to the vertex shader. This fixes rendering of lit objects, as interpolation is done linearly or flat between the vertices per spec, instead of done precisely per fragment. While typically this is inferior to per-fragment lighting, it's what the spec mandates. On the dr_driving trace, this reduces the render pass time by ~20% on Pixel 6. Bug: angleproject:6201 Bug: angleproject:6644 Change-Id: I10e37df8c56c22d520a738af8f8630bc6a01ca7f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3906394 Reviewed-by: Constantine Shablya <constantine.shablya@collabora.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
-
Files
- ActiveTextureCacheTest.cpp
- AtomicCounterBufferTest.cpp
- AttributeLayoutTest.cpp
- BPTCCompressedTextureTest.cpp
- BindGeneratesResourceTest.cpp
- BindUniformLocationTest.cpp
- BlendFuncExtendedTest.cpp
- BlendIntegerTest.cpp
- BlendMinMaxTest.cpp
- BlendPackedTest.cpp
- BlitFramebufferANGLETest.cpp
- BufferDataTest.cpp
- BuiltinVariableTest.cpp
- ClearTest.cpp
- ClientArraysTest.cpp
- ClipDistanceTest.cpp
- ColorMaskTest.cpp
- CompressedTextureFormatsTest.cpp
- ComputeShaderTest.cpp
- ContextLostTest.cpp
- ContextNoErrorTest.cpp
- CopyCompressedTextureTest.cpp
- CopyTexImageTest.cpp
- CopyTexture3DTest.cpp
- CopyTextureTest.cpp
- CubeMapTextureTest.cpp
- D3D11EmulatedIndexedBufferTest.cpp
- D3D11FormatTablesTest.cpp
- D3D11InputLayoutCacheTest.cpp
- D3DImageFormatConversionTest.cpp
- D3DTextureTest.cpp
- DXT1CompressedTextureTest.cpp
- DXTSRGBCompressedTextureTest.cpp
- DXTSRGBCompressedTextureTestData.inl
- DebugMarkerTest.cpp
- DebugTest.cpp
- DepthStencilFormatsTest.cpp
- DepthStencilTest.cpp
- DesktopGLSLTest.cpp
- DifferentStencilMasksTest.cpp
- DiscardFramebufferEXTTest.cpp
- DrawBaseVertexBaseInstanceTest.cpp
- DrawBaseVertexVariantsTest.cpp
- DrawBuffersTest.cpp
- DrawElementsTest.cpp
- ETCTextureTest.cpp
- ErrorMessages.cpp
- ExternalBufferTest.cpp
- ExternalWrapTest.cpp
- FenceSyncTests.cpp
- FloatingPointSurfaceTest.cpp
- FormatPrintTest.cpp
- FragDepthTest.cpp
- FramebufferFetchTest.cpp
- FramebufferMixedSamplesTest.cpp
- FramebufferMultiviewTest.cpp
- FramebufferRenderMipmapTest.cpp
- FramebufferTest.cpp
- GLSLTest.cpp
- GeometryShaderTest.cpp
- GetImageTest.cpp
- GetTexLevelParameterTest.cpp
- ImageTest.cpp
- ImageTestMetal.mm
- IncompleteTextureTest.cpp
- IndexBufferOffsetTest.cpp
- IndexedPointsTest.cpp
- InstancingTest.cpp
- KTXCompressedTextureTest.cpp
- LineLoopTest.cpp
- LinkAndRelinkTest.cpp
- MatrixTest.cpp
- MaxTextureSizeTest.cpp
- MemoryBarrierTest.cpp
- MemoryObjectTest.cpp
- MemorySizeTest.cpp
- MipmapTest.cpp
- MultiDrawTest.cpp
- MultisampleCompatibilityTest.cpp
- MultisampleTest.cpp
- MultisampledRenderToTextureTest.cpp
- MultithreadingTest.cpp
- MultiviewDrawTest.cpp
- ObjectAllocationTest.cpp
- OcclusionQueriesTest.cpp
- PBOExtensionTest.cpp
- PackUnpackTest.cpp
- ParallelShaderCompileTest.cpp
- PbufferTest.cpp
- PixelLocalStorageTest.cpp
- PixmapTest.cpp
- PointSpritesTest.cpp
- ProgramBinaryTest.cpp
- ProgramInterfaceTest.cpp
- ProgramParameterTest.cpp
- ProgramPipelineTest.cpp
- ProvokingVertexTest.cpp
- QueryObjectValidation.cpp
- ReadOnlyFeedbackLoopTest.cpp
- ReadPixelsTest.cpp
- RenderbufferMultisampleTest.cpp
- RendererTest.cpp
- RequestExtensionTest.cpp
- RobustBufferAccessBehaviorTest.cpp
- RobustClientMemoryTest.cpp
- RobustFragmentShaderOutputTest.cpp
- RobustResourceInitTest.cpp
- S3TCTextureSizesTest.cpp
- SRGBFramebufferTest.cpp
- SRGBTextureTest.cpp
- SamplersTest.cpp
- SemaphoreTest.cpp
- ShaderInterpTest.cpp
- ShaderNonConstGlobalInitializerTest.cpp
- ShaderStorageBufferTest.cpp
- ShadingRateQcomTest.cpp
- SimpleOperationTest.cpp
- SixteenBppTextureTest.cpp
- StateChangeTest.cpp
- SwizzleTest.cpp
- SyncQueriesTest.cpp
- TextureExternalUpdateTest.cpp
- TextureFilteringHintTest.cpp
- TextureMultisampleTest.cpp
- TextureRectangleTest.cpp
- TextureTest.cpp
- TextureUploadFormatTest.cpp
- TimerQueriesTest.cpp
- TransformFeedbackTest.cpp
- UniformBufferTest.cpp
- UniformTest.cpp
- UnpackAlignmentTest.cpp
- UnpackRowLength.cpp
- VertexAttributeTest.cpp
- ViewportTest.cpp
- VulkanDescriptorSetTest.cpp
- VulkanExternalImageTest.cpp
- VulkanFormatTablesTest.cpp
- VulkanFramebufferTest.cpp
- VulkanImageTest.cpp
- VulkanMultithreadingTest.cpp
- VulkanPerformanceCounterTest.cpp
- VulkanUniformUpdatesTest.cpp
- WEBGLVideoTextureTest.cpp
- WebGLCompatibilityTest.cpp
- WebGLCompressedTextureAvailabilityTest.cpp
- WebGLFramebufferTest.cpp
- WebGLReadOutsideFramebufferTest.cpp
- gles1/
- media/
