• Show log

    Commit

  • Hash : 5ec04880
    Author : Daksh Idnani
    Date : 2019-08-22T21:12:08

    Reland "Make Mac SystemInfo reflect the currently active GPU on dual GPU machines"
    
    This reverts commit 58940f67acd5b89f1c338b134a596864595fcdca.
    
    Reason for revert: pixel test failures have been triaged in Gold. Relanding.
    
    Original change's description:
    > Revert "Make Mac SystemInfo reflect the currently active GPU on dual GPU machines"
    > 
    > This reverts commit 720a8bab0eca86e5b9b8c07c200a217fb2c65755.
    > 
    > Reason for revert: pixel test failures per http://crbug.com/984780#c13
    > 
    > Original change's description:
    > > Make Mac SystemInfo reflect the currently active GPU on dual GPU machines
    > > 
    > > Currently, the GetSystemInfo() function (in gpu_info_util/SystemInfo_mac.mm)
    > > on dual GPU Macs always updates the active GPU field of the SystemInfo
    > > instance to the first non-Intel GPU it finds. This change overrides the
    > > activeGPUIndex field of the SystemInfo instance to reflect the current GPU
    > > instead of the non-intel GPU.
    > > 
    > > Bug: 985486, 984780, angleproject:3701
    > > Change-Id: Ia93f38f4a2f7728c05e99c83a940722bd3808766
    > > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1752334
    > > Commit-Queue: Kenneth Russell <kbr@chromium.org>
    > > Reviewed-by: Zhenyao Mo <zmo@chromium.org>
    > > Reviewed-by: Kenneth Russell <kbr@chromium.org>
    > 
    > TBR=zmo@chromium.org,geofflang@chromium.org,kbr@chromium.org,dakshidnani@google.com
    > 
    > Change-Id: Iacf4b8433ac1aa4d30c51f08ddfc6489af440cc4
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Bug: 985486, 984780, angleproject:3701
    > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1757373
    > Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
    > Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
    
    Bug: 985486, 984780, angleproject:3701
    Change-Id: I8f2f26f68329a2826a92742c46471b8c092b36ed
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1765963
    Reviewed-by: Kenneth Russell <kbr@chromium.org>
    Commit-Queue: Kenneth Russell <kbr@chromium.org>
    

  • Properties

  • Git HTTP https://git.kmx.io/kc3-lang/angle.git
    Git SSH git@git.kmx.io:kc3-lang/angle.git
    Public access ? public
    Description

    A conformant OpenGL ES implementation for Windows, Mac, Linux, iOS and Android.

    Homepage

    Github

    Users
    thodg_m kc3_lang_org thodg_w www_kmx_io thodg thodg_l
    Tags