-
Show log
Commit
-
Hash : db3e5183
Author :
Date : 2019-11-14T13:47:55
Vulkan: Fix col-major transformation of unsized arrays If the row-major expression that was being transformed was in the form: arr.length() where `arr` is an SSBO unsized array, the translator transformation was attempting to transpose the `arr` expression, which is both wrong and impossible. Note that length() is removed through a prior transformation except for this particular case. This change recognizes this usage and supports it by keeping the expression as is (as the length() would be identical pre or post transformation). Bug: angleproject:3443 Change-Id: I8efacb7b12d5e53047eb56ab5d86830d81952d86 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1917422 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
-
Files
- AddAndTrueToLoopCondition.cpp
- AddAndTrueToLoopCondition.h
- AddDefaultReturnStatements.cpp
- AddDefaultReturnStatements.h
- ArrayReturnValueToOutParameter.cpp
- ArrayReturnValueToOutParameter.h
- BreakVariableAliasingInInnerLoops.cpp
- BreakVariableAliasingInInnerLoops.h
- ClampFragDepth.cpp
- ClampFragDepth.h
- ClampPointSize.cpp
- ClampPointSize.h
- DeclareAndInitBuiltinsForInstancedMultiview.cpp
- DeclareAndInitBuiltinsForInstancedMultiview.h
- DeferGlobalInitializers.cpp
- DeferGlobalInitializers.h
- EmulateGLFragColorBroadcast.cpp
- EmulateGLFragColorBroadcast.h
- EmulateMultiDrawShaderBuiltins.cpp
- EmulateMultiDrawShaderBuiltins.h
- EmulatePrecision.cpp
- EmulatePrecision.h
- ExpandIntegerPowExpressions.cpp
- ExpandIntegerPowExpressions.h
- FoldExpressions.cpp
- FoldExpressions.h
- InitializeVariables.cpp
- InitializeVariables.h
- NameEmbeddedUniformStructs.cpp
- NameEmbeddedUniformStructs.h
- NameNamelessUniformBuffers.cpp
- NameNamelessUniformBuffers.h
- PruneEmptyCases.cpp
- PruneEmptyCases.h
- PruneNoOps.cpp
- PruneNoOps.h
- RecordConstantPrecision.cpp
- RecordConstantPrecision.h
- RegenerateStructNames.cpp
- RegenerateStructNames.h
- RemoveArrayLengthMethod.cpp
- RemoveArrayLengthMethod.h
- RemoveDynamicIndexing.cpp
- RemoveDynamicIndexing.h
- RemoveInvariantDeclaration.cpp
- RemoveInvariantDeclaration.h
- RemovePow.cpp
- RemovePow.h
- RemoveSwitchFallThrough.cpp
- RemoveSwitchFallThrough.h
- RemoveUnreferencedVariables.cpp
- RemoveUnreferencedVariables.h
- RewriteAtomicCounters.cpp
- RewriteAtomicCounters.h
- RewriteAtomicFunctionExpressions.cpp
- RewriteAtomicFunctionExpressions.h
- RewriteCubeMapSamplersAs2DArray.cpp
- RewriteCubeMapSamplersAs2DArray.h
- RewriteDfdy.cpp
- RewriteDfdy.h
- RewriteDoWhile.cpp
- RewriteDoWhile.h
- RewriteElseBlocks.cpp
- RewriteElseBlocks.h
- RewriteExpressionsWithShaderStorageBlock.cpp
- RewriteExpressionsWithShaderStorageBlock.h
- RewriteRepeatedAssignToSwizzled.cpp
- RewriteRepeatedAssignToSwizzled.h
- RewriteRowMajorMatrices.cpp
- RewriteRowMajorMatrices.h
- RewriteStructSamplers.cpp
- RewriteStructSamplers.h
- RewriteStructSamplersOld.cpp
- RewriteTexelFetchOffset.cpp
- RewriteTexelFetchOffset.h
- RewriteUnaryMinusOperatorFloat.cpp
- RewriteUnaryMinusOperatorFloat.h
- RewriteUnaryMinusOperatorInt.cpp
- RewriteUnaryMinusOperatorInt.h
- ScalarizeVecAndMatConstructorArgs.cpp
- ScalarizeVecAndMatConstructorArgs.h
- SeparateArrayConstructorStatements.cpp
- SeparateArrayConstructorStatements.h
- SeparateArrayInitialization.cpp
- SeparateArrayInitialization.h
- SeparateDeclarations.cpp
- SeparateDeclarations.h
- SeparateExpressionsReturningArrays.cpp
- SeparateExpressionsReturningArrays.h
- SimplifyLoopConditions.cpp
- SimplifyLoopConditions.h
- SplitSequenceOperator.cpp
- SplitSequenceOperator.h
- UnfoldShortCircuitAST.cpp
- UnfoldShortCircuitAST.h
- UnfoldShortCircuitToIf.cpp
- UnfoldShortCircuitToIf.h
- UseInterfaceBlockFields.cpp
- UseInterfaceBlockFields.h
- VectorizeVectorScalarArithmetic.cpp
- VectorizeVectorScalarArithmetic.h
- WrapSwitchStatementsInBlocks.cpp
- WrapSwitchStatementsInBlocks.h
