kc3-lang/angle/src/compiler/translator/tree_ops/spirv/EmulateAdvancedBlendEquations.h

• Show log

  Commit

• Hash : c6fbf93d
  Author :
  Date : 2024-01-19T09:57:12
  

  Vulkan: Fix input attachments leaking into uniform list
  
  To communicate the existence of input attachments added to the shader,
  the translator was adding `ShaderVariable`s for each to the list of
  uniforms exported from the shader.  This was incorrect, as this list is
  visible to the application through `glGetActiveUniform`.  Additionally,
  this was unnecessarily causing these uniforms to go through program
  link.
  
  Reserving SPIR-V ids for these uniforms, all that is needed from the
  translator is the mere existence of these input attachments.  This
  change removes the addition of uniforms, and instead exports a bitset.
  Elsewhere, that bitset is consulted and reserved SPIR-V ids are used.
  
  Bug: b/320563594
  Bug: angleproject:5792
  Change-Id: Id93846cbc3996248f391fd2d5a65af1e48d6d46e
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5215089
  Reviewed-by: mohan maiya <m.maiya@samsung.com>
  Reviewed-by: Charlie Lao <cclao@google.com>
  Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
  

Download

• src/compiler/translator/tree_ops/spirv/EmulateAdvancedBlendEquations.h

• //
  // Copyright 2022 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  // EmulateAdvancedBlendEquations.h: Emulate advanced blend equations by implicitly reading back from
  // the color attachment (as an input attachment) and apply the equation function based on a uniform.
  //
  
  #ifndef COMPILER_TRANSLATOR_TREEOPS_SPIRV_EMULATEADVANCEDBLENDEQUATIONS_H_
  #define COMPILER_TRANSLATOR_TREEOPS_SPIRV_EMULATEADVANCEDBLENDEQUATIONS_H_
  
  #include "common/angleutils.h"
  #include "compiler/translator/Compiler.h"
  #include "compiler/translator/tree_ops/spirv/EmulateFramebufferFetch.h"
  
  namespace sh
  {
  
  class TIntermBlock;
  class TSymbolTable;
  class DriverUniform;
  class AdvancedBlendEquations;
  
  // Declares the necessary input attachment (if not already for framebuffer fetch), loads from it and
  // implements the specified advanced blend equation functions.  A driver uniform is used to select
  // which function to use at runtime.
  [[nodiscard]] bool EmulateAdvancedBlendEquations(
      TCompiler *compiler,
      TIntermBlock *root,
      TSymbolTable *symbolTable,
      const AdvancedBlendEquations &advancedBlendEquations,
      const DriverUniform *driverUniforms,
      InputAttachmentMap *inputAttachmentMapOut);
  
  }  // namespace sh
  
  #endif  // COMPILER_TRANSLATOR_TREEOPS_SPIRV_EMULATEADVANCEDBLENDEQUATIONS_H_
  

Download