Hash :
71c88b31
Author :
Date :
2017-09-14T22:20:29
Enable [[nodiscard]] for gl::Error. This forces all return values to be checked for gl::Error. Requires quite a bit of minor refactoring. I also added a macro to swallow an error without returning from a function. We could look at storing the errors in the Context at some point, since almost always when we're generating errors that we need to discard we have access to the Context as a parameter. BUG=angleproject:2150 Change-Id: I457e48a30c002eda0993acbcd3180ba87bf169fb Reviewed-on: https://chromium-review.googlesource.com/665173 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177
//
// Copyright (c) 2002-2010 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// RefCountObject.h: Defines the gl::RefCountObject base class that provides
// lifecycle support for GL objects using the traditional BindObject scheme, but
// that need to be reference counted for correct cross-context deletion.
// (Concretely, textures, buffers and renderbuffers.)
#ifndef LIBANGLE_REFCOUNTOBJECT_H_
#define LIBANGLE_REFCOUNTOBJECT_H_
#include "angle_gl.h"
#include "common/debug.h"
#include "libANGLE/Error.h"
#include <cstddef>
namespace gl
{
class Context;
class RefCountObjectNoID : angle::NonCopyable
{
public:
RefCountObjectNoID() : mRefCount(0) {}
virtual Error onDestroy(const Context *context) { return NoError(); }
void addRef() const { ++mRefCount; }
void release() const
{
ASSERT(mRefCount > 0);
if (--mRefCount == 0)
{
delete this;
}
}
size_t getRefCount() const { return mRefCount; }
protected:
virtual ~RefCountObjectNoID() { ASSERT(mRefCount == 0); }
// A specialized release method for objects which need a destroy context.
void release(const gl::Context *context)
{
ASSERT(mRefCount > 0);
if (--mRefCount == 0)
{
ANGLE_SWALLOW_ERR(onDestroy(context));
delete this;
}
}
template <class ObjectType>
friend class BindingPointer;
mutable std::size_t mRefCount;
};
template <class ObjectType>
class BindingPointer;
class RefCountObject : RefCountObjectNoID
{
public:
explicit RefCountObject(GLuint id) : mId(id) {}
GLuint id() const { return mId; }
using RefCountObjectNoID::release;
using RefCountObjectNoID::addRef;
using RefCountObjectNoID::getRefCount;
protected:
~RefCountObject() override {}
private:
GLuint mId;
};
template <class ObjectType>
class BindingPointer
{
public:
BindingPointer()
: mObject(nullptr)
{
}
BindingPointer(ObjectType *object) : mObject(object) { mObject->addRef(); }
BindingPointer(const BindingPointer<ObjectType> &other) : mObject(other.mObject)
{
mObject->addRef();
}
BindingPointer &operator=(BindingPointer<ObjectType> &&other)
{
std::swap(mObject, other.mObject);
return *this;
}
virtual ~BindingPointer()
{
// Objects have to be released before the resource manager is destroyed, so they must be explicitly cleaned up.
ASSERT(mObject == nullptr);
}
virtual void set(const Context *context, ObjectType *newObject)
{
// addRef first in case newObject == mObject and this is the last reference to it.
if (newObject != nullptr) reinterpret_cast<const RefCountObjectNoID*>(newObject)->addRef();
if (mObject != nullptr)
reinterpret_cast<RefCountObjectNoID *>(mObject)->release(context);
mObject = newObject;
}
ObjectType *get() const { return mObject; }
ObjectType *operator->() const { return mObject; }
GLuint id() const { return (mObject != nullptr) ? mObject->id() : 0; }
bool operator==(const BindingPointer<ObjectType> &other) const
{
return mObject == other.mObject;
}
bool operator!=(const BindingPointer<ObjectType> &other) const { return !(*this == other); }
private:
ObjectType *mObject;
};
template <class ObjectType>
class OffsetBindingPointer : public BindingPointer<ObjectType>
{
public:
OffsetBindingPointer() : mOffset(0), mSize(0) { }
void set(const Context *context, ObjectType *newObject) override
{
BindingPointer<ObjectType>::set(context, newObject);
mOffset = 0;
mSize = 0;
}
void set(const Context *context, ObjectType *newObject, GLintptr offset, GLsizeiptr size)
{
BindingPointer<ObjectType>::set(context, newObject);
mOffset = offset;
mSize = size;
}
GLintptr getOffset() const { return mOffset; }
GLsizeiptr getSize() const { return mSize; }
bool operator==(const OffsetBindingPointer<ObjectType> &other) const
{
return this->get() == other.get() && mOffset == other.mOffset && mSize == other.mSize;
}
bool operator!=(const OffsetBindingPointer<ObjectType> &other) const
{
return !(*this == other);
}
private:
GLintptr mOffset;
GLsizeiptr mSize;
};
} // namespace gl
#endif // LIBANGLE_REFCOUNTOBJECT_H_