-
Show log
Commit
-
Hash : 4982b903
Author :
Date : 2023-03-14T19:56:51
Revert "Vulkan: Remove inUseAndRespecifiedWithoutData from BufferVk" This reverts commit 755bfe471d23bc2aac5e78493537801dc5f90792. Reason for revert: Causing flaky on pixel 6 angleproject:8082 Original change's description: > Vulkan: Remove inUseAndRespecifiedWithoutData from BufferVk > > BufferVk::setDataWithMemoryType() has one optimization that it tries to > detect glBufferData(target, size, nullptr, usage) and if existing > storage is busy, it immediately reallocate storage. With the > optimization in previous CL (crrev.com/c/4317488), the storage reuse > logic should detect if we can reuse the storage or not. If the size > matches the existing storage's size, then there is no reason we can not > reuse existing storage. Later on when glBufferSubData or > glMapBufferRange is called, there are optimization in those calls that > will detect if we should reallocate storage or not as the further > optimization. This CL removes this check and replies on the other > optimization to handle the storage reallocate (shadowing) if necessary. > This simplifies code and also potentially avoids storage reallocation in > certain usage cases. > > This CL also fixes a test bug in > BufferDataTestES3.BufferDataWithNullFollowedByMap that was calling > glMapBufferRange with MAP_UNSYNCHRONIZED_BIT but incorrectly expecting > GL to do synchronization. > > Bug: b/271915956 > Change-Id: I7901687b3e3e262e77699f14eb8602d8a57eda3e > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4322048 > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: Charlie Lao <cclao@google.com> > Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Bug: b/271915956 Change-Id: Ie5716b609ab96b96afbe5927f20dfcf2bf5d4db6 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4338263 Auto-Submit: Charlie Lao <cclao@google.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
-
Files
- ActiveTextureCacheTest.cpp
- AtomicCounterBufferTest.cpp
- AttributeLayoutTest.cpp
- BPTCCompressedTextureTest.cpp
- BindGeneratesResourceTest.cpp
- BindUniformLocationTest.cpp
- BlendFuncExtendedTest.cpp
- BlendIntegerTest.cpp
- BlendMinMaxTest.cpp
- BlendPackedTest.cpp
- BlitFramebufferANGLETest.cpp
- BufferDataTest.cpp
- BuiltinVariableTest.cpp
- ClearTest.cpp
- ClientArraysTest.cpp
- ClipControlTest.cpp
- ClipDistanceTest.cpp
- ColorMaskTest.cpp
- CompressedTextureFormatsTest.cpp
- ComputeShaderTest.cpp
- ContextLostTest.cpp
- ContextNoErrorTest.cpp
- CopyCompressedTextureTest.cpp
- CopyTexImageTest.cpp
- CopyTexture3DTest.cpp
- CopyTextureTest.cpp
- CubeMapTextureTest.cpp
- D3D11EmulatedIndexedBufferTest.cpp
- D3D11FormatTablesTest.cpp
- D3D11InputLayoutCacheTest.cpp
- D3DImageFormatConversionTest.cpp
- D3DTextureTest.cpp
- DXT1CompressedTextureTest.cpp
- DXTSRGBCompressedTextureTest.cpp
- DXTSRGBCompressedTextureTestData.inl
- DebugMarkerTest.cpp
- DebugTest.cpp
- DepthStencilFormatsTest.cpp
- DepthStencilTest.cpp
- DesktopGLSLTest.cpp
- DifferentStencilMasksTest.cpp
- DiscardFramebufferEXTTest.cpp
- DrawBaseVertexBaseInstanceTest.cpp
- DrawBaseVertexVariantsTest.cpp
- DrawBuffersTest.cpp
- DrawElementsTest.cpp
- DrawRangeElementsTest.cpp
- EGLImageMECFriendlyTest.cpp
- ETCTextureTest.cpp
- ErrorMessages.cpp
- ExternalBufferTest.cpp
- ExternalWrapTest.cpp
- FenceSyncTests.cpp
- FloatingPointSurfaceTest.cpp
- FormatPrintTest.cpp
- FragDepthTest.cpp
- FramebufferFetchTest.cpp
- FramebufferMixedSamplesTest.cpp
- FramebufferMultiviewTest.cpp
- FramebufferRenderMipmapTest.cpp
- FramebufferTest.cpp
- GLSLTest.cpp
- GeometryShaderTest.cpp
- GetImageTest.cpp
- GetTexLevelParameterTest.cpp
- ImageTest.cpp
- ImageTestMetal.mm
- IncompleteTextureTest.cpp
- IndexBufferOffsetTest.cpp
- IndexedPointsTest.cpp
- InstancingTest.cpp
- KTXCompressedTextureTest.cpp
- LineLoopTest.cpp
- LinkAndRelinkTest.cpp
- MatrixTest.cpp
- MaxTextureSizeTest.cpp
- MemoryBarrierTest.cpp
- MemoryObjectTest.cpp
- MemorySizeTest.cpp
- MipmapTest.cpp
- MultiDrawTest.cpp
- MultisampleCompatibilityTest.cpp
- MultisampleTest.cpp
- MultisampledRenderToTextureTest.cpp
- MultithreadingTest.cpp
- MultiviewDrawTest.cpp
- ObjectAllocationTest.cpp
- OcclusionQueriesTest.cpp
- PBOExtensionTest.cpp
- PackUnpackTest.cpp
- ParallelShaderCompileTest.cpp
- PbufferTest.cpp
- PixelLocalStorageTest.cpp
- PixmapTest.cpp
- PointSpritesTest.cpp
- PolygonOffsetClampTest.cpp
- ProgramBinaryTest.cpp
- ProgramInterfaceTest.cpp
- ProgramParameterTest.cpp
- ProgramPipelineTest.cpp
- ProvokingVertexTest.cpp
- QueryObjectValidation.cpp
- ReadOnlyFeedbackLoopTest.cpp
- ReadPixelsTest.cpp
- RenderbufferMultisampleTest.cpp
- RendererTest.cpp
- RequestExtensionTest.cpp
- RobustBufferAccessBehaviorTest.cpp
- RobustClientMemoryTest.cpp
- RobustFragmentShaderOutputTest.cpp
- RobustResourceInitTest.cpp
- S3TCTextureSizesTest.cpp
- SRGBFramebufferTest.cpp
- SRGBTextureTest.cpp
- SamplersTest.cpp
- SemaphoreTest.cpp
- ShaderBinaryTest.cpp
- ShaderInterpTest.cpp
- ShaderNonConstGlobalInitializerTest.cpp
- ShaderStorageBufferTest.cpp
- ShadingRateQcomTest.cpp
- SimpleOperationTest.cpp
- SixteenBppTextureTest.cpp
- StateChangeTest.cpp
- SwizzleTest.cpp
- SyncQueriesTest.cpp
- TextureExternalUpdateTest.cpp
- TextureFilteringHintTest.cpp
- TextureMultisampleTest.cpp
- TextureRectangleTest.cpp
- TextureTest.cpp
- TextureUploadFormatTest.cpp
- TimerQueriesTest.cpp
- TransformFeedbackTest.cpp
- UniformBufferTest.cpp
- UniformTest.cpp
- UnpackAlignmentTest.cpp
- UnpackRowLength.cpp
- VertexAttributeTest.cpp
- ViewportTest.cpp
- VulkanDescriptorSetTest.cpp
- VulkanExternalImageTest.cpp
- VulkanFormatTablesTest.cpp
- VulkanFramebufferTest.cpp
- VulkanImageTest.cpp
- VulkanMultithreadingTest.cpp
- VulkanPerformanceCounterTest.cpp
- VulkanSharedFenceTest.cpp
- VulkanUniformUpdatesTest.cpp
- WEBGLVideoTextureTest.cpp
- WebGLCompatibilityTest.cpp
- WebGLCompressedTextureAvailabilityTest.cpp
- WebGLFramebufferTest.cpp
- WebGLReadOutsideFramebufferTest.cpp
- gles1/
- media/
