kc3-lang/angle/src/compiler/translator/AddAndTrueToLoopCondition.cpp

• Show log

  Commit

• Hash : 09cfac60
  Author :
  Date : 2016-09-06T17:25:16
  

  Work around For and While loop bugs on Intel Mac OSX
  
  Condition calculation in for and while loops has bug on Intel Mac. Work
  around it by converting "CONDITION" to "CONDITION && true".
  
  This CL also adds previous SH_EMULATE_ABS_INT_FUNCTION workaround to
  the ANGLE GL back-end on OSX
  
  BUG=chromium:644669
  TEST=deqp/functional/gles3/shaderloop_for/while.html
  
  Change-Id: I910f662b054f259fcb601b9938841b3a2d066840
  Reviewed-on: https://chromium-review.googlesource.com/381678
  Reviewed-by: Jamie Madill <jmadill@chromium.org>
  Commit-Queue: Qiankun Miao <qiankun.miao@intel.com>
  Commit-Queue: Corentin Wallez <cwallez@chromium.org>
  

Download

• src/compiler/translator/AddAndTrueToLoopCondition.cpp

• //
  // Copyright (c) 2016 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  
  #include "compiler/translator/AddAndTrueToLoopCondition.h"
  
  #include "compiler/translator/IntermNode.h"
  
  namespace sh
  {
  
  namespace
  {
  
  // An AST traverser that rewrites for and while loops by replacing "condition" with
  // "condition && true" to work around condition bug on Intel Mac.
  class AddAndTrueToLoopConditionTraverser : public TIntermTraverser
  {
    public:
      AddAndTrueToLoopConditionTraverser() : TIntermTraverser(true, false, false) {}
  
      bool visitLoop(Visit, TIntermLoop *loop) override
      {
          // do-while loop doesn't have this bug.
          if (loop->getType() != ELoopFor && loop->getType() != ELoopWhile)
          {
              return true;
          }
  
          // For loop may not have a condition.
          if (loop->getCondition() == nullptr)
          {
              return true;
          }
  
          // Constant true.
          TConstantUnion *trueConstant = new TConstantUnion();
          trueConstant->setBConst(true);
          TIntermTyped *trueValue = new TIntermConstantUnion(trueConstant, TType(EbtBool));
  
          // CONDITION && true.
          TIntermBinary *andOp = new TIntermBinary(EOpLogicalAnd, loop->getCondition(), trueValue);
          loop->setCondition(andOp);
  
          return true;
      }
  };
  
  }  // anonymous namespace
  
  void AddAndTrueToLoopCondition(TIntermNode *root)
  {
      AddAndTrueToLoopConditionTraverser traverser;
      root->traverse(&traverser);
  }
  
  }  // namespace sh
  

Download