kc3-lang/angle/src/libGLESv2/main.cpp

• Show log

  Commit

• Hash : 7a93437b
  Author :
  Date : 2013-12-06T18:17:48
  

  Fix initialization of thread local storage in libGLESv2.
  
  When an app would load libGLESv2.dll via LoadModule, then would call
  methods on a thread that was already created, we could creash because
  of uninitialized thread local storage.
  
  BUG=angle:488
  
  Change-Id: I9b05de462232a16d639c58ec07386b7c38a01793
  Reviewed-on: https://chromium-review.googlesource.com/179132
  Reviewed-by: Geoff Lang <geofflang@chromium.org>
  Commit-Queue: Geoff Lang <geofflang@chromium.org>
  Tested-by: Geoff Lang <geofflang@chromium.org>
  

Download

• src/libGLESv2/main.cpp

• #include "precompiled.h"
  //
  // Copyright (c) 2002-2012 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  
  // main.cpp: DLL entry point and management of thread-local data.
  
  #include "libGLESv2/main.h"
  
  #include "libGLESv2/Context.h"
  
  static DWORD currentTLS = TLS_OUT_OF_INDEXES;
  
  namespace gl
  {
  
  Current *AllocateCurrent()
  {
      Current *current = (Current*)LocalAlloc(LPTR, sizeof(Current));
  
      if (!current)
      {
          ERR("Could not allocate thread local storage.");
          return NULL;
      }
  
      ASSERT(currentTLS != TLS_OUT_OF_INDEXES);
      TlsSetValue(currentTLS, current);
  
      current->context = NULL;
      current->display = NULL;
  
      return current;
  }
  
  void DeallocateCurrent()
  {
      void *current = TlsGetValue(currentTLS);
  
      if (current)
      {
          LocalFree((HLOCAL)current);
      }
  }
  
  }
  
  extern "C" BOOL WINAPI DllMain(HINSTANCE instance, DWORD reason, LPVOID reserved)
  {
      switch (reason)
      {
        case DLL_PROCESS_ATTACH:
          {
              currentTLS = TlsAlloc();
  
              if (currentTLS == TLS_OUT_OF_INDEXES)
              {
                  return FALSE;
              }
          }
          // Fall throught to initialize index
        case DLL_THREAD_ATTACH:
          {
              gl::AllocateCurrent();
          }
          break;
        case DLL_THREAD_DETACH:
          {
              gl::DeallocateCurrent();
          }
          break;
        case DLL_PROCESS_DETACH:
          {
              gl::DeallocateCurrent();
              TlsFree(currentTLS);
          }
          break;
        default:
          break;
      }
  
      return TRUE;
  }
  
  namespace gl
  {
  
  Current *GetCurrentData()
  {
      Current *current = (Current*)TlsGetValue(currentTLS);
  
      // ANGLE issue 488: when the dll is loaded after thread initialization,
      // thread local storage (current) might not exist yet.
      return (current ? current : AllocateCurrent());
  }
  
  void makeCurrent(Context *context, egl::Display *display, egl::Surface *surface)
  {
      Current *current = GetCurrentData();
  
      current->context = context;
      current->display = display;
  
      if (context && display && surface)
      {
          context->makeCurrent(surface);
      }
  }
  
  Context *getContext()
  {
      Current *current = GetCurrentData();
  
      return current->context;
  }
  
  Context *getNonLostContext()
  {
      Context *context = getContext();
      
      if (context)
      {
          if (context->isContextLost())
          {
              gl::error(GL_OUT_OF_MEMORY);
              return NULL;
          }
          else
          {
              return context;
          }
      }
      return NULL;
  }
  
  egl::Display *getDisplay()
  {
      Current *current = GetCurrentData();
  
      return current->display;
  }
  
  // Records an error code
  void error(GLenum errorCode)
  {
      gl::Context *context = glGetCurrentContext();
  
      if (context)
      {
          switch (errorCode)
          {
            case GL_INVALID_ENUM:
              context->recordInvalidEnum();
              TRACE("\t! Error generated: invalid enum\n");
              break;
            case GL_INVALID_VALUE:
              context->recordInvalidValue();
              TRACE("\t! Error generated: invalid value\n");
              break;
            case GL_INVALID_OPERATION:
              context->recordInvalidOperation();
              TRACE("\t! Error generated: invalid operation\n");
              break;
            case GL_OUT_OF_MEMORY:
              context->recordOutOfMemory();
              TRACE("\t! Error generated: out of memory\n");
              break;
            case GL_INVALID_FRAMEBUFFER_OPERATION:
              context->recordInvalidFramebufferOperation();
              TRACE("\t! Error generated: invalid framebuffer operation\n");
              break;
            default: UNREACHABLE();
          }
      }
  }
  
  }
  
  

Download