Hash :
25390156
Author :
Date :
2025-08-21T00:13:19
Suppress unsafe buffers on a file-by-file basis in src/ [1 of N] In this CL, we suppress many files but stop short of actually enabling the warning by not removing the line from the unsafe_buffers_paths.txt file. That will happen in a follow-on CL, along with resolving any stragglers missed here. This is mostly a manual change so as to familiarize myself with the kinds of issues faced by the Angle codebase when applying buffer safety warnings. -- Re-generate affected hashes. -- Clang-format applied to all changed files. -- Add a few missing .reserve() calls to vectors as noticed. -- Fix some mismatches between file names and header comments. -- Be more consistent with header comment format (blank lines and trailing //-only lines when a filename comment adjoins license boilerplate). Bug: b/436880895 Change-Id: I3bde5cc2059acbe8345057289214f1a26f1c34aa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6869022 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272
//
// Copyright 2021 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// CLKernel.cpp: Implements the cl::Kernel class.
//
#ifdef UNSAFE_BUFFERS_BUILD
# pragma allow_unsafe_libc_calls
#endif
#include "libANGLE/CLKernel.h"
#include "libANGLE/CLContext.h"
#include "libANGLE/CLProgram.h"
#include "libANGLE/cl_utils.h"
#include <cstring>
namespace cl
{
angle::Result Kernel::setArg(cl_uint argIndex, size_t argSize, const void *argValue)
{
ANGLE_TRY(mImpl->setArg(argIndex, argSize, argValue));
mSetArguments[argIndex] = {true, argIndex, argSize, argValue};
return angle::Result::Continue;
}
angle::Result Kernel::getInfo(KernelInfo name,
size_t valueSize,
void *value,
size_t *valueSizeRet) const
{
cl_uint valUInt = 0u;
void *valPointer = nullptr;
const void *copyValue = nullptr;
size_t copySize = 0u;
switch (name)
{
case KernelInfo::FunctionName:
copyValue = mInfo.functionName.c_str();
copySize = mInfo.functionName.length() + 1u;
break;
case KernelInfo::NumArgs:
copyValue = &mInfo.numArgs;
copySize = sizeof(mInfo.numArgs);
break;
case KernelInfo::ReferenceCount:
valUInt = getRefCount();
copyValue = &valUInt;
copySize = sizeof(valUInt);
break;
case KernelInfo::Context:
valPointer = mProgram->getContext().getNative();
copyValue = &valPointer;
copySize = sizeof(valPointer);
break;
case KernelInfo::Program:
valPointer = mProgram->getNative();
copyValue = &valPointer;
copySize = sizeof(valPointer);
break;
case KernelInfo::Attributes:
copyValue = mInfo.attributes.c_str();
copySize = mInfo.attributes.length() + 1u;
break;
default:
ANGLE_CL_RETURN_ERROR(CL_INVALID_VALUE);
}
if (value != nullptr)
{
// CL_INVALID_VALUE if size in bytes specified by param_value_size is < size of return type
// as described in the Kernel Object Queries table and param_value is not NULL.
if (valueSize < copySize)
{
ANGLE_CL_RETURN_ERROR(CL_INVALID_VALUE);
}
if (copyValue != nullptr)
{
std::memcpy(value, copyValue, copySize);
}
}
if (valueSizeRet != nullptr)
{
*valueSizeRet = copySize;
}
return angle::Result::Continue;
}
angle::Result Kernel::getWorkGroupInfo(cl_device_id device,
KernelWorkGroupInfo name,
size_t valueSize,
void *value,
size_t *valueSizeRet) const
{
size_t index = 0u;
if (device != nullptr)
{
const DevicePtrs &devices = mProgram->getContext().getDevices();
while (index < devices.size() && devices[index] != device)
{
++index;
}
if (index == devices.size())
{
ANGLE_CL_RETURN_ERROR(CL_INVALID_DEVICE);
}
}
const rx::CLKernelImpl::WorkGroupInfo &info = mInfo.workGroups[index];
const void *copyValue = nullptr;
size_t copySize = 0u;
switch (name)
{
case KernelWorkGroupInfo::GlobalWorkSize:
copyValue = &info.globalWorkSize;
copySize = sizeof(info.globalWorkSize);
break;
case KernelWorkGroupInfo::WorkGroupSize:
copyValue = &info.workGroupSize;
copySize = sizeof(info.workGroupSize);
break;
case KernelWorkGroupInfo::CompileWorkGroupSize:
copyValue = &info.compileWorkGroupSize;
copySize = sizeof(info.compileWorkGroupSize);
break;
case KernelWorkGroupInfo::LocalMemSize:
copyValue = &info.localMemSize;
copySize = sizeof(info.localMemSize);
break;
case KernelWorkGroupInfo::PreferredWorkGroupSizeMultiple:
copyValue = &info.prefWorkGroupSizeMultiple;
copySize = sizeof(info.prefWorkGroupSizeMultiple);
break;
case KernelWorkGroupInfo::PrivateMemSize:
copyValue = &info.privateMemSize;
copySize = sizeof(info.privateMemSize);
break;
default:
ANGLE_CL_RETURN_ERROR(CL_INVALID_VALUE);
}
if (value != nullptr)
{
// CL_INVALID_VALUE if size in bytes specified by param_value_size is < size of return type
// as described in the Kernel Object Device Queries table and param_value is not NULL.
if (valueSize < copySize)
{
ANGLE_CL_RETURN_ERROR(CL_INVALID_VALUE);
}
if (copyValue != nullptr)
{
std::memcpy(value, copyValue, copySize);
}
}
if (valueSizeRet != nullptr)
{
*valueSizeRet = copySize;
}
return angle::Result::Continue;
}
angle::Result Kernel::getArgInfo(cl_uint argIndex,
KernelArgInfo name,
size_t valueSize,
void *value,
size_t *valueSizeRet) const
{
const rx::CLKernelImpl::ArgInfo &info = mInfo.args[argIndex];
const void *copyValue = nullptr;
size_t copySize = 0u;
switch (name)
{
case KernelArgInfo::AddressQualifier:
copyValue = &info.addressQualifier;
copySize = sizeof(info.addressQualifier);
break;
case KernelArgInfo::AccessQualifier:
copyValue = &info.accessQualifier;
copySize = sizeof(info.accessQualifier);
break;
case KernelArgInfo::TypeName:
copyValue = info.typeName.c_str();
copySize = info.typeName.length() + 1u;
break;
case KernelArgInfo::TypeQualifier:
copyValue = &info.typeQualifier;
copySize = sizeof(info.typeQualifier);
break;
case KernelArgInfo::Name:
copyValue = info.name.c_str();
copySize = info.name.length() + 1u;
break;
default:
ANGLE_CL_RETURN_ERROR(CL_INVALID_VALUE);
}
if (value != nullptr)
{
// CL_INVALID_VALUE if size in bytes specified by param_value size is < size of return type
// as described in the Kernel Argument Queries table and param_value is not NULL.
if (valueSize < copySize)
{
ANGLE_CL_RETURN_ERROR(CL_INVALID_VALUE);
}
if (copyValue != nullptr)
{
std::memcpy(value, copyValue, copySize);
}
}
if (valueSizeRet != nullptr)
{
*valueSizeRet = copySize;
}
return angle::Result::Continue;
}
Kernel *Kernel::clone() const
{
cl_kernel kernel = mProgram->createKernel(getName().c_str());
for (KernelArg arg : mSetArguments)
{
if (arg.isSet && IsError(kernel->cast<Kernel>().setArg(arg.index, arg.size, arg.valuePtr)))
{
ANGLE_CL_SET_ERROR(CL_OUT_OF_RESOURCES);
return nullptr;
}
}
return &kernel->cast<Kernel>();
}
Kernel::~Kernel()
{
--mProgram->mNumAttachedKernels;
}
Kernel::Kernel(Program &program, const char *name) : mProgram(&program), mImpl(nullptr)
{
if (!IsError(program.getImpl().createKernel(*this, name, &mImpl)))
{
initImpl();
}
}
Kernel::Kernel(Program &program, const rx::CLKernelImpl::CreateFunc &createFunc)
: mProgram(&program), mImpl(createFunc(*this))
{
if (mImpl)
{
initImpl();
}
}
void Kernel::initImpl()
{
ANGLE_CL_IMPL_TRY(mImpl->createInfo(&mInfo));
mSetArguments.resize(mInfo.numArgs);
std::fill(mSetArguments.begin(), mSetArguments.end(), KernelArg{false, 0, 0, 0});
++mProgram->mNumAttachedKernels;
}
} // namespace cl