kc3-lang/angle/src/libANGLE/Platform.cpp

• Show log

  Commit

• Hash : 25390156
  Author :
  Date : 2025-08-21T00:13:19
  

  Suppress unsafe buffers on a file-by-file basis in src/ [1 of N]
  
  In this CL, we suppress many files but stop short of actually
  enabling the warning by not removing the line from the
  unsafe_buffers_paths.txt file. That will happen in a follow-on
  CL, along with resolving any stragglers missed here.
  
  This is mostly a manual change so as to familiarize myself with
  the kinds of issues faced by the Angle codebase when applying buffer
  safety warnings.
  
  -- Re-generate affected hashes.
  -- Clang-format applied to all changed files.
  -- Add a few missing .reserve() calls to vectors as noticed.
  -- Fix some mismatches between file names and header comments.
  -- Be more consistent with header comment format (blank lines and
     trailing //-only lines when a filename comment adjoins license
     boilerplate).
  
  Bug: b/436880895
  Change-Id: I3bde5cc2059acbe8345057289214f1a26f1c34aa
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6869022
  Reviewed-by: Geoff Lang <geofflang@chromium.org>
  Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
  Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
  

Download

• src/libANGLE/Platform.cpp

• //
  // Copyright 2015 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  
  // Platform.cpp: Implementation methods for angle::Platform.
  
  #ifdef UNSAFE_BUFFERS_BUILD
  #    pragma allow_unsafe_buffers
  #endif
  
  #include <platform/PlatformMethods.h>
  
  #include <cstring>
  
  #include "common/debug.h"
  
  namespace
  {
  // TODO(jmadill): Make methods owned by egl::Display.
  angle::PlatformMethods &PlatformMethods()
  {
      static angle::PlatformMethods platformMethods;
      return platformMethods;
  }
  }  // anonymous namespace
  
  angle::PlatformMethods *ANGLEPlatformCurrent()
  {
      return &PlatformMethods();
  }
  
  bool ANGLE_APIENTRY ANGLEGetDisplayPlatform(angle::EGLDisplayType display,
                                              const char *const methodNames[],
                                              unsigned int methodNameCount,
                                              void *context,
                                              void *platformMethods)
  {
      angle::PlatformMethods **platformMethodsOut =
          reinterpret_cast<angle::PlatformMethods **>(platformMethods);
  
      // We allow for a lower input count of impl platform methods if the subset is correct.
      if (methodNameCount > angle::g_NumPlatformMethods)
      {
          ERR() << "Invalid platform method count: " << methodNameCount << ", expected "
                << angle::g_NumPlatformMethods << ".";
          return false;
      }
  
      for (unsigned int nameIndex = 0; nameIndex < methodNameCount; ++nameIndex)
      {
          const char *expectedName = angle::g_PlatformMethodNames[nameIndex];
          const char *actualName   = methodNames[nameIndex];
  
          // Skip deprecated methods.  The names of these methods start with |placeholder|.
          constexpr char kPlaceholder[] = "placeholder";
          if (strncmp(expectedName, kPlaceholder, sizeof(kPlaceholder) - 1) == 0)
          {
              continue;
          }
          if (strcmp(expectedName, actualName) != 0)
          {
              ERR() << "Invalid platform method name: " << actualName << ", expected " << expectedName
                    << ".";
              return false;
          }
      }
  
      // TODO(jmadill): Store platform methods in display.
      PlatformMethods().context = context;
      *platformMethodsOut       = &PlatformMethods();
      return true;
  }
  
  void ANGLE_APIENTRY ANGLEResetDisplayPlatform(angle::EGLDisplayType display)
  {
      // TODO(jmadill): Store platform methods in display.
      PlatformMethods() = angle::PlatformMethods();
  }
  

Download