kc3-lang/angle/src/tests/test_utils/ShaderExtensionTest.h

• Show log

  Commit

• Hash : 32f209b8
  Author :
  Date : 2023-11-03T09:57:00
  

  Vulkan: Fix __samplerExternal2DY2YEXTtnd combined with swizzle
  
  Pixel camera app is hitting assertion due to swizzle applied to swizzle.
  This CL adds ReswizzleYUVOpsTraverser::visitSwizzle() method and detects
  there is a swizzle on YUV sampler and apply YUV swizzle first and then
  original swizzle and then fold two swizzle into one.
  
  This CL added a test to reproduce the bug.
  
  This CL also makes ShCompileOptions in ShaderExtensionTest class a class
  member instead of local variable so that subclass can modify for testing
  or debugging purpose.
  
  Bug: b/309480316
  Change-Id: I72353fbad8dcacd77ca17a9f44e84485f4656a34
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5001614
  Reviewed-by: Chris Forbes <chrisforbes@google.com>
  Commit-Queue: Charlie Lao <cclao@google.com>
  Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
  

Download

• src/tests/test_utils/ShaderExtensionTest.h

• //
  // Copyright 2018 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  // ShaderExtensionTest.cpp:
  //   Utilities for testing that GLSL extension pragma and changing the extension flag in compiler
  //   resources has the correct effect.
  //
  
  #include "GLSLANG/ShaderLang.h"
  #include "angle_gl.h"
  #include "gtest/gtest.h"
  
  using testing::Combine;
  using testing::make_tuple;
  using testing::Values;
  
  namespace sh
  {
  
  const char ESSLVersion100[] = "#version 100\n";
  const char ESSLVersion300[] = "#version 300 es\n";
  const char ESSLVersion310[] = "#version 310 es\n";
  
  class ShaderExtensionTest
      : public testing::TestWithParam<testing::tuple<ShShaderSpec, const char *, const char *>>
  {
    protected:
      void SetUp() override
      {
          sh::InitBuiltInResources(&mResources);
          mCompiler                  = nullptr;
          mCompileOptions            = {};
          mCompileOptions.objectCode = true;
      }
  
      void TearDown() override { DestroyCompiler(); }
      void DestroyCompiler()
      {
          if (mCompiler)
          {
              sh::Destruct(mCompiler);
              mCompiler = nullptr;
          }
      }
  
      void InitializeCompiler()
      {
          DestroyCompiler();
          mCompiler = sh::ConstructCompiler(GL_FRAGMENT_SHADER, testing::get<0>(GetParam()),
                                            SH_GLSL_COMPATIBILITY_OUTPUT, &mResources);
          ASSERT_TRUE(mCompiler != nullptr) << "Compiler could not be constructed.";
      }
  
      testing::AssertionResult TestShaderCompile(const char *pragma)
      {
          return TestShaderCompile(testing::get<1>(GetParam()),  // Version.
                                   pragma,
                                   testing::get<2>(GetParam())  // Shader.
          );
      }
  
      testing::AssertionResult TestShaderCompile(const char *version,
                                                 const char *pragma,
                                                 const char *shader)
      {
          const char *shaderStrings[] = {version, pragma, shader};
          bool success                = sh::Compile(mCompiler, shaderStrings, 3, mCompileOptions);
          if (success)
          {
              return ::testing::AssertionSuccess() << "Compilation success";
          }
          return ::testing::AssertionFailure() << sh::GetInfoLog(mCompiler);
      }
  
    protected:
      ShBuiltInResources mResources;
      ShHandle mCompiler;
      ShCompileOptions mCompileOptions;
  };
  
  }  // namespace sh
  

Download