-
Show log
Commit
-
Hash : fc189386
Author :
Date : 2021-04-08T21:51:46
Revert "Fix multithreaded crash on draw commands on D3D11 backend." This reverts commit 8b9889bf62272fea2495331b622bde1f7c781bd0. Reason for revert: Breaks CI Original change's description: > Fix multithreaded crash on draw commands on D3D11 backend. > > A crash can occur if thread A is executing eglDestroyContext while > thread B issues a draw call, if the threads are interleaved in such a > manner that a makeCurrent occurs without triggering a change to the > global context and a dirtyAllState call. We handle that case by > explicitly making current the proper contexts in the eglDestroyContext > call. > > A test has been added that triggers a crash without this fix when > running on the D3D11 backend. In addition, all of MultithreadingTest > is enabled for the D3D11 backend. > > Test: Ran MultithreadingTest. Test exhibits a crash before this > change, and does not after this change. Also ran: > dEQP-EGL.functional.sharing.gles2.multithread.* > dEQP-EGL.functional.multithread.* > > Bug: b/183756357 > Change-Id: Ic6f76a062868b2f3b4e60d29dc087ec180bfb7cd > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2798591 > Reviewed-by: Geoff Lang <geofflang@chromium.org> > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Doug Horn <doughorn@google.com> Bug: b/183756357 Change-Id: I2e9d6385576330f84623d7dafbf690642fcb441f No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2815242 Commit-Queue: Doug Horn <doughorn@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
-
Files
- egl_ext_stubs.cpp
- egl_ext_stubs_autogen.h
- egl_get_labeled_object_data.json
- egl_stubs.cpp
- egl_stubs_autogen.h
- entry_points_egl_autogen.cpp
- entry_points_egl_autogen.h
- entry_points_egl_ext_autogen.cpp
- entry_points_egl_ext_autogen.h
- entry_points_gles_1_0_autogen.cpp
- entry_points_gles_1_0_autogen.h
- entry_points_gles_2_0_autogen.cpp
- entry_points_gles_2_0_autogen.h
- entry_points_gles_3_0_autogen.cpp
- entry_points_gles_3_0_autogen.h
- entry_points_gles_3_1_autogen.cpp
- entry_points_gles_3_1_autogen.h
- entry_points_gles_3_2_autogen.cpp
- entry_points_gles_3_2_autogen.h
- entry_points_gles_ext_autogen.cpp
- entry_points_gles_ext_autogen.h
- global_state.cpp
- global_state.h
- libGLESv2.rc
- libGLESv2_autogen.cpp
- libGLESv2_autogen.def
- libGLESv2_no_capture_autogen.def
- libGLESv2_with_capture_autogen.def
- proc_table_egl.h
- proc_table_egl_autogen.cpp
- resource.h
