kc3-lang/angle/src/compiler/translator/tree_util/SpecializationConstant.cpp

• Show log

  Commit

• Hash : 6f80f0f0
  Author :
  Date : 2022-08-06T02:29:19
  

  Translator: Clean up the compile flag passing interface
  
  Historically, compile flags were sent to the translator as a bitmask.
  Recently, we were getting close to running out of bits.  Additionally,
  direct-to-metal work had started to introduce constants to be passed to
  the translator, which were misplaced in ShBuiltInResources and Caps.
  Recent work on Pixel Local Storage adds even more constants, aggravating
  the situation.
  
  In this change, the interface to passing compile flags is reworked.  A
  struct is passed (instead of a bitmask) that has one bit for each flag.
  This can be indefinitely extended.  Additionally, the constants needed
  by metal and PLS are also placed in this struct.  In turn, the backends
  can set these options directly, and don't have to hack them into Caps to
  further get hacked into ShBuiltInResources.
  
  Bug: angleproject:7559
  Change-Id: If93f1e1b8818ad3a0ac708ab04ab93b4b397d114
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3812562
  Reviewed-by: Geoff Lang <geofflang@chromium.org>
  Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
  Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
  Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
  

Download

• src/compiler/translator/tree_util/SpecializationConstant.cpp

• //
  // Copyright 2020 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  // SpecializationConst.cpp: Add code to generate AST node for various specialization constants.
  //
  
  #include "compiler/translator/tree_util/SpecializationConstant.h"
  #include "common/PackedEnums.h"
  #include "common/angleutils.h"
  #include "compiler/translator/StaticType.h"
  #include "compiler/translator/SymbolTable.h"
  #include "compiler/translator/tree_util/IntermNode_util.h"
  
  namespace sh
  {
  
  namespace
  {
  // Specialization constant names
  constexpr ImmutableString kSurfaceRotationSpecConstVarName =
      ImmutableString("ANGLESurfaceRotation");
  constexpr ImmutableString kDitherSpecConstVarName = ImmutableString("ANGLEDither");
  
  const TType *MakeSpecConst(const TType &type, vk::SpecializationConstantId id)
  {
      // Create a new type with the EvqSpecConst qualifier
      TType *specConstType = new TType(type);
      specConstType->setQualifier(EvqSpecConst);
  
      // Set the constant_id of the spec const
      TLayoutQualifier layoutQualifier = TLayoutQualifier::Create();
      layoutQualifier.location         = static_cast<int>(id);
      specConstType->setLayoutQualifier(layoutQualifier);
  
      return specConstType;
  }
  }  // anonymous namespace
  
  SpecConst::SpecConst(TSymbolTable *symbolTable,
                       const ShCompileOptions &compileOptions,
                       GLenum shaderType)
      : mSymbolTable(symbolTable),
        mCompileOptions(compileOptions),
        mSurfaceRotationVar(nullptr),
        mDitherVar(nullptr)
  {
      if (shaderType == GL_FRAGMENT_SHADER || shaderType == GL_COMPUTE_SHADER)
      {
          return;
      }
  
      // Mark SpecConstUsage::Rotation unconditionally.  gl_Position is always rotated.
      if (mCompileOptions.useSpecializationConstant)
      {
          mUsageBits.set(vk::SpecConstUsage::Rotation);
      }
  }
  
  SpecConst::~SpecConst() {}
  
  void SpecConst::declareSpecConsts(TIntermBlock *root)
  {
      // Add specialization constant declarations.  The default value of the specialization
      // constant is irrelevant, as it will be set when creating the pipeline.
      // Only emit specialized const declaration if it has been referenced.
      if (mSurfaceRotationVar != nullptr)
      {
          TIntermDeclaration *decl = new TIntermDeclaration();
          decl->appendDeclarator(
              new TIntermBinary(EOpInitialize, getRotation(), CreateBoolNode(false)));
  
          root->insertStatement(0, decl);
      }
  
      if (mDitherVar != nullptr)
      {
          TIntermDeclaration *decl = new TIntermDeclaration();
          decl->appendDeclarator(new TIntermBinary(EOpInitialize, getDither(), CreateUIntNode(0)));
  
          root->insertStatement(0, decl);
      }
  }
  
  TIntermSymbol *SpecConst::getRotation()
  {
      if (mSurfaceRotationVar == nullptr)
      {
          const TType *type = MakeSpecConst(*StaticType::GetBasic<EbtBool, EbpUndefined>(),
                                            vk::SpecializationConstantId::SurfaceRotation);
  
          mSurfaceRotationVar = new TVariable(mSymbolTable, kSurfaceRotationSpecConstVarName, type,
                                              SymbolType::AngleInternal);
      }
      return new TIntermSymbol(mSurfaceRotationVar);
  }
  
  TIntermTyped *SpecConst::getSwapXY()
  {
      if (!mCompileOptions.useSpecializationConstant)
      {
          return nullptr;
      }
      mUsageBits.set(vk::SpecConstUsage::Rotation);
      return getRotation();
  }
  
  TIntermTyped *SpecConst::getDither()
  {
      if (mDitherVar == nullptr)
      {
          const TType *type = MakeSpecConst(*StaticType::GetBasic<EbtUInt, EbpHigh>(),
                                            vk::SpecializationConstantId::Dither);
  
          mDitherVar =
              new TVariable(mSymbolTable, kDitherSpecConstVarName, type, SymbolType::AngleInternal);
          mUsageBits.set(vk::SpecConstUsage::Dither);
      }
      return new TIntermSymbol(mDitherVar);
  }
  }  // namespace sh
  

Download