-
Show log
Commit
-
Hash : 7ad48b84
Author :
Date : 2022-05-26T00:23:35
Revert "Add Vulkan backend support for texture labels" This reverts commit 1afb80587e302e2ce9a901a69fd66e5ef98a73b6. Reason for revert: Null-dereference crash starting here: https://ci.chromium.org/ui/p/chromium/builders/ci/mac-swangle-chromium-x64/26323/blamelist (see angle blamelist) Crash reason: EXC_BAD_ACCESS / KERN_INVALID_ADDRESS Crash address: 0x0 Process uptime: 24 seconds Thread 0 (crashed) 0 0x0 rax = 0x0000011c0113c000 rdx = 0x0000011c09094590 rcx = 0x0000000000000006 rbx = 0x0000011c0e2a0000 rsi = 0x00007ffedfc11500 rdi = 0x0000011c01378010 rbp = 0x00007ffedfc11540 rsp = 0x00007ffedfc114f8 r8 = 0x0000000000000006 r9 = 0x0000000123a6ccc4 r10 = 0x0000011c011018d0 r11 = 0x00007ffdbc1a4834 r12 = 0x0000000000000006 r13 = 0x0000011c090944b0 r14 = 0x0000011c0e34c000 r15 = 0x00007ffedfc11550 rip = 0x0000000000000000 Found by: given as instruction pointer in context 1 libGLESv2.dylib!gl::Context::objectLabel(unsigned int, unsigned int, int, char const*) + 0x156 rbp = 0x00007ffedfc116a0 rsp = 0x00007ffedfc11550 rip = 0x00000001357b38e6 Found by: previous frame's frame pointer 2 libGLESv2.dylib!_GL_ObjectLabelKHR + 0xa5 rbp = 0x00007ffedfc116f0 rsp = 0x00007ffedfc116b0 rip = 0x000000013578e7e5 Found by: previous frame's frame pointer 3 Chromium Framework!gpu::gles2::GLES2DecoderPassthroughImpl::DoBindTexture(unsigned int, unsigned int) + 0x1ea rbp = 0x00007ffedfc11780 rsp = 0x00007ffedfc11700 rip = 0x000000011e7dcd4a Found by: previous frame's frame pointer Original change's description: > Add Vulkan backend support for texture labels > > Add onLableUpdate support for textures in the Vulkan backend. > > Bug: b/229105865 > Change-Id: Id9e5b2b81352e97b7843a63f27709739005dc2f3 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3645854 > Reviewed-by: Ian Elliott <ianelliott@google.com> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Ian Elliott <ianelliott@google.com> Bug: b/229105865 Change-Id: I5a5e00084e1320a486c43fec9d41b9ae6cb2b1db Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3669657 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Kai Ninomiya <kainino@chromium.org>
-
Files
- BUILD.gn
- BufferVk.cpp
- BufferVk.h
- CLCommandQueueVk.cpp
- CLCommandQueueVk.h
- CLContextVk.cpp
- CLContextVk.h
- CLDeviceVk.cpp
- CLDeviceVk.h
- CLEventVk.cpp
- CLEventVk.h
- CLKernelVk.cpp
- CLKernelVk.h
- CLMemoryVk.cpp
- CLMemoryVk.h
- CLPlatformVk.cpp
- CLPlatformVk.h
- CLProgramVk.cpp
- CLProgramVk.h
- CLSamplerVk.cpp
- CLSamplerVk.h
- CommandProcessor.cpp
- CommandProcessor.h
- CompilerVk.cpp
- CompilerVk.h
- ContextVk.cpp
- ContextVk.h
- DebugAnnotatorVk.cpp
- DebugAnnotatorVk.h
- DeviceVk.cpp
- DeviceVk.h
- DisplayVk.cpp
- DisplayVk.h
- DisplayVk_api.h
- FenceNVVk.cpp
- FenceNVVk.h
- FramebufferVk.cpp
- FramebufferVk.h
- GlslangWrapperVk.cpp
- GlslangWrapperVk.h
- ImageVk.cpp
- ImageVk.h
- MemoryObjectVk.cpp
- MemoryObjectVk.h
- OWNERS
- OverlayVk.cpp
- OverlayVk.h
- PersistentCommandPool.cpp
- PersistentCommandPool.h
- ProgramExecutableVk.cpp
- ProgramExecutableVk.h
- ProgramPipelineVk.cpp
- ProgramPipelineVk.h
- ProgramVk.cpp
- ProgramVk.h
- QueryVk.cpp
- QueryVk.h
- README.md
- RenderTargetVk.cpp
- RenderTargetVk.h
- RenderbufferVk.cpp
- RenderbufferVk.h
- RendererVk.cpp
- RendererVk.h
- ResourceVk.cpp
- ResourceVk.h
- SamplerVk.cpp
- SamplerVk.h
- SecondaryCommandBuffer.cpp
- SecondaryCommandBuffer.h
- SemaphoreVk.cpp
- SemaphoreVk.h
- ShaderVk.cpp
- ShaderVk.h
- SurfaceVk.cpp
- SurfaceVk.h
- SyncVk.cpp
- SyncVk.h
- TextureVk.cpp
- TextureVk.h
- TransformFeedbackVk.cpp
- TransformFeedbackVk.h
- UtilsVk.cpp
- UtilsVk.h
- VertexArrayVk.cpp
- VertexArrayVk.h
- VkImageImageSiblingVk.cpp
- VkImageImageSiblingVk.h
- VulkanSecondaryCommandBuffer.cpp
- VulkanSecondaryCommandBuffer.h
- android/
- cl_types.h
- doc/
- fuchsia/
- gen_vk_format_table.py
- gen_vk_internal_shaders.py
- gen_vk_mandatory_format_support_table.py
- ggp/
- linux/
- mac/
- null/
- shaders/
- vk_cache_utils.cpp
- vk_cache_utils.h
- vk_caps_utils.cpp
- vk_caps_utils.h
- vk_command_buffer_utils.h
- vk_format_map.json
- vk_format_table_autogen.cpp
- vk_format_utils.cpp
- vk_format_utils.h
- vk_helpers.cpp
- vk_helpers.h
- vk_internal_shaders_autogen.cpp
- vk_internal_shaders_autogen.gni
- vk_internal_shaders_autogen.h
- vk_mandatory_format_support_data.json
- vk_mandatory_format_support_table_autogen.cpp
- vk_mem_alloc_wrapper.cpp
- vk_mem_alloc_wrapper.h
- vk_utils.cpp
- vk_utils.h
- vk_wrapper.h
- win32/
-
README.md
-
ANGLE: Vulkan Back-end
ANGLE’s Vulkan back-end implementation lives in this folder.
Vulkan is an explicit graphics API. It has a lot in common with other explicit APIs such as Microsoft’s D3D12 and Apple’s Metal. Compared to APIs like OpenGL or D3D11 explicit APIs can offer a number of significant benefits:
- Lower API call CPU overhead.
- A smaller API surface with more direct hardware control.
- Better support for multi-core programming.
- Vulkan in particular has open-source tooling and tests.
Back-end Design
The
RendererVkclass represents anEGLDisplay.RendererVkowns shared global resources like the VkDevice, VkQueue, the Vulkan format tables and internal Vulkan shaders. The ContextVk class implements the back-end of a front-end OpenGL Context. ContextVk processes state changes and handles action commands likeglDrawArraysandglDrawElements.Command recording
The back-end records commands into command buffers via the following
ContextVkAPIs:-
beginNewRenderPass: Writes out (aka flushes) prior pending commands into a primary command buffer, then starts a new render pass. Returns a secondary command buffer inside a render pass instance. -
getOutsideRenderPassCommandBuffer: May flush prior command buffers and close the render pass if necessary, in addition to issuing the appropriate barriers. Returns a secondary command buffer outside a render pass instance. -
getStartedRenderPassCommands: Returns a reference to the currently open render pass’ commands buffer.
The back-end (mostly) records Image and Buffer barriers through additional
CommandBufferAccessAPIs, the result of which is passed togetOutsideRenderPassCommandBuffer. Note that the barriers are not actually recorded untilgetOutsideRenderPassCommandBufferis called:-
onBufferTransferReadandonBufferComputeShaderReadaccumulateVkBufferread barriers. -
onBufferTransferWriteandonBufferComputeShaderWriteaccumulateVkBufferwrite barriers. -
onBuffferSelfCopyis a special case forVkBufferself copies. It behaves the same as write. -
onImageTransferReadandonImageComputerShadeReadaccumulateVkImageread barriers. -
onImageTransferWriteandonImageComputerShadeWriteaccumulateVkImagewrite barriers. -
onImageRenderPassReadandonImageRenderPassWriteaccumulateVkImagebarriers inside a started RenderPass.
After the back-end records commands to the primary buffer and we flush (e.g. on swap) or when we call
ContextVk::finishToSerial, ANGLE submits the primary command buffer to aVkQueue.See the code for more details.
Simple command recording example
In this example we’ll be recording a buffer copy command:
// Ensure that ANGLE sets proper read and write barriers for the Buffers. vk::CommandBufferAccess access; access.onBufferTransferWrite(dstBuffer); access.onBufferTransferRead(srcBuffer); // Get a pointer to a secondary command buffer for command recording. vk::OutsideRenderPassCommandBuffer *commandBuffer; ANGLE_TRY(contextVk->getOutsideRenderPassCommandBuffer(access, &commandBuffer)); // Record the copy command into the secondary buffer. We're done! commandBuffer->copyBuffer(srcBuffer->getBuffer(), dstBuffer->getBuffer(), copyCount, copies);Additional Reading
More implementation details can be found in the
docdirectory: