-
Show log
Commit
-
Hash : b3b177d7
Author :
Date : 2018-03-09T16:37:22
Update driver constants on program change. Comes with a new SamplerMetadataUpdateOnSetProgram test. This is a fix for a graphics problem we've been seeing for a while with WebRender+Angle on Nvidia/Windows. The sampler metadata doesn't get updated properly for some of the draw calls, since it's not invalidated on program change (this is what the CL is fixing). Extra entries get filled with garbage data because the constant buffer is updated with `MAP_WRITE_DISCARD`, and only those samplers are updated that the current program has. This may generally occur undetected, if not for our `textureSize` calls that appear to go the NV-specific Angle workaround path that ignores our `baseLevel = 0` and instead picks the one from the driver constants (which contains garbage), leading to either zeroes returned or even crashing the driver sometimes... BUG=angleproject:2399 Change-Id: Ie2bef32184e2305c7255299933b899eb3fffb7ab Reviewed-on: https://chromium-review.googlesource.com/949412 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
-
Files
- BufferImpl.h
- BufferImpl_mock.h
- CompilerImpl.h
- ContextImpl.cpp
- ContextImpl.h
- DeviceImpl.cpp
- DeviceImpl.h
- DisplayImpl.cpp
- DisplayImpl.h
- EGLImplFactory.h
- FenceNVImpl.h
- Format.h
- Format_ID_autogen.inl
- Format_table_autogen.cpp
- FramebufferAttachmentObjectImpl.h
- FramebufferImpl.h
- FramebufferImpl_mock.h
- GLImplFactory.h
- ImageImpl.h
- ImageImpl_mock.h
- PathImpl.h
- ProgramImpl.h
- ProgramImpl_mock.h
- ProgramPipelineImpl.h
- QueryImpl.h
- RenderTargetCache.h
- RenderbufferImpl.h
- RenderbufferImpl_mock.h
- SamplerImpl.h
- ShaderImpl.h
- StreamProducerImpl.h
- SurfaceImpl.cpp
- SurfaceImpl.h
- SyncImpl.h
- TextureImpl.cpp
- TextureImpl.h
- TextureImpl_mock.h
- TransformFeedbackImpl.h
- TransformFeedbackImpl_mock.h
- VertexArrayImpl.h
- angle_format.py
- angle_format_data.json
- angle_format_map.json
- d3d/
- driver_utils.cpp
- driver_utils.h
- gen_angle_format_table.py
- gen_load_functions_table.py
- gl/
- load_functions_data.json
- load_functions_table.h
- load_functions_table_autogen.cpp
- null/
- renderer_utils.cpp
- renderer_utils.h
- vulkan/
